Implement IntoActiveValue for time types.
#1041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I tried to implement a [custom active model](https://www.sea-ql.org/SeaORM/docs/advanced-query/custom-active-model/), and one of the columns was `Option<TimeDateTimeWithTimeZone>`. I got a compiler error: ``` error[E0277]: the trait bound `std::option::Option<sea_orm::prelude::TimeDateTimeWithTimeZone>: IntoActiveValue<_>` is not satisfied ``` Looking into the source code, it seemed a simple oversight that this trait was implemented for the `chrono` types but not the `time` types, and it was easy enough to fix since there's already a macro to implement it for new types. I also noticed that the `time` types are not accounted for in `src/query/json.rs` while the `chrono` types are, which I assume is also an oversight. However, I don't have a need for that at this point and the fix for that seemed less trivial, so I'm just bringing it to your attention. Thanks for SeaORM!
1 task
billy1624
reviewed
Sep 15, 2022
There was a problem hiding this comment.
Hey @jimmycuadra, thanks for the report and the PR!!
Yes, this is an oversight. And I want to prevent this from happening again by adding test cases and leave a note for all other developers. Please check and merge jimmycuadra#1.
Also, I will address the serialization of time types as serde_json::Value at #1042.
|
Thank you for the fast response! I've merged your PR into my branch. |
|
Thank you |
tyt2y3
added a commit
that referenced
this pull request
Sep 19, 2022
Implement `IntoActiveValue` for `time` types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to implement a custom active model, and one of the columns was
Option<TimeDateTimeWithTimeZone>. I got a compiler error:Looking into the source code, it seemed a simple oversight that this trait was implemented for the
chronotypes but not thetimetypes, and it was easy enough to fix since there's already a macro to implement it for new types.I also noticed that the
timetypes are not accounted for insrc/query/json.rswhile thechronotypes are, which I assume is also an oversight. However, I don't have a need for that at this point and the fix for that seemed less trivial, so I'm just bringing it to your attention.Thanks for SeaORM!