Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to SeaQuery 0.28.0 #1295

Merged
merged 5 commits into from
Jan 5, 2023
Merged

Upgrade to SeaQuery 0.28.0 #1295

merged 5 commits into from
Jan 5, 2023

Conversation

ikrivosheev
Copy link
Member

@ikrivosheev ikrivosheev commented Dec 9, 2022 •
edited
Loading

PR Info

New Features

  • Upgrade SeaQuery to 0.28.0.
  • Upgrade sea-query-binder to 0.3
  • Upgrade SeaSchema

@ikrivosheev ikrivosheev force-pushed the feature/upgrade_sea_query branch 2 times, most recently from bf607a1 to 86830b7 Compare December 9, 2022 10:43
@ikrivosheev
Copy link
Member Author

@billy1624, can you help me with unit tests (https://github.com/SeaQL/sea-orm/actions/runs/3683987195/jobs/6233190997)? I cannot understand where is mistake...

@billy1624
Copy link
Member

Sure! Happy to help :)
Let me check

@billy1624
Copy link
Member

Hey @ikrivosheev, check this ikrivosheev#1

@ikrivosheev
Copy link
Member Author

@billy1624 thank you so mach! Well, I am waiting for release sea-schema and the PR is ready)

billy1624
billy1624 reviewed Dec 14, 2022
View reviewed changes
Copy link
Member

@billy1624 billy1624 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ikrivosheev thanks again for the help!!

@ikrivosheev
Copy link
Member Author

@ikrivosheev thanks again for the help!!

You are welcome!

@billy1624 billy1624 changed the base branch from master to feature/upgrade_sea_query January 5, 2023 10:04
billy1624
billy1624 approved these changes Jan 5, 2023
View reviewed changes
Copy link
Member

@billy1624 billy1624 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ikrivosheev, happy new year! Thanks for the work!!
I'll merge this into a local branch where I have write permission.
Happy vacation :)

@billy1624 billy1624 marked this pull request as ready for review January 5, 2023 10:06
@billy1624 billy1624 merged commit bc834ca into SeaQL:feature/upgrade_sea_query Jan 5, 2023
@billy1624 billy1624 mentioned this pull request Jan 5, 2023
Merged
3 tasks
@ikrivosheev ikrivosheev deleted the feature/upgrade_sea_query branch January 5, 2023 15:01
@ikrivosheev
Copy link
Member Author

Hey @ikrivosheev, happy new year! Thanks for the work!!
I'll merge this into a local branch where I have write permission.
Happy vacation :)

@billy1624 thank you so much! Happy new year)

@tyt2y3
Copy link
Member

tyt2y3 commented Jan 6, 2023 •
edited
Loading

I'll merge this into a local branch where I have write permission.

We can push WIP branches to the SeaQL repos directly, as I think after the PR is merged it will automatically be deleted?

tyt2y3
tyt2y3 reviewed Jan 9, 2023
View reviewed changes
sea-orm-cli/Cargo.toml
@@ -35,7 +35,7 @@ clap = { version = "3.2", default-features = false, features = ["std", "env", "d
dotenvy = { version = "0.15", default-features = false, optional = true }
async-std = { version = "1.9", default-features = false, features = ["attributes", "tokio1"], optional = true }
sea-orm-codegen = { version = "=0.10.3", path = "../sea-orm-codegen", default-features = false, optional = true }
sea-schema = { version = "0.10.2" }
sea-schema = { version = "0.11", git = "https://github.com/SeaQL/sea-schema" }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think sea-schema has been released now?

tyt2y3
tyt2y3 reviewed Jan 9, 2023
View reviewed changes
Copy link
Member

@tyt2y3 tyt2y3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

@tyt2y3
Copy link
Member

tyt2y3 commented Jan 9, 2023 •
edited
Loading

Does that mean we can now abandon SeaORM's ColumnType and IdenStatic?

@billy1624
Copy link
Member

Does that mean we can now abandon SeaORM's ColumnType and IdenStatic?

I think so, we can dump ColumnType and IdenStatic in SeaORM. However, re-export both of the SeaQuery counterparts in the same SeaORM module to make it backward compatible.

@billy1624 billy1624 mentioned this pull request Jan 11, 2023
Closed
@billy1624
Copy link
Member

Does that mean we can now abandon SeaORM's ColumnType and IdenStatic?

I just started a tracking issue for this #1387

@billy1624 billy1624 added this to the 0.11.x milestone Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyt2y3 tyt2y3 tyt2y3 left review comments

@billy1624 billy1624 billy1624 approved these changes

Assignees

@ikrivosheev ikrivosheev

Labels
None yet
Projects
SeaQL Dev Tracker
Archived in project
Milestone
0.11.x
Development

Successfully merging this pull request may close these issues.
3 participants
@ikrivosheev @billy1624 @tyt2y3