Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RecordNotFound -> RecordNotUpdated #1425

Merged
merged 2 commits into from
Jan 26, 2023
Merged

RecordNotFound -> RecordNotUpdated #1425

merged 2 commits into from
Jan 26, 2023

Conversation

tyt2y3
Copy link
Member

@tyt2y3 tyt2y3 commented Jan 26, 2023 •
edited
Loading

This makes the behaviour consistent with RecordNotInserted

@tyt2y3 tyt2y3 requested a review from billy1624 January 26, 2023 09:46
billy1624
billy1624 approved these changes Jan 26, 2023
View reviewed changes
Copy link
Member

@billy1624 billy1624 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!! @tyt2y3 It make sense to have a dedicated "not found" error only for update.

@tyt2y3 tyt2y3 merged commit 37704e1 into master Jan 26, 2023
@tyt2y3 tyt2y3 deleted the record_not_updated branch January 26, 2023 10:41
@billy1624 billy1624 added this to the 0.11.x milestone Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billy1624 billy1624 billy1624 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.11.x
Development

Successfully merging this pull request may close these issues.
2 participants
@tyt2y3 @billy1624