Use full qualifier in derives

[AlbertMarashi]

PR Info

• Closes

• Dependencies:

• Dependents:

New Features

• use full qualifier

Bug Fixes

• not using full qualifier is considered back practice in derives

Breaking Changes

• should not be a breaking change

Changes

• [ ]

[billy1624]

Hey @AlbertMarashi, thanks for the help!! I think we have a few more to fix. Thanks a lot!!

• sea-orm/sea-orm-macros/src/derives/active_model.rs

  Lines 201 to 223 in 59e3ba8

  	Ok(quote!(
  	#[automatically_derived]
  	impl std::convert::TryFrom<ActiveModel> for <Entity as EntityTrait>::Model {
  	type Error = sea_orm::DbErr;
  	fn try_from(a: ActiveModel) -> Result<Self, sea_orm::DbErr> {
  	#(if matches!(a.#active_model_field, sea_orm::ActiveValue::NotSet) {
  	return Err(sea_orm::DbErr::AttrNotSet(stringify!(#active_model_field).to_owned()));
  	})*
  	Ok(
  	Self {
  	#(#model_field: #model_field_value),*
  	}
  	)
  	}
  	}
  	#[automatically_derived]
  	impl sea_orm::TryIntoModel<<Entity as EntityTrait>::Model> for ActiveModel {
  	fn try_into_model(self) -> Result<<Entity as EntityTrait>::Model, sea_orm::DbErr> {
  	self.try_into()
  	}
  	}
  	))

[AlbertMarashi]

@billy1624 done. I'm not entirely sure if these were in any other files either

[AlbertMarashi]

@billy1624 bump

[tyt2y3]

The DeriveActiveModel macro assumes entity::prelude is imported in scope, but I guess no harm to fully-qualify?

[billy1624]

Thanks!! @AlbertMarashi

[AlbertMarashi]

Will this get merged?

[tyt2y3]

thanks for the nudge. yes I'll merge it

[github-actions]

🎉 Released In 1.0.0 🎉

Thank you everyone for the contribution!
This feature is now available in the latest release. Now is a good time to upgrade!
Your participation is what makes us unique; your adoption is what drives us forward.
You can support SeaQL 🌊 by starring our repos, sharing our libraries and becoming a sponsor ⭐.