Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream Changes - 1 #2145

Merged
merged 8 commits into from
Mar 10, 2024
Merged

Upstream Changes - 1 #2145

merged 8 commits into from
Mar 10, 2024

Conversation

billy1624
Copy link
Member

@billy1624 billy1624 commented Mar 6, 2024

Breaking Changes

  • Renamed ConnectOptions::pool_options() to ConnectOptions::sqlx_pool_options()
  • Made sqlx_common private. (Unpublished sqlx_error_to_xxx_err)

Non breaking changes

  • QueryStream::build with pub(crate) visibility
  • DatabaseTransaction::begin with pub(crate) visibility
  • Renamed DatabaseTransaction::map_err_ignore_not_found to DatabaseTransaction::sqlx_map_err_ignore_not_found
  • Renamed conn_acquire_err to sqlx_conn_acquire_err
  • #[sea_orm_macros::test] will append an extra #[cfg(...)] by default; write it once instead of putting it on every tests/*_tests.rs
    quote::quote! (
        #[test]
+       #[cfg(any(
+           feature = "sqlx-mysql",
+           feature = "sqlx-sqlite",
+           feature = "sqlx-postgres",
+       ))]
        #(#attrs)*
        fn #name() #ret {
            let _ = ::tracing_subscriber::fmt()
                .with_max_level(::tracing::Level::DEBUG)
                .with_test_writer()
                .try_init();
            crate::block_on!(async { #body })
        }
    )

Changes

  • Added ColumnTrait::into_returning_expr

@billy1624 billy1624 self-assigned this Mar 6, 2024
@billy1624 billy1624 marked this pull request as ready for review March 7, 2024 06:21
@billy1624 billy1624 force-pushed the upstream-changes-1 branch from b5102bb to 31bf0c8 Compare March 7, 2024 07:21
@billy1624 billy1624 requested a review from tyt2y3 March 7, 2024 08:31
@tyt2y3 tyt2y3 merged commit f3967fd into master Mar 10, 2024
32 checks passed
@tyt2y3 tyt2y3 deleted the upstream-changes-1 branch March 10, 2024 18:14
Copy link

github-actions bot commented Aug 4, 2024

🎉 Released In 1.0.0 🎉

Thank you everyone for the contribution!
This feature is now available in the latest release. Now is a good time to upgrade!
Your participation is what makes us unique; your adoption is what drives us forward.
You can support SeaQL 🌊 by starring our repos, sharing our libraries and becoming a sponsor ⭐.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants