Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PrimaryKeyArity trait #2185

Merged
merged 2 commits into from
May 9, 2024
Merged

PrimaryKeyArity trait #2185

merged 2 commits into from
May 9, 2024

Conversation

billy1624
Copy link
Member

PR Info

@billy1624 billy1624 requested a review from tyt2y3 April 3, 2024 04:01
@billy1624 billy1624 marked this pull request as ready for review April 3, 2024 05:42
tyt2y3
tyt2y3 reviewed Apr 3, 2024
View reviewed changes
Copy link
Member

@tyt2y3 tyt2y3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's really neat! it's a way much smaller breaking change.

still missing the bits from cd7305c#diff-1b04e36af08d9315cb156f4cc59471b6aff13ea5c662d36795bd2b2a85fe2578 though

@tyt2y3 tyt2y3 mentioned this pull request Apr 3, 2024
Closed
tyt2y3
tyt2y3 reviewed May 9, 2024
View reviewed changes
Copy link
Member

@tyt2y3 tyt2y3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant

@tyt2y3 tyt2y3 merged commit c2b8c44 into master May 9, 2024
32 checks passed
@tyt2y3 tyt2y3 deleted the pk-arity-trait branch May 9, 2024 16:50
@github-actions GitHub Actions
Copy link

🎉 Released In 1.0.0-rc.5 🎉

Thank you everyone for the contribution!
This feature is now available in the latest release. Now is a good time to upgrade!
Your participation is what makes us unique; your adoption is what drives us forward.
You can support SeaQL 🌊 by starring our repos, sharing our libraries and becoming a sponsor ⭐.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 4, 2024

🎉 Released In 1.0.0 🎉

Thank you everyone for the contribution!
This feature is now available in the latest release. Now is a good time to upgrade!
Your participation is what makes us unique; your adoption is what drives us forward.
You can support SeaQL 🌊 by starring our repos, sharing our libraries and becoming a sponsor ⭐.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyt2y3 tyt2y3 tyt2y3 approved these changes

Assignees

@tyt2y3 tyt2y3

@billy1624 billy1624

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@billy1624 @tyt2y3