Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposing connection pools for sqlite #2233

Closed
wants to merge 1 commit into from
Closed

Exposing connection pools for sqlite #2233

wants to merge 1 commit into from

Conversation

ys928
Copy link

@ys928 ys928 commented May 22, 2024

PR Info

Changes

  • Provide a function to expose sqlite connection pools

@tyt2y3
Copy link
Member

tyt2y3 commented May 22, 2024

I think this might be what you're looking for?

pub fn get_sqlite_connection_pool(&self) -> &sqlx::SqlitePool {

@ys928
Copy link
Author

ys928 commented May 23, 2024

thanks, I didn't find it beforehand, turns out I also needed to add a sea-orm-internal feature to show this function in vscode's autocompletion

@ys928 ys928 closed this May 23, 2024
@tyt2y3
Copy link
Member

tyt2y3 commented May 23, 2024

I think I will expose it by default moving forward

tyt2y3 added a commit that referenced this pull request May 23, 2024
@ys928
Copy link
Author

ys928 commented May 23, 2024

That's great, but I think this function should be included in the sqlx-sqlite feature.After all, it might not make sense to be able to use it without enabling this feature.

@tyt2y3
Copy link
Member

tyt2y3 commented May 23, 2024

Yes, the method itself is guarded by sqlx-sqlite

@ys928
Copy link
Author

ys928 commented May 24, 2024

Oh, indeed, I was wrong, everything is fine.

Copy link

🎉 Released In 1.0.0-rc.5 🎉

Thank you everyone for the contribution!
This feature is now available in the latest release. Now is a good time to upgrade!
Your participation is what makes us unique; your adoption is what drives us forward.
You can support SeaQL 🌊 by starring our repos, sharing our libraries and becoming a sponsor ⭐.

Copy link

github-actions bot commented Aug 4, 2024

🎉 Released In 1.0.0 🎉

Thank you everyone for the contribution!
This feature is now available in the latest release. Now is a good time to upgrade!
Your participation is what makes us unique; your adoption is what drives us forward.
You can support SeaQL 🌊 by starring our repos, sharing our libraries and becoming a sponsor ⭐.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants