Handling MySQL & SQLite timestamp columns

[billy1624]

PR Info

• Resolve How to define rust type of TIMESTAMP? #344
• Depends on
  • Binding DateTime<FixedOffset> for SQLx MySQL & SQLite sea-query#197
  • Use chrono::NaiveDateTime on MySQL timestamp columns launchbadge/sqlx#1581

Notes to MySQL User

MySQL user should use sea_orm:: DateTimeWithTimeZone for timestamp columns until SQLx upstream merged the PR and released it. Only after that happened, MySQL user could use sea_orm::DateTime for timestamp columns.

[billy1624]

Hey @lz1998, could you please try this PR?

sea-orm = { version = "0.4.0", git = "https://github.com/SeaQL/sea-orm.git", branch = "issues/344", ... }

[lz1998]

Hey @lz1998, could you please try this PR?

sea-orm = { version = "0.4.0", git = "https://github.com/SeaQL/sea-orm.git", branch = "issues/344", ... }

I have tried chrono::DateTime<chrono::Utc> and chrono::DateTime<chrono::FixedOffset>, but both failed.

[billy1624]

Is your entity file similar to below? Defining the timestamp column with type DateTimeWithTimeZone.

use sea_orm::entity::prelude::*;

#[derive(Clone, Debug, PartialEq, DeriveEntityModel)]
#[sea_orm(table_name = "applog")]
pub struct Model {
    #[sea_orm(primary_key)]
    pub id: i32,
    pub action: String,
    pub json: Json,
    pub created_at: DateTimeWithTimeZone,
}

#[derive(Copy, Clone, Debug, EnumIter, DeriveRelation)]
pub enum Relation {}

impl ActiveModelBehavior for ActiveModel {}

[tyt2y3]

I don't think MySQL can work with DateTimeWithTimeZone, there isn't a corresponding concept in MySQL.
The best bet is plain DateTime.

[billy1624]

I don't think MySQL can work with DateTimeWithTimeZone, there isn't a corresponding concept in MySQL. The best bet is plain DateTime.

We cannot decode timestamp column into chrono::NaiveDateTime (for MySQL).

Could we just introduce two more DateTime (timestamp)?

• chrono::DateTime<chrono::Utc> named DateTimeUtc
• chrono::DateTime<chrono::Local> named DateTimeLocal

(Continue our discussion on #344)

[tyt2y3]

So this PR is not needed now?

[billy1624]

So this PR is not needed now?

You mean we have to wait for upstream release? So we have to defer this PR?

[billy1624]

So this PR is not needed now?

I think we should split this PR in half. And release the hotfix part now. MySQL user should use sea_orm:: DateTimeWithTimeZone for timestamp columns until SQLx upstream merged the PR and released it.

Only after that happened, MySQL user could use sea_orm::DateTime for timestamp columns.

[tyt2y3]

Close as the SQLx PR is closed