Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature to generate table Iden #360

Merged
merged 4 commits into from
Dec 12, 2021
Merged

Add feature to generate table Iden #360

merged 4 commits into from
Dec 12, 2021

Conversation

Sytten
Copy link
Contributor

@Sytten Sytten commented Dec 4, 2021

Fixes #356

Let me know where to write the documentation for that. I think a section to use sea-orm with sea-query could be appropriate.

Like I mentioned on discord, I think the strum crate needs a bit of love:

  • The docs.rs links are not pointing at the right place
  • The tests didn't run since they use the old crate name and the attribute could be replaced by sea_strum
  • It should be rebased on the original repo (doable via contacting github support).

@billy1624
Copy link
Member

Hey @Sytten, just now I want to add some test cases. But I don't have the permission to push commits. Can you tick that checkbox and give that permission to sea-orm maintainers. Check here for how to do so.

@billy1624 billy1624 mentioned this pull request Dec 7, 2021
@Sytten
Copy link
Contributor Author

Sytten commented Dec 7, 2021

Ha since I forked under my organization instead of personal, I can't give access to maintainers :S
This is fairly annoying, I will give you repo access I guess?

@billy1624
Copy link
Member

Ha since I forked under my organization instead of personal, I can't give access to maintainers :S This is fairly annoying, I will give you repo access I guess?

That would work :P

@billy1624 billy1624 requested a review from tyt2y3 December 7, 2021 14:34
sea-orm-macros/Cargo.toml Outdated Show resolved Hide resolved
@billy1624
Copy link
Member

Hey @Sytten, for the documentation you can fork and create a PR at https://github.com/SeaQL/seaql.github.io.

Then create a file with name 09-xxx-xxx.md under https://github.com/SeaQL/seaql.github.io/tree/master/SeaORM/docs/08-advanced-query.

@billy1624
Copy link
Member

Thanks!!

@Sytten
Copy link
Contributor Author

Sytten commented Dec 8, 2021

@billy1624 @tyt2y3 I switched to an attribute, let me know what you think!

Copy link
Member

@tyt2y3 tyt2y3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty neat!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Table on the generated Column enum
3 participants