Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Easy joins with MockDatabase #447 #455

Merged
merged 7 commits into from
Feb 6, 2022
Merged

Easy joins with MockDatabase #447 #455

merged 7 commits into from
Feb 6, 2022

Conversation

cemoktra
Copy link
Contributor

@cemoktra cemoktra commented Jan 14, 2022

solves #447

@billy1624
Copy link
Member

Hey @cemoktra, thanks for the help!

src/database/mock.rs Outdated Show resolved Hide resolved
@billy1624
Copy link
Member

Btw... would you might adding some test cases below for both methods?

@cemoktra
Copy link
Contributor Author

I did not find any tests regarding mock rows yet

@cemoktra
Copy link
Contributor Author

I added a basic test

@cemoktra cemoktra requested a review from billy1624 January 20, 2022 15:01
@billy1624 billy1624 linked an issue Jan 21, 2022 that may be closed by this pull request
Copy link
Member

@billy1624 billy1624 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @cemoktra, sorry for the delay. I have added a test case and refactored the code. Please check and cherry pick https://github.com/cemoktra/sea-orm/compare/mock-join...billy1624:pr/455

Copy link
Member

@billy1624 billy1624 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @cemoktra, thanks for the contributions :)

@billy1624 billy1624 requested a review from tyt2y3 January 24, 2022 07:36
@cemoktra
Copy link
Contributor Author

Hey @cemoktra, thanks for the contributions :)

You're welcome

billy1624 added a commit to SeaQL/seaql.github.io that referenced this pull request Jan 31, 2022
@tyt2y3 tyt2y3 force-pushed the master branch 2 times, most recently from 7ce941b to 33a87d7 Compare February 6, 2022 06:39
@tyt2y3 tyt2y3 changed the base branch from master to pull/455 February 6, 2022 06:45
@tyt2y3 tyt2y3 merged commit 47f2f4c into SeaQL:pull/455 Feb 6, 2022
tyt2y3 added a commit that referenced this pull request Feb 6, 2022
Easy joins with MockDatabase #447 (#455)
@cemoktra cemoktra deleted the mock-join branch February 6, 2022 19:14
tyt2y3 added a commit that referenced this pull request Mar 6, 2022
* Add Poem example

* Name conflict of foreign key constraints when two entities have more than one foreign keys (#417)

* fix: name conflict of foreign key constraints when two entities have more than one fk

* test: update test case's foreign keys

* feat: override default name of foreign key constraint

* Add `max_lifetime` connection option

* Remove `r#` prefix from column name when field has a raw identifier

* Fix FromQueryResult when Result is redefined

Macros should only ever use absolute import paths.
Shorthands can clash (as they have in my case).

* Support the use of chrono::DateTime<Utc> in sea-orm

Add documentation for this

Temporarily use a fork to include new Sea-query code

Add tests for DateTimeUtc

Solve Github actions error by add the code to create a table

Assertion accuracy tests

Rectify incorrect format

* Refactoring

`ColumnDef` with default value

Cargo fmt

Update docs

Fixup

Support `DateTimeLocal`

Update docs

Codegen write db timestamp column as `DateTimeUtc` type

Update dependency

Merge branch 'sea-query/add-new-column-ref' into pr/429

feat: apply alias on `ColumnRef::SchemaTableColumn`

* Update sea-query dependency

* Fully quantity `std::result::Result` in proc_maros

* Migration (#335)

* Refactor `ConnectionTrait`

* Refactoring

* Build index & foreign key statements

* Fix imports

* Fixup

* Rocket example with migration

* async-std compatible with the tokio 1.0 runtime

* Use reexported dependency

* Compile without selecting any db backend

* Updating sea-orm-cli dep

* sea-orm-cli migrate commands

* cargo fmt

* Test [cli]

* Refactoring

* Clap app name should be "sea-orm-cli"

* Correctly capture MIGRATION_DIR

* Rename README

* Add `sea-orm-cli migrate init` command

* Update README

* Try restructured sea-query dependency (SeaQL/sea-schema#41)

* Set `DATABASE_URL` environment variable

* Fix sea-schema dependency

* Codegen `column_name` proc_macro attribute (#433)

* feat: codegen `column_name` proc_macro attribute

* test: codegen `column_name`

* Temporary fix

* Fix sea-orm dependency

* Insert Default - Inserting `ActiveModel` with all attributes `NotSet` (#432)

* feat: apply alias on `ColumnRef::SchemaTableColumn`

* build: update sea-query dependency

* feat: insert default

* Use sea-query 0.21

Co-authored-by: Billy Chan <ccw.billy.123@gmail.com>

* Easy joins with MockDatabase #447 (#455)

* Easy joins with MockDatabase #447

* fix MR

* add unit test

* Add test cases

* Cargo fmt

Co-authored-by: Bastian Schubert <bastian.schubert@crosscard.com>
Co-authored-by: Billy Chan <ccw.billy.123@gmail.com>
Co-authored-by: Chris Tsang <chris.2y3@outlook.com>

* cargo fmt

* Revert "Insert Default - Inserting `ActiveModel` with all attributes `NotSet` (#432)"

This reverts commit 33a87d7.

* Prepare release

* sea-orm-codegen 0.6.0

* sea-orm-cli 0.6.0

* sea-orm-macros 0.6.0

* 0.6.0

* Optimize GitHub actions

* Update examples sea-orm version

Update example sea-schema version

Update [cli] sea-schema version

* Fix [cli] cargo publish failed

* Update CHANGELOG

* Use sea-schema 0.5.1

* use sea_schema::migration::prelude

* Use caret requirements

* Fix build error

* Examples with migration (#509)

* Update examples sea-orm version

* Update example sea-schema version

* Update [cli] sea-schema version

* Fix [cli] cargo publish failed

* Update CHANGELOG

* Edit rocket example

* Poem example with migration

* Axum example with migration

* Refactoring

* Actix4 example with migration

* Actix example with migration

* Use sea_schema::migration::prelude

Co-authored-by: Sunli <scott_s829@163.com>
Co-authored-by: Billy Chan <30400950+billy1624@users.noreply.github.com>
Co-authored-by: Billy Chan <ccw.billy.123@gmail.com>
Co-authored-by: Szepesi Tibor <sztibi023@gmail.com>
Co-authored-by: Tom Hacohen <tasn@users.noreply.github.com>
Co-authored-by: Charles Chege <charleschege@protonmail.ch>
Co-authored-by: Bastian <b.schubert82@gmail.com>
Co-authored-by: Bastian Schubert <bastian.schubert@crosscard.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Testing joins with MockDatabase
3 participants