Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade to Actix Web 4 #638

Merged
merged 2 commits into from
Apr 2, 2022
Merged

chore: Upgrade to Actix Web 4 #638

merged 2 commits into from
Apr 2, 2022

Conversation

Chaostheorie
Copy link
Contributor

@Chaostheorie Chaostheorie commented Mar 28, 2022

PR Info

This PR is bumping the Actix Web 4 beta example to the latest stable Actix Web 4 version. Additionally, a few adjustments for the new versions were in the example.

This PR also renames the actix4_example → actix_example and actix_example → actix3_example to reflect the change in stable Actix Web versions.

Fixes #639

Adds

Features were kept the same.

Breaking Changes

None, AFAIK.

Changes

See PR Info.

@tyt2y3
Copy link
Member

tyt2y3 commented Mar 31, 2022

Awesome. Greatly appreciated. Can you also change https://github.com/SeaQL/sea-orm/blob/master/.github/workflows/rust.yml#L296 ?

@Chaostheorie
Copy link
Contributor Author

Thank you for the pointer, I totally overlooked the GitHub CI. Are there any other changes that should be applied?

@tyt2y3
Copy link
Member

tyt2y3 commented Apr 2, 2022

Great. It seems to work now. Thanks again

@tyt2y3 tyt2y3 merged commit 6a22207 into SeaQL:master Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Actix Web examples
2 participants