Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DatabaseConnection always derive Clone #665

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/database/db_connection.rs
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,14 @@ use std::sync::Arc;

/// Handle a database connection depending on the backend
/// enabled by the feature flags. This creates a database pool.
#[cfg_attr(not(feature = "mock"), derive(Clone))]
///
/// All connections including mock connection can be cloned.
/// However, cloning mock connection is in fact cloning
/// the shared reference, [`std::sync::Arc`], of it. If your test cases
/// involved concurrent operations on mock connection, query results
/// and transaction logs could vary depending on the sequence
/// in which concurrent operations are executed.
#[derive(Clone)]
pub enum DatabaseConnection {
/// Create a MYSQL database connection and pool
#[cfg(feature = "sqlx-mysql")]
Expand Down