Revamp Value to typed null value
#107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billy1624
force-pushed
the
typed-null-value
branch
from
b5bd51e to
9b5e782
Compare
billy1624
force-pushed
the
typed-null-value
branch
from
d50daf3 to
e0f42ea
Compare
tyt2y3
reviewed
Aug 21, 2021
| #[cfg(feature = "with-chrono")] | ||
| Value::Date(_) => PostgresQueryBuilder.value_to_string(value).into(), | ||
| #[cfg(feature = "with-chrono")] | ||
| Value::Time(_) => PostgresQueryBuilder.value_to_string(value).into(), | ||
| #[cfg(feature = "with-chrono")] | ||
| Value::DateTime(_) => PostgresQueryBuilder.value_to_string(value).into(), | ||
| #[cfg(feature = "with-chrono")] | ||
| Value::DateTimeWithTimeZone(_) => PostgresQueryBuilder.value_to_string(value).into(), |
There was a problem hiding this comment.
I realized it cannot compile if the Postgres backend is not enabled. I will refactor it later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem
When using a prepared statement, the parameter binding must be of the same type as when prepared. As such,
0i32is not compatible withNone<bool>, it has to beNone<i32>. To mitigate this, we have to remove the genericNullvariant, and users have to indicate the associated type of theNULL.The changes
Valueto support more native typesIt will be a rather big breaking change, but hopefully users would not have to change a lot of their existing code.
An upgrade guide will be provided afterwards.