Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ColumnType unsigned integer types #211

Merged
merged 2 commits into from
Feb 20, 2022
Merged

Conversation

billy1624
Copy link
Member

@billy1624 billy1624 commented Dec 22, 2021

@billy1624 billy1624 self-assigned this Dec 22, 2021
Copy link
Member

@tyt2y3 tyt2y3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. But is there any reason for not adding Unsigned variants to Value?

@billy1624
Copy link
Member Author

Great. But is there any reason for not adding Unsigned variants to Value?

I think we already have that?

sea-query/src/value.rs

Lines 23 to 40 in 79c58c5

/// Value variants
///
/// We want Value to be exactly 1 pointer sized, so anything larger should be boxed.
#[derive(Clone, Debug, PartialEq)]
pub enum Value {
Bool(Option<bool>),
TinyInt(Option<i8>),
SmallInt(Option<i16>),
Int(Option<i32>),
BigInt(Option<i64>),
TinyUnsigned(Option<u8>),
SmallUnsigned(Option<u16>),
Unsigned(Option<u32>),
BigUnsigned(Option<u64>),
Float(Option<f32>),
Double(Option<f64>),
String(Option<Box<String>>),

@tyt2y3 tyt2y3 merged commit b78acb2 into master Feb 20, 2022
@tyt2y3 tyt2y3 deleted the add-col-type-unsigned-int branch February 20, 2022 12:47
@tyt2y3
Copy link
Member

tyt2y3 commented Feb 20, 2022

Oh really. Awesome!

@tyt2y3 tyt2y3 mentioned this pull request Mar 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants