Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Insert ON CONFLICT #279

Merged
merged 6 commits into from
Apr 3, 2022
Merged

Insert ON CONFLICT #279

merged 6 commits into from
Apr 3, 2022

Conversation

billy1624
Copy link
Member

PR Info

Adds

  • Support ON CONFLICT

@billy1624 billy1624 self-assigned this Mar 24, 2022
@billy1624 billy1624 mentioned this pull request Mar 24, 2022
Closed
@billy1624 billy1624 marked this pull request as ready for review March 24, 2022 10:48
@billy1624 billy1624 requested a review from tyt2y3 March 24, 2022 10:48
@billy1624 billy1624 mentioned this pull request Mar 24, 2022
Closed
@billy1624
Copy link
Member Author

I think we still need to add two more OnConflictAction

  • Update by Value
  • Update by SimpleExpr

@billy1624
Copy link
Member Author

I think we still need to add two more OnConflictAction

  • Update by Value
  • Update by SimpleExpr

Added on ae692a9. Ready for review

tyt2y3
tyt2y3 reviewed Apr 3, 2022
View reviewed changes
src/backend/query_builder.rs
if let Some(action) = on_conflict_action {
match action {
OnConflictAction::DoNothing => {
write!(sql, " DO NOTHING").unwrap();
Copy link
Member

@tyt2y3 tyt2y3 Apr 3, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think only having the prefix space here looks strange, albeit I understand why

@tyt2y3 tyt2y3 merged commit cc928ac into master Apr 3, 2022
@tyt2y3 tyt2y3 deleted the on-conflict-1 branch April 3, 2022 07:27
This was referenced Apr 6, 2022
Closed
Closed
@SebastienGllmt SebastienGllmt mentioned this pull request Apr 13, 2022
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Progdrasil Progdrasil Progdrasil left review comments

@tyt2y3 tyt2y3 tyt2y3 left review comments

Assignees

@billy1624 billy1624

Labels
None yet
Projects
SeaQL Dev Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UPSERT statement support
3 participants
@billy1624 @tyt2y3 @Progdrasil