Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issues-295 Add parameter for sqlx path to proc-macro #297

Merged
merged 10 commits into from
Apr 13, 2022

Conversation

ikrivosheev
Copy link
Member

@ikrivosheev ikrivosheev commented Apr 6, 2022

PR Info

Adds

After this PR can do: sea_query::sea_query_driver_postgres!(common);, where common is prefix for ::sqlx

Changes

  • prefix for sqlx in drivers
  • prefix for sea-query in drivers

Copy link
Member

@tyt2y3 tyt2y3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot

sea-query-driver/src/sqlx_mysql.rs Outdated Show resolved Hide resolved
@ikrivosheev ikrivosheev requested a review from tyt2y3 April 7, 2022 06:02
@tyt2y3
Copy link
Member

tyt2y3 commented Apr 9, 2022

thanks, but I don't understand how this is intended to be used.
if I want to specify prefix for both sqlx and seaquery, what should I do?

@ikrivosheev
Copy link
Member Author

ikrivosheev commented Apr 10, 2022

thanks, but I don't understand how this is intended to be used. if I want to specify prefix for both sqlx and seaquery, what should I do?

Sorry for the delay, I was setting up a new laptop...

Example:

sea_query::sea_query_driver_postgres!(driver="common", sea_query="common");
// or
sea_query::sea_query_driver_postgres!(sea_query="common", driver="common");
// or
sea_query::sea_query_driver_postgres!(sea_query="common");
// or
sea_query::sea_query_driver_postgres!(driver="common");
// or
sea_query::sea_query_driver_postgres!();

@tyt2y3
Copy link
Member

tyt2y3 commented Apr 11, 2022

Cool, we should put those in the docs

@ikrivosheev
Copy link
Member Author

@tyt2y3 maybe you saw an example of the documentation where it is reflected?

Co-authored-by: Martin Grigorov <martin-g@users.noreply.github.com>
@ikrivosheev ikrivosheev requested a review from tyt2y3 April 12, 2022 16:09
Copy link
Member

@tyt2y3 tyt2y3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

@tyt2y3 tyt2y3 merged commit f098501 into SeaQL:master Apr 13, 2022
@ikrivosheev ikrivosheev deleted the fix/issues-295_reexport_sea-query branch October 19, 2022 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to use sea_query_driver_postgres! macro with re-exported sqlx from another crate
3 participants