Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/issues 156 extended returning support #317

Merged
merged 13 commits into from
May 11, 2022
Merged

Feature/issues 156 extended returning support #317

merged 13 commits into from
May 11, 2022

Conversation

ikrivosheev
Copy link
Member

@ikrivosheev ikrivosheev mentioned this pull request May 4, 2022
Merged
@ikrivosheev
issues-156 End with Returning expression
d780568 
1) Fix tests
2) Fix docs
3) Fix query_builder.rs
@ikrivosheev ikrivosheev marked this pull request as ready for review May 4, 2022 18:09
@ikrivosheev ikrivosheev requested review from tyt2y3 and billy1624 May 4, 2022 18:09
@ikrivosheev
Copy link
Member Author

@billy1624 @tyt2y3 done, can you review my PR, please.

@RomainMazB you were also interested.

billy1624
billy1624 reviewed May 5, 2022
View reviewed changes
Copy link
Member

@billy1624 billy1624 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ikrivosheev
Copy link
Member Author

@billy1624 thank you! I add support for returning_all. MariaDB support RETURNING only for INSERT and DELETE, in the first option, I think that this is enough, without support MariaDB.

tyt2y3
tyt2y3 approved these changes May 11, 2022
View reviewed changes
Copy link
Member

@tyt2y3 tyt2y3 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I feel slightly sad to have broke this API, but seems like it's a good move

@tyt2y3 tyt2y3 merged commit 88d2c87 into master May 11, 2022
@tyt2y3 tyt2y3 deleted the feature/issues-156_extended-returning-support branch May 11, 2022 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billy1624 billy1624 billy1624 left review comments

@tyt2y3 tyt2y3 tyt2y3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better support for returnimg statement on back ends
4 participants
@ikrivosheev @tyt2y3 @billy1624 @marlon-sousa