-
-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add is / is_not to Expr #348
Conversation
@Sytten thank you for the PR! |
Right I will remove it, I did a stupid copy paste |
@Sytten as I know in postgresql we can use |
Agreed |
So how do we wish to proceed? Just leave it open for any backend? |
Yes. We don't feature guard the frontend (unless a feature is only relevant to one backend), because it's only determined when building the query. |
@tyt2y3 @ikrivosheev I made the changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Sytten thank you! LGTM!
Thank you all |
* Add is / is_not to Expr * Change example and remove sqlite limitation * Change more examples
For Sqlite, they are the same as
eq
andneq
but treat NULL differently.I put them behind a flag since I don't think other DBMS allow random values with those operators.
Adds
IS
andIS NOT
operators forSqlite