Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exclude chrono default-features #410

Merged
merged 1 commit into from
Aug 13, 2022
Merged

exclude chrono default-features #410

merged 1 commit into from
Aug 13, 2022

Conversation

robjtede
Copy link
Contributor

@robjtede robjtede commented Aug 8, 2022 •
edited
Loading

in an effort to remove time v0.1 from the dep graph

robjtede
robjtede commented Aug 8, 2022
View reviewed changes
Copy link
Contributor Author

@robjtede robjtede left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(oops, "reviewed" in github.dev by accident)

@ikrivosheev
Copy link
Member

@robjtede, hello! Can you explane, what you want?

@robjtede robjtede mentioned this pull request Aug 8, 2022
Merged
@robjtede
Copy link
Contributor Author

robjtede commented Aug 8, 2022 •
edited
Loading

cargo audit compains about vulnerabilities in time v0.1 which is enabled transitively via chrono when the oldtime feature is enabled. This PR disables that feature of chrono since it's very unlikely that sea-query relies on the feature.

billy1624
billy1624 reviewed Aug 9, 2022
View reviewed changes
Copy link
Member

@billy1624 billy1624 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @robjtede, thanks for the auditing!

Same here :)
I would suggest pinning the version to ^0.4 insead of ^0

@robjtede
Copy link
Contributor Author

robjtede commented Aug 9, 2022 •
edited
Loading

I would suggest pinning the version to ^0.4 insead of ^0

yep so would I but i've left them all as they were since it's not the purpose of this PR

(I'd also suggest not using ^ in the version reqs, but... as above...)

@billy1624
Copy link
Member

billy1624 commented Aug 9, 2022 •
edited
Loading

Oh... sorry I thought it was ^0.4 but in fact it's originally ^0

@tyt2y3
Copy link
Member

tyt2y3 commented Aug 13, 2022

Thank you for letting us know @robjtede

@tyt2y3 tyt2y3 merged commit 42f1473 into SeaQL:master Aug 13, 2022
@robjtede robjtede deleted the x-chrono-def branch August 13, 2022 15:56
tyt2y3 pushed a commit that referenced this pull request Aug 17, 2022
@robjtede @tyt2y3
exclude chrono default-features (#410)
0b6cbe5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billy1624 billy1624 billy1624 left review comments

Assignees

@robjtede robjtede

Labels
None yet
Projects
SeaQL Dev Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@robjtede @ikrivosheev @billy1624 @tyt2y3