Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup IndexBuilder trait methods #426

Merged
merged 4 commits into from
Sep 13, 2022
Merged

Cleanup IndexBuilder trait methods #426

merged 4 commits into from
Sep 13, 2022

Conversation

nahuakang
Copy link
Contributor

PR Info

Per discussion here, we could clean up the IndexBuilder trait methods.

  • Dependencies:

Changes

  • PostgresQueryBuilder and SqliteQueryBuilder could use the default prepare_table_index_expression from IndexBuilder.
  • MysqlQueryBuilder implements its own prepare_table_index_expression method.
  • All 3 backend query builders implement their own prepare_index_create_statement (each differs slightly).

@nahuakang nahuakang marked this pull request as ready for review August 28, 2022 20:28
ikrivosheev
ikrivosheev approved these changes Aug 28, 2022
View reviewed changes
Copy link
Member

@ikrivosheev ikrivosheev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nahuakang thank you! LGTM!

@billy1624 billy1624 mentioned this pull request Aug 29, 2022
Closed
@billy1624 billy1624 linked an issue Aug 29, 2022 that may be closed by this pull request
Wrong spacing before UNIQUE keyword #404
Closed
billy1624
billy1624 approved these changes Aug 29, 2022
View reviewed changes
Copy link
Member

@billy1624 billy1624 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat and clean :)
Thanks!! @nahuakang

@tyt2y3
Copy link
Member

tyt2y3 commented Sep 13, 2022

Thank you

@tyt2y3 tyt2y3 merged commit b5cd357 into SeaQL:master Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billy1624 billy1624 billy1624 approved these changes

@ikrivosheev ikrivosheev ikrivosheev approved these changes

Assignees

@nahuakang nahuakang

Labels
None yet
Projects
SeaQL Dev Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong spacing before UNIQUE keyword
4 participants
@nahuakang @tyt2y3 @ikrivosheev @billy1624