Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issues-383 Remove driver #434

Merged
merged 2 commits into from
Sep 7, 2022
Merged

issues-383 Remove driver #434

merged 2 commits into from
Sep 7, 2022

Conversation

ikrivosheev
Copy link
Member

PR Info

Breaking Changes

  • Remove sea-query-driver
  • Remove features from sea-query: rusqlite, sqlx-mysql, sqlx-postgres, sqlx-sqlite

billy1624
billy1624 approved these changes Sep 7, 2022
View reviewed changes
Copy link
Member

@billy1624 billy1624 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!! @ikrivosheev

tyt2y3
tyt2y3 approved these changes Sep 7, 2022
View reviewed changes
Copy link
Member

@tyt2y3 tyt2y3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. This is a lot cleaner!

@tyt2y3 tyt2y3 merged commit f6c45e9 into SeaQL:master Sep 7, 2022
@ikrivosheev ikrivosheev deleted the feature/issues-383_remove_driver branch September 7, 2022 15:25
@tyt2y3
Copy link
Member

tyt2y3 commented Sep 7, 2022

I am glad that sea-query is pretty much 'pure' now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billy1624 billy1624 billy1624 approved these changes

@tyt2y3 tyt2y3 tyt2y3 approved these changes

Assignees

@ikrivosheev ikrivosheev

Labels
None yet
Projects
SeaQL Dev Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate / remove driver in favour of binder
3 participants
@ikrivosheev @tyt2y3 @billy1624