Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve issue #457 #455

Merged
merged 2 commits into from
Oct 11, 2022
Merged

Resolve issue #457 #455

merged 2 commits into from
Oct 11, 2022

Conversation

pweglik
Copy link

@pweglik pweglik commented Sep 27, 2022

PR Info

The issue was opened in sea-orm repo:
#457

Fixes

  • [ SQL code wasn't generated for DropColumn option for SQLite even though it was added in SQLite 3.35]
  • [ Fixed tests and docstring concerning above bug]

@pweglik pweglik changed the title Fix/issue 1065 sea orm Resolve issue #1065 in sea-orm repo Sep 27, 2022
@billy1624 billy1624 linked an issue Sep 28, 2022 that may be closed by this pull request
@pweglik pweglik changed the title Resolve issue #1065 in sea-orm repo Resolve issue #457 Sep 28, 2022
Copy link
Member

@billy1624 billy1624 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing!! @pweglik

Copy link
Member

@ikrivosheev ikrivosheev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pweglik thank you! LGTM!

@pweglik
Copy link
Author

pweglik commented Oct 11, 2022

Just pinging @tyt2y3 for review, cuz I think he missed it

Copy link
Member

@tyt2y3 tyt2y3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ikrivosheev Can you merge and update change log?

It also seems worthy to backport to 0.26

@ikrivosheev ikrivosheev merged commit 8abb0b5 into SeaQL:master Oct 11, 2022
@ikrivosheev
Copy link
Member

@tyt2y3 done! This was my first merged PR)

ikrivosheev added a commit to ikrivosheev/sea-query that referenced this pull request Oct 11, 2022
@ikrivosheev ikrivosheev mentioned this pull request Oct 11, 2022
@tyt2y3
Copy link
Member

tyt2y3 commented Oct 11, 2022

Awesome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add SQLite ALTER TABLE support
4 participants