add support for sqlite MATCH operator #504
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@evgeniy-terekhin thank you for PR! I think Postgres |
can you please elaborate on this? and maybe suggest a different approach? edit: I am not going to argue that they are semantically identical. though they serve a similar ppurpose: they are used for ful text search matching. Also they are both binary operators whose purpose is matching of some sort. |
|
@evgeniy-terekhin I think is better to move sqlite specific operators into new enum. Something like I did here: #506. @billy1624 @tyt2y3 what do you think? |
|
closing in favor of this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR adds support for sqlite MATCH operator used primarily for full text search purposes
It does so by allowing
Expr::Matchesto be used not only for postgres but also for sqlite