Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issues-518 Implement Expr::cust_with_expr and Expr::cust_with_exprs #531

Merged
merged 4 commits into from
Dec 8, 2022
Merged

issues-518 Implement Expr::cust_with_expr and Expr::cust_with_exprs #531

merged 4 commits into from
Dec 8, 2022

Conversation

ikrivosheev
Copy link
Member

PR Info

New Features

  • Added Expr::cust_with_expr
  • Added Expr::cust_with_exprs

Breaking Changes

  • Deprecated Expr::cust_with_values

@ikrivosheev ikrivosheev mentioned this pull request Nov 25, 2022
Closed
@ikrivosheev ikrivosheev self-assigned this Nov 25, 2022
@tyt2y3
Copy link
Member

tyt2y3 commented Nov 28, 2022

  1. can we add more complex test cases to illustrate the intended bahaviour if we have other things that can be SimpleExpr?
  2. it's worth keeping expr_with_values and not deprecate it

@ikrivosheev
Copy link
Member Author

  1. can we add more complex test cases to illustrate the intended bahaviour if we have other things that can be SimpleExpr?

    1. it's worth keeping expr_with_values and not deprecate it

@tyt2y3 thank you!

  1. Ok, I will add more tests
  2. I have already done this.

billy1624
billy1624 reviewed Nov 29, 2022
View reviewed changes
src/expr.rs Outdated Show resolved Hide resolved
@ikrivosheev ikrivosheev force-pushed the feature/issues-518_cust_with_expr branch from 9885232 to 38982b4 Compare December 6, 2022 12:13
tyt2y3
tyt2y3 reviewed Dec 6, 2022
View reviewed changes
src/expr.rs Outdated Show resolved Hide resolved
@tyt2y3
Copy link
Member

tyt2y3 commented Dec 6, 2022

Oh it passes now just need some formatting

@ikrivosheev ikrivosheev force-pushed the feature/issues-518_cust_with_expr branch from 3bc5801 to 01b416f Compare December 6, 2022 21:24
@ikrivosheev
Copy link
Member Author

Oh it passes now just need some formatting

@tyt2y3 thank you! Done.

billy1624
billy1624 approved these changes Dec 8, 2022
View reviewed changes
Copy link
Member

@billy1624 billy1624 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!! @ikrivosheev

@ikrivosheev ikrivosheev merged commit d57bffa into SeaQL:master Dec 8, 2022
@ikrivosheev ikrivosheev deleted the feature/issues-518_cust_with_expr branch December 8, 2022 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billy1624 billy1624 billy1624 approved these changes

@tyt2y3 tyt2y3 Awaiting requested review from tyt2y3

Assignees

@ikrivosheev ikrivosheev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DISTINCT within Postgres' aggregate functions?
3 participants
@ikrivosheev @tyt2y3 @billy1624