Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement SqlxBinder for WithQuery #580

Merged
merged 4 commits into from
Feb 1, 2023
Merged

implement SqlxBinder for WithQuery #580

merged 4 commits into from
Feb 1, 2023

Conversation

matt-phylum
Copy link
Contributor

There aren't any tests included. I think the examples should be updated to include a WITH query, but to do it properly would probably involve changing the schema of the example database.

PR Info

  • Dependencies:
  • Dependents:

New Features

Bug Fixes

  • WithQuery can be used with build_sqlx the same way as the other statement types.

Breaking Changes

Changes

ikrivosheev
ikrivosheev reviewed Jan 12, 2023
View reviewed changes
Copy link
Member

@ikrivosheev ikrivosheev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matt-phylum hello! Thank you for the PR, can you also add to sea-query-rusqlite and sea-query-postgres?

@ikrivosheev
Copy link
Member

@matt-phylum hello, any updates?

ikrivosheev
ikrivosheev approved these changes Feb 1, 2023
View reviewed changes
Copy link
Member

@ikrivosheev ikrivosheev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matt-phylum thank you! LGTM!

@ikrivosheev ikrivosheev merged commit ec370de into SeaQL:master Feb 1, 2023
@nomorechokedboy
Copy link

nomorechokedboy commented May 11, 2023 •
edited
Loading

@ikrivosheev Did you include this in the latest release? Currently, on the latest release 0.28.4, I can't use build_sqlx with WithQuery

@tyt2y3
Copy link
Member

tyt2y3 commented May 11, 2023

No. It is not currently in 0.28 but I think we can include that

tyt2y3 pushed a commit that referenced this pull request May 11, 2023
@ikrivosheev @tyt2y3
Merge pull request #580 from matt-phylum/with
98274e9 
implement SqlxBinder for WithQuery
@tyt2y3
Copy link
Member

tyt2y3 commented May 11, 2023

https://github.com/SeaQL/sea-query/compare/0.28.4..516f0db2

@github-actions
Copy link

🎉 Released In 0.29.0 🎉

Your participation is what makes us unique; your adoption is what drives us forward.
Thank you all in the Rust community for making SeaQL what it is today. 🦀
You are also invited to shape it's future! Please star our repos, every ⭐ counts!

@github-actions
Copy link

🎉 Released In 0.29.1 🎉

Thank you everyone for the contribution!
This feature is now available in the latest release. Now is a good time to upgrade!
Your participation is what makes us unique; your adoption is what drives us forward.
You can support SeaQL 🌊 by starring our repos, sharing our libraries and becoming a sponsor ⭐.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikrivosheev ikrivosheev ikrivosheev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WithQuery not usable with SqlxBinder
4 participants
@matt-phylum @ikrivosheev @nomorechokedboy @tyt2y3