Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Asteriks from Expr to new type #596

Merged
merged 2 commits into from
Feb 5, 2023

Conversation

ikrivosheev
Copy link
Member

New Features

  • Create new type: Asteriks

Breaking Changes

  • Deprecated Expr::asteriks and Expr::table_asteriks

@ikrivosheev ikrivosheev self-assigned this Feb 1, 2023
@tyt2y3
Copy link
Member

tyt2y3 commented Feb 2, 2023

Neat idea. Since we removed some doc tests, can we add them on the struct Asterisk itself?

@ikrivosheev
Copy link
Member Author

Neat idea. Since we removed some doc tests, can we add them on the struct Asterisk itself?

@tyt2y3 thank you! Done.

@ikrivosheev ikrivosheev merged commit 0943eb9 into SeaQL:master Feb 5, 2023
@ikrivosheev ikrivosheev deleted the feature/asteriks_as_type branch February 5, 2023 16:55
@github-actions
Copy link

🎉 Released In 0.29.0 🎉

Your participation is what makes us unique; your adoption is what drives us forward.
Thank you all in the Rust community for making SeaQL what it is today. 🦀
You are also invited to shape it's future! Please star our repos, every ⭐ counts!

@github-actions
Copy link

🎉 Released In 0.29.1 🎉

Thank you everyone for the contribution!
This feature is now available in the latest release. Now is a good time to upgrade!
Your participation is what makes us unique; your adoption is what drives us forward.
You can support SeaQL 🌊 by starring our repos, sharing our libraries and becoming a sponsor ⭐.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants