Add support for COUNT(DISTINCT a)
#700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyt2y3
approved these changes
Dec 14, 2023
🎉 Released In 0.30.5 🎉Thank you everyone for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Info
COUNT(DISTINCT a.b)#600New Features
count_distinctinExprandFuncwhich corresponds toCOUNT(DISTINCT a)Changes
boolparameter toFunctionCallnameddistinctwhich will keep track if theDISTINCTmodifier needs to be applied for the first argument.Note:
For now, adding the
distinctparameter toFunctionCallmay seem like an overkill to support just one use case, but in the future more functions could be added that support theDISTINCTmodifier. Technically every aggregate function actually supports it but they are rarely used except forCOUNT.