-
-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(sea-query): Fix clippy warnings on Rust 1.75 #729
Conversation
src/extension/postgres/mod.rs
Outdated
@@ -1,6 +1,7 @@ | |||
pub use expr::*; | |||
pub use extension::*; | |||
pub use func::*; | |||
#[allow(unused_imports)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are no exported members in interval module so clippy warns it, should we just remove this re-export or keep with #[allow]
for future usages?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If that's the case it's good to remove pub
from pub use
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, all code in the interval.rs
is impl so we can remove this use
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, removed entire the re-export in b94ea89
Thank you! You are so fast |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
🎉 Released In 0.30.6 🎉Thank you everyone for the contribution! |
PR Info
New Features
N/A
Bug Fixes
N/A
Breaking Changes
N/A
Changes