Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add with_cte to include WITH clauses in Statements #859

Merged
merged 1 commit into from
Feb 16, 2025

Conversation

rumpuslabs
Copy link
Contributor

…instead of separate WithQuery

PR Info

New Features

  • Adds with_cte method to SelectStatement/UpdateStatement/InsertStatement/DeleteStatement to allow adding WITH clauses to any query

Notes

  • I had to choose another method name to avoid breaking backward compatibiity of the existing fn with(...) -> WithQuery. I'm not completely happy with with_cte but couldn't think of anything better.
  • If the intention is to eventually remove WithQuery, we could add #[deprecated] to thewith methods to encourage users to migrate

Copy link
Member

@tyt2y3 tyt2y3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@tyt2y3 tyt2y3 merged commit 7bf9980 into SeaQL:master Feb 16, 2025
20 checks passed
@rumpuslabs rumpuslabs deleted the unify-with branch February 16, 2025 21:16
Copy link

🎉 Released In 0.32.2 🎉

Thank you everyone for the contribution!
This feature is now available in the latest release. Now is a good time to upgrade!
Your participation is what makes us unique; your adoption is what drives us forward.
You can support SeaQL 🌊 by starring our repos, sharing our libraries and becoming a sponsor ⭐.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unify SelectStatement and WithQuery
2 participants