Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

Commit

Permalink
CORTX-33789: Hare Config stage fail with Motr Clients (#2146)
Browse files Browse the repository at this point in the history
Problem:
If num_client_inst is specified a non-zero value, deployment is failing.
Issue is with search key. For data nodes we used 'io':'motr', it returns the
list of machine IDs which includes both data node and motr client nodes,
because of which deployment was failing.

Solution:
Separated search key for data node and motr client node.

Signed-off-by: pavankrishnat <pavan.k.thunuguntla@seagate.com>
  • Loading branch information
pavankrishnat authored Aug 5, 2022
1 parent 150112e commit 4458b54
Showing 1 changed file with 8 additions and 3 deletions.
11 changes: 8 additions & 3 deletions provisioning/miniprov/hare_mp/store.py
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,13 @@ def get_machine_ids_for_service(self, service_type: str) -> List[str]:
service_type will be like Const.SERVICE_MOTR_IO.value,
Const.SERVICE_S3_SERVER.value etc
"""
if service_type == 'io':
return self.get_machine_ids_for_attribute('num_cvg')
# presently, For service_type: motr_client, both client and data pods
# are returned by the conf store search query. But data pods are
# filtered out while creating node in _create_node().
types = {
'io': 'motr',
'motr_client': 'motr',
'rgw_s3': 'rgw',
'agent': 'csm'
}
Expand Down Expand Up @@ -121,7 +126,7 @@ def get_machine_ids_for_component(self, comp_type: str) -> List[str]:
return self.get_machine_ids_for_attribute('name', comp_type)

def get_machine_ids_for_attribute(self, attr_type: str,
name: str) -> List[str]:
name: str = None) -> List[str]:
"""
Return a list of pod's machine_id for the machines consisting
the attribute name under the given attribute type.
Expand Down Expand Up @@ -173,7 +178,7 @@ def get_data_nodes(self) -> List[str]:
return self.get_machine_ids_for_service(Const.SERVICE_MOTR_IO.value)

def search_val(self, parent_key: str, search_key: str,
search_val: str) -> List[str]:
search_val: str = None) -> List[str]:
"""
Searches a given key value under the given parent key.
"""
Expand Down

0 comments on commit 4458b54

Please sign in to comment.