This repository has been archived by the owner on Feb 8, 2024. It is now read-only.
CORTX-33876: Log device size should be power of 2 with limits #2151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mssawant
reviewed
Aug 19, 2022
Shreya-18
force-pushed
the
log_dev
branch
2 times, most recently
from
6cc485b to
948b2db
Compare
|
Tested PR on 1N bootstrap with loop devices. [root@centos01 sysconfig]# cat m0d-0x7200000000000001:0x2 |
d-nayak
approved these changes
Aug 19, 2022
|
retest this please |
vaibhavparatwar
approved these changes
Aug 20, 2022
|
@Shreya-18 Please check why 3N and 5N deployment checks are failing. |
|
retest this please |
|
3N deployment is failing due to server pod timeout issue. Will test it manually and update it. |
|
Ok.. i think it is because of CORTX-33786 for which we have PR #2152 |
The validation for log device size was missing which resulted in failure of cluster bootstrap. Default size was taken from lsblk if not provided via confstore. Solution: Following motr constraints are considered: - the log device size upper and lower bounds is set to 4GB and 128MB respectively. - The size of the log device is rounded off to the nearest power of 2. Signed-off-by: Shreya Karmakar <shreya.karmakar@seagate.com>
|
Deployed successfully on 5Node setup !! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The validation for log device size was missing which resulted
in failure of cluster bootstrap. Default size
was taken from lsblk if not provided via confstore.
Solution:
Following motr constraints are considered:
128MB respectively.
power of 2.
Signed-off-by: Shreya Karmakar shreya.karmakar@seagate.com