This repository has been archived by the owner on Feb 8, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 47
CORTX-33949:CSM consul Connection handling #898
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pranali Ugale <pranali.ugale@seagate.com>
Signed-off-by: Pranali Ugale <pranali.ugale@seagate.com>
Pranali04796
requested review from
ajaysrivas,
kupranay and
pawankumarsrivastava
as code owners
August 29, 2022 17:20
Signed-off-by: Pranali Ugale <pranali.ugale@seagate.com>
Signed-off-by: Pranali Ugale <pranali.ugale@seagate.com>
Signed-off-by: Pranali Ugale <pranali.ugale@seagate.com>
Signed-off-by: Pranali Ugale <pranali.ugale@seagate.com>
Signed-off-by: Pranali Ugale <pranali.ugale@seagate.com>
pawankumarsrivastava
approved these changes
Aug 30, 2022
pawankumarsrivastava
suggested changes
Aug 30, 2022
Signed-off-by: Pranali Ugale <pranali.ugale@seagate.com>
Signed-off-by: Pranali Ugale <pranali.ugale@seagate.com>
rohitkolapkar
approved these changes
Aug 30, 2022
pawankumarsrivastava
approved these changes
Aug 30, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Problem Statement
Design
Coding
Testing
Unit and System Tests are added
Test Cases cover Happy Path, Non-Happy Path and Scalability
Testing was performed with RPM
Build details:
Deployment Details
Happy path:
Negative scenario:
Consul is not available (Login API)
Consul is not available during final retry:
Consul is available after few retries:
Get user API
Impact Analysis
Review Checklist
Documentation