Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

CORTX-33949:CSM consul Connection handling #898

Merged
merged 10 commits into from
Aug 30, 2022

Conversation

Pranali04796
Copy link
Contributor

@Pranali04796 Pranali04796 commented Aug 29, 2022

Pull Request

Problem Statement

Design

  • For Bug, Describe the fix here.
  • For Feature, Post the link for design

Coding

Checklist for Author

  • Coding conventions are followed and code is consistent

Testing

Checklist for Author

  • Unit and System Tests are added

  • Test Cases cover Happy Path, Non-Happy Path and Scalability

  • Testing was performed with RPM

  • Build details:
    image
    Deployment Details
    image
    Happy path:
    image
    image
    image
    image

  • Negative scenario:
    Consul is not available (Login API)
    image

  • Consul is not available during final retry:
    image

  • Consul is available after few retries:

  • Get user API
    image

Impact Analysis

Checklist for Author/Reviewer/GateKeeper

  • Interface change (if any) are documented
  • Side effects on other features (deployment/upgrade)
  • Dependencies on other component(s)

Review Checklist

Checklist for Author

  • JIRA number/GitHub Issue added to PR
  • PR is self reviewed
  • Jira and state/status is updated and JIRA is updated with PR link
  • Check if the description is clear and explained

Documentation

Checklist for Author

  • Changes done to WIKI / Confluence page / Quick Start Guide

Signed-off-by: Pranali Ugale <pranali.ugale@seagate.com>
Signed-off-by: Pranali Ugale <pranali.ugale@seagate.com>
Signed-off-by: Pranali Ugale <pranali.ugale@seagate.com>
Signed-off-by: Pranali Ugale <pranali.ugale@seagate.com>
Signed-off-by: Pranali Ugale <pranali.ugale@seagate.com>
Signed-off-by: Pranali Ugale <pranali.ugale@seagate.com>
Signed-off-by: Pranali Ugale <pranali.ugale@seagate.com>
csm/common/utility.py Outdated Show resolved Hide resolved
csm/common/utility.py Outdated Show resolved Hide resolved
csm/core/services/session/session_factory.py Outdated Show resolved Hide resolved
Signed-off-by: Pranali Ugale <pranali.ugale@seagate.com>
Signed-off-by: Pranali Ugale <pranali.ugale@seagate.com>
@pawankumarsrivastava pawankumarsrivastava merged commit 6572c40 into Seagate:main Aug 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants