Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

m0cp write need to create .img file first? #10

Closed
yanqingfu opened this issue Sep 13, 2020 · 12 comments
Closed

m0cp write need to create .img file first? #10

yanqingfu opened this issue Sep 13, 2020 · 12 comments
Assignees
@madhavemuri @huanghua78

Comments

@yanqingfu
Copy link
Contributor

followed https://github.com/Seagate/cortx/blob/main/doc/Cluster_Setup.md#16-perform-the-io

do we need to create .img file first?

[root@ssc-vm-1091 cortx-hare]# hctl status
Profile: 0x7000000000000001:0x22
Data pools:
0x6f00000000000001:0x23
Services:
localhost (RC)
[started] hax 0x7200000000000001:0x6 10.230.247.138@tcp:12345:1:1
[started] confd 0x7200000000000001:0x9 10.230.247.138@tcp:12345:2:1
[started] ioservice 0x7200000000000001:0xc 10.230.247.138@tcp:12345:2:2
[unknown] m0_client 0x7200000000000001:0x1c 10.230.247.138@tcp:12345:4:1
[unknown] m0_client 0x7200000000000001:0x1f 10.230.247.138@tcp:12345:4:2

[root@ssc-vm-1091 cortx-hare]# cortx/cortx-motr/motr/st/utils/m0cp -l 10.230.247.138@tcp:12345:4:1 -H 10.230.2 47.138@tcp:12345:1:1 \

 -p 0x7000000000000001:0x22 -P 0x7200000000000001:0x1c -o 12:10 \
 -s 1m -c 128 /var/misc/random.img -L 9

-bash: cortx/cortx-motr/motr/st/utils/m0cp: No such file or directory
[root@ssc-vm-1091 cortx-hare]# /var/cortx/cortx-motr/motr/st/utils/m0cp -l 10.230.247.138@tcp:12345:4:1 -H 10. 230.247.138@tcp:12345:1:1 -p 0x7000000000000001:0x22 -P 0x7200000000000001:0x1c -o 12:10 -s 1m -c 12 8 /var/misc/random.img -L 9
m0_write failed! Object id 12:10rc = -1
[root@ssc-vm-1091 cortx-hare]# /var/cortx/cortx-motr/motr/st/utils/m0cp -l 10.230.247.138@tcp:12345:4:1 -H 10. 230.247.138@tcp:12345:1:1 -p 0x7000000000000001:0x22 -P 0x7200000000000001:0x1c -o 14:10 -s 1m -c 12 8 /var/misc/random.img -L 9
m0_write failed! Object id 14:10rc = -1
@madhavemuri
Copy link
Contributor

Yes, random.img is for reference purpose only, here any source file which is to be stored needs to be used.

@yanqingfu
Copy link
Contributor Author

yanqingfu commented Sep 13, 2020 •
edited
Loading

@madhavemuri write error

[root@ssc-vm-1091 var]# cd motr
[root@ssc-vm-1091 motr]# ls
disk0.img disk2.img disk4.img disk6.img disk8.img hax m0d-0x7200000000000001:0xc m0ut
disk1.img disk3.img disk5.img disk7.img disk9.img m0d-0x7200000000000001:0x9 m0spiel.pkg.files root
[root@ssc-vm-1091 motr]# cd ..
[root@ssc-vm-1091 var]# cortx/cortx-motr/motr/st/utils/m0cp -l 10.230.247.138@tcp:12345:4:1 -H 10.230.247.138@tcp:12345:1:1 -p 0x7000000000000001:0x22 -P 0x7200000000000001:0x1c -o 14:10 -s 1m -c 128 motr/disk6.img -L 9
motr[00515]: ea80 ERROR [io_req_fop.c:208:io_bottom_half] ioo=0x1393810 from=10.230.247.138@tcp:12345:2:2 rc=-7 ti_rc=-7 @<4300000300000014:10>
motr[00515]: eab0 ERROR [io_req.c:538:ioreq_iosm_handle_executed] iro_dgmode_write() failed, rc=-7

@yanqingfu
Copy link
Contributor Author

Yes, random.img is for reference purpose only, here any source file which is to be stored needs to be used.

text file .txt also could be used?

@yanqingfu
Copy link
Contributor Author

[root@ssc-vm-1091 var]# cortx/cortx-motr/motr/st/utils/m0cp -l 10.230.247.138@tcp:12345:4:1 -H 10.230.247.138@tcp:12345:1:1 -p 0x7000000000000001:0x22 -P 0x7200000000000001:0x1c -o 17:10 -s 1m -c 128 motr/random.txt -L 9
motr[09471]: 72e0 FATAL [lib/assert.c:50:m0_panic] panic: (rc == bcount) at m0_write() (motr/st/utils/helper.c:431) [git: cortx1.0-rc1-235-g4d78776] /var/m0trace.9471
Motr panic: (rc == bcount) at m0_write() motr/st/utils/helper.c:431 (errno: 0) (last failed: none) [git: cortx1.0-rc1-235-g4d78776] pid: 9471 /var/m0trace.9471
/var/cortx/cortx-motr/motr/.libs/libmotr.so.1(m0_arch_backtrace+0x20)[0x7f16fdd972c0]
/var/cortx/cortx-motr/motr/.libs/libmotr.so.1(m0_arch_panic+0xe6)[0x7f16fdd97476]
/var/cortx/cortx-motr/motr/.libs/libmotr.so.1(+0x34d6d4)[0x7f16fdd866d4]
/var/cortx/cortx-motr/motr/st/utils/.libs/lt-m0cp[0x4026fb]
/var/cortx/cortx-motr/motr/st/utils/.libs/lt-m0cp(main+0xad)[0x401acd]
/lib64/libc.so.6(__libc_start_main+0xf5)[0x7f16fc537555]
/var/cortx/cortx-motr/motr/st/utils/.libs/lt-m0cp[0x401b92]
Aborted (core dumped)

@madhavemuri
Copy link
Contributor

-s 1m -c 128
Make sure that size of the source file ("motr/random.txt") is greater than equal to (size * count) i.e 128M (1m * 128) here

@madhavemuri
Copy link
Contributor

Also -7 errors means E2BIG error, this means special handling is needed for them.
As you have few devices in the setup, increasing them will resolve the issue.
Or I would recommend to use lower than 100 value like "-b 30 "to the command.,
-b, --blocks-per-io (default is 100)

@huanghua78
Copy link

@madhavemuri write error

[root@ssc-vm-1091 var]# cd motr
[root@ssc-vm-1091 motr]# ls
disk0.img disk2.img disk4.img disk6.img disk8.img hax m0d-0x7200000000000001:0xc m0ut
disk1.img disk3.img disk5.img disk7.img disk9.img m0d-0x7200000000000001:0x9 m0spiel.pkg.files root
[root@ssc-vm-1091 motr]# cd ..
[root@ssc-vm-1091 var]# cortx/cortx-motr/motr/st/utils/m0cp -l 10.230.247.138@tcp:12345:4:1 -H 10.230.247.138@tcp:12345:1:1 -p 0x7000000000000001:0x22 -P 0x7200000000000001:0x1c -o 14:10 -s 1m -c 128 motr/disk6.img -L 9
motr[00515]: ea80 ERROR [io_req_fop.c:208:io_bottom_half] ioo=0x1393810 from=10.230.247.138@tcp:12345:2:2 rc=-7 ti_rc=-7 @<4300000300000014:10>
motr[00515]: eab0 ERROR [io_req.c:538:ioreq_iosm_handle_executed] iro_dgmode_write() failed, rc=-7

These "disk0.img disk2.img disk4.img disk6.img disk8.img" are files to store data for the Motr services!!!
These are "devices" managed by Motr and clovis app is writing data to them.
You are reading these disks and Motr is writing to themselves!!

THIS IS ABSOLUTELY WRONG.

@madhavemuri
Copy link
Contributor

madhavemuri commented Sep 13, 2020 •
edited
Loading

@huanghua78 : Good obeservation, i missed it.
But i think in this case @yanqingfu may be using actual devices in cluster.yaml file.

@yanqingfu
Copy link
Contributor Author

yanqingfu commented Sep 13, 2020 •
edited
Loading

@madhavemuri @huanghua78 as you can see from singlenode.yaml I am using actual devices

I used command

 for i in {0..9}; do
    sudo dd if=/dev/zero of=/var/motr/disk$i.img bs=1M seek=9999 count=1
    sudo losetup /dev/loop$i /var/motr/disk$i.img
done

to create the disk*.img file

nodes:
hostname: localhost
data_iface: eth0
m0_servers:
runs_confd: true
io_disks:
data: []
io_disks:

data:

  • /dev/vde
  • /dev/vdf
  • /dev/vdg
  • /dev/vdh
    m0_clients:
    s3: 0
    other: 2
    pools:
    name: the pool
    data_units: 2
    parity_units: 1

@justinzw
Copy link
Contributor

Transferring this to the Motr repo. Let me know if there are any issues. Thank you.

@justinzw justinzw transferred this issue from Seagate/cortx Sep 18, 2020
@gauravchaudhari02 gauravchaudhari02 transferred this issue from another repository Sep 22, 2020
madhavemuri added a commit that referenced this issue Sep 22, 2020
@madhavemuri
EOS-8618 conf/rconfc: fix issues in multi confd restart
6c8865e 
Following crash occured occured in multi confd configuration
during restart/failure of a confd m0d, when initialisation is
in progress,

 #6  0x00007f99f255ad24 in m0_panic (ctx=ctx@entry=0x7f99f29758c0 <__pctx.20770>) at lib/assert.c:50
 #7  0x00007f99f24e16a4 in m0_confc_fini (confc=confc@entry=0x7f981c008650) at conf/confc.c:562
 #8  0x00007f99f24f2918 in rconfc_herd_link_fini (lnk=lnk@entry=0x7f981c008650) at conf/rconfc.c:1387
 #9  0x00007f99f24f6797 in rconfc_link_fom_fini (fom=0x7f981c009688) at conf/rconfc_link_fom.c:100
 #10 0x00007f99f252f141 in fom_exec (fom=0x7f981c009688) at fop/fom.c:771
 #11 loc_handler_thread (th=0xc138d0) at fop/fom.c:887
 #12 0x00007f99f256117e in m0_thread_trampoline (arg=arg@entry=0xc138d8) at lib/thread.c:116
 #13 0x00007f99f256b436 in uthread_trampoline (arg=0xc138d8) at lib/user_space/uthread.c:93
 #14 0x00007f99f349bea5 in start_thread () from /lib64/libpthread.so.0
 #15 0x00007f99f07a78cd in clone () from /lib64/libc.so.6

To fix link finalisation issue, fini is done through AST.
And link ast is posted at one time only by checking "rl_finalised"
flag.

Signed-off-by: Madhavrao Vemuri <madhav.vemuri@seagate.com>
@madhavemuri madhavemuri mentioned this issue Sep 22, 2020
Closed
madhavemuri added a commit that referenced this issue Oct 3, 2020
@madhavemuri
EOS-8618 conf/rconfc: fix issues in multi confd restart
1f7b6ad 
Following crash occured occured in multi confd configuration
during restart/failure of a confd m0d, when initialisation is
in progress,

 #6  0x00007f99f255ad24 in m0_panic (ctx=ctx@entry=0x7f99f29758c0 <__pctx.20770>) at lib/assert.c:50
 #7  0x00007f99f24e16a4 in m0_confc_fini (confc=confc@entry=0x7f981c008650) at conf/confc.c:562
 #8  0x00007f99f24f2918 in rconfc_herd_link_fini (lnk=lnk@entry=0x7f981c008650) at conf/rconfc.c:1387
 #9  0x00007f99f24f6797 in rconfc_link_fom_fini (fom=0x7f981c009688) at conf/rconfc_link_fom.c:100
 #10 0x00007f99f252f141 in fom_exec (fom=0x7f981c009688) at fop/fom.c:771
 #11 loc_handler_thread (th=0xc138d0) at fop/fom.c:887
 #12 0x00007f99f256117e in m0_thread_trampoline (arg=arg@entry=0xc138d8) at lib/thread.c:116
 #13 0x00007f99f256b436 in uthread_trampoline (arg=0xc138d8) at lib/user_space/uthread.c:93
 #14 0x00007f99f349bea5 in start_thread () from /lib64/libpthread.so.0
 #15 0x00007f99f07a78cd in clone () from /lib64/libc.so.6

To fix link finalisation issue, fini is done through AST.
And link ast is posted at one time only by checking "rl_finalised"
flag.

Signed-off-by: Madhavrao Vemuri <madhav.vemuri@seagate.com>
@madhavemuri madhavemuri mentioned this issue Oct 3, 2020
Merged
madhavemuri added a commit that referenced this issue Oct 5, 2020
@madhavemuri
EOS-13878 scripts: use MOTR_M0D_IOS_BESEG_SIZE for ioservice
615fc54 
Currently be seg size MOTR_M0D_IOS_BESEG_SIZE from /etc/sysconfig/motr
not being used and default value of 8GB is used due to a bug in
motr-server script, which checks for "^ios" regex in systemd unit file,
which is no longer used with hare based cluster.
The following crash is observed,

 #3  0x00007fca296780b4 in m0_panic (ctx=ctx@entry=0x7fca29a72020 <__pctx.8247>) at lib/assert.c:52
 #4  0x00007fca295bdf20 in mem_alloc (zonemask=2, size=<optimized out>, tx=0x7fc84c2266b8, btree=0x40000015f210) at be/btree.c:127
 #5  btree_save (tree=tree@entry=0x40000015f210, tx=tx@entry=0x7fc84c2266b8, op=op@entry=0x7fc92bffe460,
    key=key@entry=0x7fc92bffe6d0, val=val@entry=0x7fc92bffe6e0, anchor=anchor@entry=0x0, optype=optype@entry=BTREE_SAVE_INSERT,
    zonemask=zonemask@entry=2) at be/btree.c:1453
 #6  0x00007fca295bdfe8 in be_btree_insert (tree=tree@entry=0x40000015f210, tx=tx@entry=0x7fc84c2266b8,
    op=op@entry=0x7fc92bffe460, key=key@entry=0x7fc92bffe6d0, val=val@entry=0x7fc92bffe6e0, anchor=anchor@entry=0x0,
    zonemask=zonemask@entry=2) at be/btree.c:1907
 #7  0x00007fca295bf018 in m0_be_btree_insert (tree=tree@entry=0x40000015f210, tx=tx@entry=0x7fc84c2266b8,
    op=op@entry=0x7fc92bffe460, key=key@entry=0x7fc92bffe6d0, val=val@entry=0x7fc92bffe6e0) at be/btree.c:1938
 #8  0x00007fca295f7931 in cob_table_insert (tree=0x40000015f210, tx=tx@entry=0x7fc84c2266b8, key=key@entry=0x7fc92bffe6d0,
    val=val@entry=0x7fc92bffe6e0) at cob/cob.c:721
 #9  0x00007fca295fa5cf in m0_cob_name_add (cob=cob@entry=0x7fc9241ffc50, nskey=nskey@entry=0x7fc9241ffdc0,
    nsrec=nsrec@entry=0x7fc92bffe8e0, tx=tx@entry=0x7fc84c2266b8) at cob/cob.c:1640
 #10 0x00007fca295fa85a in m0_cob_create (cob=0x7fc9241ffc50, nskey=0x7fc9241ffdc0, nsrec=nsrec@entry=0x7fc92bffe8e0,
    fabrec=fabrec@entry=0x0, omgrec=omgrec@entry=0x0, tx=tx@entry=0x7fc84c2266b8) at cob/cob.c:1428
 #11 0x00007fca2966b097 in m0_cc_cob_setup (cc=cc@entry=0x7fc84c2265d0, cdom=<optimized out>, attr=attr@entry=0x7fc92bffec20,
    ctx=ctx@entry=0x7fc84c2266b8) at ioservice/cob_foms.c:1058
 #12 0x00007fca2966b275 in cc_cob_create (attr=0x7fc92bffec20, cc=0x7fc84c2265d0, fom=0x7fc84c2265f0) at ioservice/cob_foms.c:1016
 #13 cob_stob_create (fom=fom@entry=0x7fc84c2265f0, attr=attr@entry=0x7fc92bffec20) at ioservice/cob_foms.c:517
 #14 0x00007fca2966c40b in cob_ops_fom_tick (fom=0x7fc84c2265f0) at ioservice/cob_foms.c:767
 #15 0x00007fca2964c24b in fom_exec (fom=0x7fc84c2265f0) at fop/fom.c:785
 #16 loc_handler_thread (th=0x1b5c1e0) at fop/fom.c:925
 #17 0x00007fca2967e50e in m0_thread_trampoline (arg=arg@entry=0x1b5c1e8) at lib/thread.c:117
 #18 0x00007fca2968875d in uthread_trampoline (arg=0x1b5c1e8) at lib/user_space/uthread.c:98
 #19 0x00007fca28e36ea5 in start_thread () from /lib64/libpthread.so.0
 #20 0x00007fca27f278cd in clone () from /lib64/libc.so.6

So for LDR R1, as LVM paths are passed only for ioservices, at the
same place be seg size is applied.

Signed-off-by: Madhavrao Vemuri <madhav.vemuri@seagate.com>
@madhavemuri madhavemuri mentioned this issue Oct 5, 2020
Merged
madhavemuri added a commit that referenced this issue Oct 5, 2020
@madhavemuri
EOS-13878 scripts: use MOTR_M0D_IOS_BESEG_SIZE for ioservice (#88)
0bef5c7 
Currently be seg size MOTR_M0D_IOS_BESEG_SIZE from /etc/sysconfig/motr
not being used and default value of 8GB is used due to a bug in
motr-server script, which checks for "^ios" regex in systemd unit file,
which is no longer used with hare based cluster.
The following crash is observed,

 #3  0x00007fca296780b4 in m0_panic (ctx=ctx@entry=0x7fca29a72020 <__pctx.8247>) at lib/assert.c:52
 #4  0x00007fca295bdf20 in mem_alloc (zonemask=2, size=<optimized out>, tx=0x7fc84c2266b8, btree=0x40000015f210) at be/btree.c:127
 #5  btree_save (tree=tree@entry=0x40000015f210, tx=tx@entry=0x7fc84c2266b8, op=op@entry=0x7fc92bffe460,
    key=key@entry=0x7fc92bffe6d0, val=val@entry=0x7fc92bffe6e0, anchor=anchor@entry=0x0, optype=optype@entry=BTREE_SAVE_INSERT,
    zonemask=zonemask@entry=2) at be/btree.c:1453
 #6  0x00007fca295bdfe8 in be_btree_insert (tree=tree@entry=0x40000015f210, tx=tx@entry=0x7fc84c2266b8,
    op=op@entry=0x7fc92bffe460, key=key@entry=0x7fc92bffe6d0, val=val@entry=0x7fc92bffe6e0, anchor=anchor@entry=0x0,
    zonemask=zonemask@entry=2) at be/btree.c:1907
 #7  0x00007fca295bf018 in m0_be_btree_insert (tree=tree@entry=0x40000015f210, tx=tx@entry=0x7fc84c2266b8,
    op=op@entry=0x7fc92bffe460, key=key@entry=0x7fc92bffe6d0, val=val@entry=0x7fc92bffe6e0) at be/btree.c:1938
 #8  0x00007fca295f7931 in cob_table_insert (tree=0x40000015f210, tx=tx@entry=0x7fc84c2266b8, key=key@entry=0x7fc92bffe6d0,
    val=val@entry=0x7fc92bffe6e0) at cob/cob.c:721
 #9  0x00007fca295fa5cf in m0_cob_name_add (cob=cob@entry=0x7fc9241ffc50, nskey=nskey@entry=0x7fc9241ffdc0,
    nsrec=nsrec@entry=0x7fc92bffe8e0, tx=tx@entry=0x7fc84c2266b8) at cob/cob.c:1640
 #10 0x00007fca295fa85a in m0_cob_create (cob=0x7fc9241ffc50, nskey=0x7fc9241ffdc0, nsrec=nsrec@entry=0x7fc92bffe8e0,
    fabrec=fabrec@entry=0x0, omgrec=omgrec@entry=0x0, tx=tx@entry=0x7fc84c2266b8) at cob/cob.c:1428
 #11 0x00007fca2966b097 in m0_cc_cob_setup (cc=cc@entry=0x7fc84c2265d0, cdom=<optimized out>, attr=attr@entry=0x7fc92bffec20,
    ctx=ctx@entry=0x7fc84c2266b8) at ioservice/cob_foms.c:1058
 #12 0x00007fca2966b275 in cc_cob_create (attr=0x7fc92bffec20, cc=0x7fc84c2265d0, fom=0x7fc84c2265f0) at ioservice/cob_foms.c:1016
 #13 cob_stob_create (fom=fom@entry=0x7fc84c2265f0, attr=attr@entry=0x7fc92bffec20) at ioservice/cob_foms.c:517
 #14 0x00007fca2966c40b in cob_ops_fom_tick (fom=0x7fc84c2265f0) at ioservice/cob_foms.c:767
 #15 0x00007fca2964c24b in fom_exec (fom=0x7fc84c2265f0) at fop/fom.c:785
 #16 loc_handler_thread (th=0x1b5c1e0) at fop/fom.c:925
 #17 0x00007fca2967e50e in m0_thread_trampoline (arg=arg@entry=0x1b5c1e8) at lib/thread.c:117
 #18 0x00007fca2968875d in uthread_trampoline (arg=0x1b5c1e8) at lib/user_space/uthread.c:98
 #19 0x00007fca28e36ea5 in start_thread () from /lib64/libpthread.so.0
 #20 0x00007fca27f278cd in clone () from /lib64/libc.so.6

So for LDR R1, as LVM paths are passed only for ioservices, at the
same place be seg size is applied.

Signed-off-by: Madhavrao Vemuri <madhav.vemuri@seagate.com>
yeshpal-jain-seagate pushed a commit that referenced this issue Oct 7, 2020
@madhavemuri @yeshpal-jain-seagate
EOS-8618 conf/rconfc: fix issues in multi confd restart
e42e707 
Following crash occured occured in multi confd configuration
during restart/failure of a confd m0d, when initialisation is
in progress,

 #6  0x00007f99f255ad24 in m0_panic (ctx=ctx@entry=0x7f99f29758c0 <__pctx.20770>) at lib/assert.c:50
 #7  0x00007f99f24e16a4 in m0_confc_fini (confc=confc@entry=0x7f981c008650) at conf/confc.c:562
 #8  0x00007f99f24f2918 in rconfc_herd_link_fini (lnk=lnk@entry=0x7f981c008650) at conf/rconfc.c:1387
 #9  0x00007f99f24f6797 in rconfc_link_fom_fini (fom=0x7f981c009688) at conf/rconfc_link_fom.c:100
 #10 0x00007f99f252f141 in fom_exec (fom=0x7f981c009688) at fop/fom.c:771
 #11 loc_handler_thread (th=0xc138d0) at fop/fom.c:887
 #12 0x00007f99f256117e in m0_thread_trampoline (arg=arg@entry=0xc138d8) at lib/thread.c:116
 #13 0x00007f99f256b436 in uthread_trampoline (arg=0xc138d8) at lib/user_space/uthread.c:93
 #14 0x00007f99f349bea5 in start_thread () from /lib64/libpthread.so.0
 #15 0x00007f99f07a78cd in clone () from /lib64/libc.so.6

To fix link finalisation issue, fini is done through AST.
And link ast is posted at one time only by checking "rl_finalised"
flag.

Signed-off-by: Madhavrao Vemuri <madhav.vemuri@seagate.com>
madhavemuri added a commit that referenced this issue Oct 9, 2020
@madhavemuri
EOS 8618 : fix for rconfc herd link panic during m0d initialization (#80
c1d4cff 
)

Following crash occurred in multi confd configuration
during restart/failure of a confd m0d, when initialization is in progress,

 #6  0x00007f99f255ad24 in m0_panic (ctx=ctx@entry=0x7f99f29758c0 <__pctx.20770>) at lib/assert.c:50
 #7  0x00007f99f24e16a4 in m0_confc_fini (confc=confc@entry=0x7f981c008650) at conf/confc.c:562
 #8  0x00007f99f24f2918 in rconfc_herd_link_fini (lnk=lnk@entry=0x7f981c008650) at conf/rconfc.c:1387
 #9  0x00007f99f24f6797 in rconfc_link_fom_fini (fom=0x7f981c009688) at conf/rconfc_link_fom.c:100
 #10 0x00007f99f252f141 in fom_exec (fom=0x7f981c009688) at fop/fom.c:771
 #11 loc_handler_thread (th=0xc138d0) at fop/fom.c:887
 #12 0x00007f99f256117e in m0_thread_trampoline (arg=arg@entry=0xc138d8) at lib/thread.c:116
 #13 0x00007f99f256b436 in uthread_trampoline (arg=0xc138d8) at lib/user_space/uthread.c:93
 #14 0x00007f99f349bea5 in start_thread () from /lib64/libpthread.so.0
 #15 0x00007f99f07a78cd in clone () from /lib64/libc.so.6

To fix link finalization issue, fini is done through AST.
And link ast is posted at one time only by checking "rl_finalised" flag.
* Handle sm fini from wait for reply state
* use different AST for rconfc_cctx_fini()
* rmservice fid fetch can fail in case of confd quorum is not possible.
   To resolve this returning from initlift_resource_manager() when
   confc in not initialized.

Co-authored-by: Hua Huang <hua.huang@seagate.com>

Signed-off-by: Madhavrao Vemuri <madhav.vemuri@seagate.com>
madhavemuri added a commit that referenced this issue Oct 9, 2020
@madhavemuri
EOS 8618 : fix for rconfc herd link panic during m0d initialization (#80
5c9ba6e 
)

Following crash occurred in multi confd configuration
during restart/failure of a confd m0d, when initialization is in progress,

 #6  0x00007f99f255ad24 in m0_panic (ctx=ctx@entry=0x7f99f29758c0 <__pctx.20770>) at lib/assert.c:50
 #7  0x00007f99f24e16a4 in m0_confc_fini (confc=confc@entry=0x7f981c008650) at conf/confc.c:562
 #8  0x00007f99f24f2918 in rconfc_herd_link_fini (lnk=lnk@entry=0x7f981c008650) at conf/rconfc.c:1387
 #9  0x00007f99f24f6797 in rconfc_link_fom_fini (fom=0x7f981c009688) at conf/rconfc_link_fom.c:100
 #10 0x00007f99f252f141 in fom_exec (fom=0x7f981c009688) at fop/fom.c:771
 #11 loc_handler_thread (th=0xc138d0) at fop/fom.c:887
 #12 0x00007f99f256117e in m0_thread_trampoline (arg=arg@entry=0xc138d8) at lib/thread.c:116
 #13 0x00007f99f256b436 in uthread_trampoline (arg=0xc138d8) at lib/user_space/uthread.c:93
 #14 0x00007f99f349bea5 in start_thread () from /lib64/libpthread.so.0
 #15 0x00007f99f07a78cd in clone () from /lib64/libc.so.6

To fix link finalization issue, fini is done through AST.
And link ast is posted at one time only by checking "rl_finalised" flag.
* Handle sm fini from wait for reply state
* use different AST for rconfc_cctx_fini()
* rmservice fid fetch can fail in case of confd quorum is not possible.
   To resolve this returning from initlift_resource_manager() when
   confc in not initialized.

Co-authored-by: Hua Huang <hua.huang@seagate.com>

Signed-off-by: Madhavrao Vemuri <madhav.vemuri@seagate.com>
madhavemuri added a commit that referenced this issue Oct 9, 2020
@madhavemuri
EOS 8618 : fix for rconfc herd link panic during m0d initialization (#80
49102da 
)

Following crash occurred in multi confd configuration
during restart/failure of a confd m0d, when initialization is in progress,

 #6  0x00007f99f255ad24 in m0_panic (ctx=ctx@entry=0x7f99f29758c0 <__pctx.20770>) at lib/assert.c:50
 #7  0x00007f99f24e16a4 in m0_confc_fini (confc=confc@entry=0x7f981c008650) at conf/confc.c:562
 #8  0x00007f99f24f2918 in rconfc_herd_link_fini (lnk=lnk@entry=0x7f981c008650) at conf/rconfc.c:1387
 #9  0x00007f99f24f6797 in rconfc_link_fom_fini (fom=0x7f981c009688) at conf/rconfc_link_fom.c:100
 #10 0x00007f99f252f141 in fom_exec (fom=0x7f981c009688) at fop/fom.c:771
 #11 loc_handler_thread (th=0xc138d0) at fop/fom.c:887
 #12 0x00007f99f256117e in m0_thread_trampoline (arg=arg@entry=0xc138d8) at lib/thread.c:116
 #13 0x00007f99f256b436 in uthread_trampoline (arg=0xc138d8) at lib/user_space/uthread.c:93
 #14 0x00007f99f349bea5 in start_thread () from /lib64/libpthread.so.0
 #15 0x00007f99f07a78cd in clone () from /lib64/libc.so.6

To fix link finalization issue, fini is done through AST.
And link ast is posted at one time only by checking "rl_finalised" flag.
* Handle sm fini from wait for reply state
* use different AST for rconfc_cctx_fini()
* rmservice fid fetch can fail in case of confd quorum is not possible.
   To resolve this returning from initlift_resource_manager() when
   confc in not initialized.

Co-authored-by: Hua Huang <hua.huang@seagate.com>

Signed-off-by: Madhavrao Vemuri <madhav.vemuri@seagate.com>
@stale
Copy link

stale bot commented Oct 16, 2020

This issue/pull request has been marked as needs attention as it has been left pending without new activity for 4 days. Tagging @huanghua78 @mukundkanekar for appropriate assignment. Sorry for the delay & Thank you for contributing to CORTX. We will get back to you as soon as possible.

@huanghua78
Copy link

This issue is not seen any more.

@stale stale bot removed the needs-attention label Nov 26, 2020
@madhavemuri madhavemuri mentioned this issue Nov 18, 2021
Merged
12 tasks
madhavemuri pushed a commit that referenced this issue Nov 18, 2021
@yeshpal-jain-seagate
EOS-26214 fol: set FOL_REC_MAXSIZE to 256K to support larger FOL sizes (
ad1f2b0 
#1231)

To fix the following panic, increased the size of FOL_REC_MAXSIZE,
#3 0x00007f901fbdcd24 in m0_panic (ctx=ctx@entry=0x7f9020060320 <__pctx.10675>) at lib/assert.c:52
#4 0x00007f901fbaa1c4 in fol_record_pack_size (rec=rec@entry=0x7f8fc842a6f8) at fol/fol.c:254
#5 0x00007f901fbaa979 in m0_fol_rec_encode (rec=rec@entry=0x7f8fc842a6f8, at=at@entry=0x7f8fc842a578) at fol/fol.c:322
#6 0x00007f901fb2f6aa in m0_be_tx_fol_add (tx=tx@entry=0x7f8fc842a3e0, rec=rec@entry=0x7f8fc842a6f8) at be/tx.c:635
#7 0x00007f901fb917f5 in m0_dtx_fol_add (tx=tx@entry=0x7f8fc842a3d8) at dtm/dtm.c:171
#8 0x00007f901fbaf224 in m0_fom_fol_rec_add (fom=fom@entry=0x7f8fc842a310) at fop/fom.c:1739
#9 0x00007f901fbafd10 in fom_fol_rec_add (fom=0x7f8fc842a310) at fop/fom_generic.c:413
#10 0x00007f901fbb0112 in m0_fom_tick_generic (fom=fom@entry=0x7f8fc842a310) at fop/fom_generic.c:860
#11 0x00007f901fb3e00f in cas_fom_tick (fom0=0x7f8fc842a310) at cas/service.c:1218
#12 0x00007f901fbae61b in fom_exec (fom=0x7f8fc842a310) at fop/fom.c:791
#13 loc_handler_thread (th=0x1a0cbb0) at fop/fom.c:931

Signed-off-by: Yeshpal Jain <yeshpal.jain@seagate.com>
madhavemuri pushed a commit that referenced this issue Nov 29, 2021
@yeshpal-jain-seagate @madhavemuri
EOS-26214 fol: set FOL_REC_MAXSIZE to 256K to support larger FOL sizes (
a7b137e 
#1231)

To fix the following panic, increased the size of FOL_REC_MAXSIZE,
#3 0x00007f901fbdcd24 in m0_panic (ctx=ctx@entry=0x7f9020060320 <__pctx.10675>) at lib/assert.c:52
#4 0x00007f901fbaa1c4 in fol_record_pack_size (rec=rec@entry=0x7f8fc842a6f8) at fol/fol.c:254
#5 0x00007f901fbaa979 in m0_fol_rec_encode (rec=rec@entry=0x7f8fc842a6f8, at=at@entry=0x7f8fc842a578) at fol/fol.c:322
#6 0x00007f901fb2f6aa in m0_be_tx_fol_add (tx=tx@entry=0x7f8fc842a3e0, rec=rec@entry=0x7f8fc842a6f8) at be/tx.c:635
#7 0x00007f901fb917f5 in m0_dtx_fol_add (tx=tx@entry=0x7f8fc842a3d8) at dtm/dtm.c:171
#8 0x00007f901fbaf224 in m0_fom_fol_rec_add (fom=fom@entry=0x7f8fc842a310) at fop/fom.c:1739
#9 0x00007f901fbafd10 in fom_fol_rec_add (fom=0x7f8fc842a310) at fop/fom_generic.c:413
#10 0x00007f901fbb0112 in m0_fom_tick_generic (fom=fom@entry=0x7f8fc842a310) at fop/fom_generic.c:860
#11 0x00007f901fb3e00f in cas_fom_tick (fom0=0x7f8fc842a310) at cas/service.c:1218
#12 0x00007f901fbae61b in fom_exec (fom=0x7f8fc842a310) at fop/fom.c:791
#13 loc_handler_thread (th=0x1a0cbb0) at fop/fom.c:931

Signed-off-by: Yeshpal Jain <yeshpal.jain@seagate.com>
madhavemuri pushed a commit that referenced this issue Dec 6, 2021
@yeshpal-jain-seagate
EOS-26214 fol: set FOL_REC_MAXSIZE to 256K to support larger FOL sizes (
0d82dec 
#1231)

To fix the following panic, increased the size of FOL_REC_MAXSIZE,
#3 0x00007f901fbdcd24 in m0_panic (ctx=ctx@entry=0x7f9020060320 <__pctx.10675>) at lib/assert.c:52
#4 0x00007f901fbaa1c4 in fol_record_pack_size (rec=rec@entry=0x7f8fc842a6f8) at fol/fol.c:254
#5 0x00007f901fbaa979 in m0_fol_rec_encode (rec=rec@entry=0x7f8fc842a6f8, at=at@entry=0x7f8fc842a578) at fol/fol.c:322
#6 0x00007f901fb2f6aa in m0_be_tx_fol_add (tx=tx@entry=0x7f8fc842a3e0, rec=rec@entry=0x7f8fc842a6f8) at be/tx.c:635
#7 0x00007f901fb917f5 in m0_dtx_fol_add (tx=tx@entry=0x7f8fc842a3d8) at dtm/dtm.c:171
#8 0x00007f901fbaf224 in m0_fom_fol_rec_add (fom=fom@entry=0x7f8fc842a310) at fop/fom.c:1739
#9 0x00007f901fbafd10 in fom_fol_rec_add (fom=0x7f8fc842a310) at fop/fom_generic.c:413
#10 0x00007f901fbb0112 in m0_fom_tick_generic (fom=fom@entry=0x7f8fc842a310) at fop/fom_generic.c:860
#11 0x00007f901fb3e00f in cas_fom_tick (fom0=0x7f8fc842a310) at cas/service.c:1218
#12 0x00007f901fbae61b in fom_exec (fom=0x7f8fc842a310) at fop/fom.c:791
#13 loc_handler_thread (th=0x1a0cbb0) at fop/fom.c:931

Signed-off-by: Yeshpal Jain <yeshpal.jain@seagate.com>
madhavemuri pushed a commit that referenced this issue Dec 9, 2021
@yeshpal-jain-seagate
EOS-26214 fol: set FOL_REC_MAXSIZE to 256K to support larger FOL sizes (
db8a2e2 
#1231)

To fix the following panic, increased the size of FOL_REC_MAXSIZE,
#3 0x00007f901fbdcd24 in m0_panic (ctx=ctx@entry=0x7f9020060320 <__pctx.10675>) at lib/assert.c:52
#4 0x00007f901fbaa1c4 in fol_record_pack_size (rec=rec@entry=0x7f8fc842a6f8) at fol/fol.c:254
#5 0x00007f901fbaa979 in m0_fol_rec_encode (rec=rec@entry=0x7f8fc842a6f8, at=at@entry=0x7f8fc842a578) at fol/fol.c:322
#6 0x00007f901fb2f6aa in m0_be_tx_fol_add (tx=tx@entry=0x7f8fc842a3e0, rec=rec@entry=0x7f8fc842a6f8) at be/tx.c:635
#7 0x00007f901fb917f5 in m0_dtx_fol_add (tx=tx@entry=0x7f8fc842a3d8) at dtm/dtm.c:171
#8 0x00007f901fbaf224 in m0_fom_fol_rec_add (fom=fom@entry=0x7f8fc842a310) at fop/fom.c:1739
#9 0x00007f901fbafd10 in fom_fol_rec_add (fom=0x7f8fc842a310) at fop/fom_generic.c:413
#10 0x00007f901fbb0112 in m0_fom_tick_generic (fom=fom@entry=0x7f8fc842a310) at fop/fom_generic.c:860
#11 0x00007f901fb3e00f in cas_fom_tick (fom0=0x7f8fc842a310) at cas/service.c:1218
#12 0x00007f901fbae61b in fom_exec (fom=0x7f8fc842a310) at fop/fom.c:791
#13 loc_handler_thread (th=0x1a0cbb0) at fop/fom.c:931

Signed-off-by: Yeshpal Jain <yeshpal.jain@seagate.com>
madhavemuri pushed a commit that referenced this issue Dec 10, 2021
@yeshpal-jain-seagate
EOS-26214 fol: set FOL_REC_MAXSIZE to 256K to support larger FOL sizes (
979af7e 
#1231)

To fix the following panic, increased the size of FOL_REC_MAXSIZE,
#3 0x00007f901fbdcd24 in m0_panic (ctx=ctx@entry=0x7f9020060320 <__pctx.10675>) at lib/assert.c:52
#4 0x00007f901fbaa1c4 in fol_record_pack_size (rec=rec@entry=0x7f8fc842a6f8) at fol/fol.c:254
#5 0x00007f901fbaa979 in m0_fol_rec_encode (rec=rec@entry=0x7f8fc842a6f8, at=at@entry=0x7f8fc842a578) at fol/fol.c:322
#6 0x00007f901fb2f6aa in m0_be_tx_fol_add (tx=tx@entry=0x7f8fc842a3e0, rec=rec@entry=0x7f8fc842a6f8) at be/tx.c:635
#7 0x00007f901fb917f5 in m0_dtx_fol_add (tx=tx@entry=0x7f8fc842a3d8) at dtm/dtm.c:171
#8 0x00007f901fbaf224 in m0_fom_fol_rec_add (fom=fom@entry=0x7f8fc842a310) at fop/fom.c:1739
#9 0x00007f901fbafd10 in fom_fol_rec_add (fom=0x7f8fc842a310) at fop/fom_generic.c:413
#10 0x00007f901fbb0112 in m0_fom_tick_generic (fom=fom@entry=0x7f8fc842a310) at fop/fom_generic.c:860
#11 0x00007f901fb3e00f in cas_fom_tick (fom0=0x7f8fc842a310) at cas/service.c:1218
#12 0x00007f901fbae61b in fom_exec (fom=0x7f8fc842a310) at fop/fom.c:791
#13 loc_handler_thread (th=0x1a0cbb0) at fop/fom.c:931

Signed-off-by: Yeshpal Jain <yeshpal.jain@seagate.com>
madhavemuri pushed a commit that referenced this issue Dec 13, 2021
@yeshpal-jain-seagate
EOS-26214 fol: set FOL_REC_MAXSIZE to 256K to support larger FOL sizes (
eac3c54 
#1231)

To fix the following panic, increased the size of FOL_REC_MAXSIZE,
#3 0x00007f901fbdcd24 in m0_panic (ctx=ctx@entry=0x7f9020060320 <__pctx.10675>) at lib/assert.c:52
#4 0x00007f901fbaa1c4 in fol_record_pack_size (rec=rec@entry=0x7f8fc842a6f8) at fol/fol.c:254
#5 0x00007f901fbaa979 in m0_fol_rec_encode (rec=rec@entry=0x7f8fc842a6f8, at=at@entry=0x7f8fc842a578) at fol/fol.c:322
#6 0x00007f901fb2f6aa in m0_be_tx_fol_add (tx=tx@entry=0x7f8fc842a3e0, rec=rec@entry=0x7f8fc842a6f8) at be/tx.c:635
#7 0x00007f901fb917f5 in m0_dtx_fol_add (tx=tx@entry=0x7f8fc842a3d8) at dtm/dtm.c:171
#8 0x00007f901fbaf224 in m0_fom_fol_rec_add (fom=fom@entry=0x7f8fc842a310) at fop/fom.c:1739
#9 0x00007f901fbafd10 in fom_fol_rec_add (fom=0x7f8fc842a310) at fop/fom_generic.c:413
#10 0x00007f901fbb0112 in m0_fom_tick_generic (fom=fom@entry=0x7f8fc842a310) at fop/fom_generic.c:860
#11 0x00007f901fb3e00f in cas_fom_tick (fom0=0x7f8fc842a310) at cas/service.c:1218
#12 0x00007f901fbae61b in fom_exec (fom=0x7f8fc842a310) at fop/fom.c:791
#13 loc_handler_thread (th=0x1a0cbb0) at fop/fom.c:931

Signed-off-by: Yeshpal Jain <yeshpal.jain@seagate.com>
madhavemuri pushed a commit that referenced this issue Dec 13, 2021
@yeshpal-jain-seagate
EOS-26214 fol: set FOL_REC_MAXSIZE to 256K to support larger FOL sizes (
c79d80e 
#1231)

To fix the following panic, increased the size of FOL_REC_MAXSIZE,
#3 0x00007f901fbdcd24 in m0_panic (ctx=ctx@entry=0x7f9020060320 <__pctx.10675>) at lib/assert.c:52
#4 0x00007f901fbaa1c4 in fol_record_pack_size (rec=rec@entry=0x7f8fc842a6f8) at fol/fol.c:254
#5 0x00007f901fbaa979 in m0_fol_rec_encode (rec=rec@entry=0x7f8fc842a6f8, at=at@entry=0x7f8fc842a578) at fol/fol.c:322
#6 0x00007f901fb2f6aa in m0_be_tx_fol_add (tx=tx@entry=0x7f8fc842a3e0, rec=rec@entry=0x7f8fc842a6f8) at be/tx.c:635
#7 0x00007f901fb917f5 in m0_dtx_fol_add (tx=tx@entry=0x7f8fc842a3d8) at dtm/dtm.c:171
#8 0x00007f901fbaf224 in m0_fom_fol_rec_add (fom=fom@entry=0x7f8fc842a310) at fop/fom.c:1739
#9 0x00007f901fbafd10 in fom_fol_rec_add (fom=0x7f8fc842a310) at fop/fom_generic.c:413
#10 0x00007f901fbb0112 in m0_fom_tick_generic (fom=fom@entry=0x7f8fc842a310) at fop/fom_generic.c:860
#11 0x00007f901fb3e00f in cas_fom_tick (fom0=0x7f8fc842a310) at cas/service.c:1218
#12 0x00007f901fbae61b in fom_exec (fom=0x7f8fc842a310) at fop/fom.c:791
#13 loc_handler_thread (th=0x1a0cbb0) at fop/fom.c:931

Signed-off-by: Yeshpal Jain <yeshpal.jain@seagate.com>
madhavemuri pushed a commit that referenced this issue Dec 13, 2021
@yeshpal-jain-seagate @madhavemuri
EOS-26214 fol: set FOL_REC_MAXSIZE to 256K to support larger FOL sizes (
72d036a 
#1231)

To fix the following panic, increased the size of FOL_REC_MAXSIZE,
#3 0x00007f901fbdcd24 in m0_panic (ctx=ctx@entry=0x7f9020060320 <__pctx.10675>) at lib/assert.c:52
#4 0x00007f901fbaa1c4 in fol_record_pack_size (rec=rec@entry=0x7f8fc842a6f8) at fol/fol.c:254
#5 0x00007f901fbaa979 in m0_fol_rec_encode (rec=rec@entry=0x7f8fc842a6f8, at=at@entry=0x7f8fc842a578) at fol/fol.c:322
#6 0x00007f901fb2f6aa in m0_be_tx_fol_add (tx=tx@entry=0x7f8fc842a3e0, rec=rec@entry=0x7f8fc842a6f8) at be/tx.c:635
#7 0x00007f901fb917f5 in m0_dtx_fol_add (tx=tx@entry=0x7f8fc842a3d8) at dtm/dtm.c:171
#8 0x00007f901fbaf224 in m0_fom_fol_rec_add (fom=fom@entry=0x7f8fc842a310) at fop/fom.c:1739
#9 0x00007f901fbafd10 in fom_fol_rec_add (fom=0x7f8fc842a310) at fop/fom_generic.c:413
#10 0x00007f901fbb0112 in m0_fom_tick_generic (fom=fom@entry=0x7f8fc842a310) at fop/fom_generic.c:860
#11 0x00007f901fb3e00f in cas_fom_tick (fom0=0x7f8fc842a310) at cas/service.c:1218
#12 0x00007f901fbae61b in fom_exec (fom=0x7f8fc842a310) at fop/fom.c:791
#13 loc_handler_thread (th=0x1a0cbb0) at fop/fom.c:931

Signed-off-by: Yeshpal Jain <yeshpal.jain@seagate.com>
@nkommuri nkommuri mentioned this issue Feb 1, 2022
Merged
12 tasks
This was referenced Apr 22, 2022
Closed
Merged
andriytk added a commit to andriytk/cortx-motr that referenced this issue Apr 27, 2022
@andriytk
Fix crash of all m0d-ios processes during write i/o
79ccb98 
All m0d-ios processes may crash if some of them is crashed during write
i/o. Here is the scenario, for example:

setup: 1 node, 5 ios processes configured with 2 disks each.

1) Start write:

    m0cp -l <local-endpoint> -H <hax-endpoint> -p <profile-fid> -P <process-fid> -s 32k -c 1024 -L 2 /dev/zero -o 0x12345678:0x678900202

2) After about 5 secs (to allow m0_client_init() to finish and start the i/o)
   kill -9 <PID> one of m0d-ios processes.

Panic msg: `((cr->tc_balance[cu]) != 0) at btree_save() (be/btree.c:1393)`

Stack:

    Seagate#3  0x00007f9454ccbe37 in m0_panic (ctx=ctx@entry=0x7f94550e15a0 <__pctx.8664>) at lib/assert.c:52
    Seagate#4  0x00007f9454c0747c in btree_save (tree=tree@entry=0x40000010ed80, tx=tx@entry=0x7f94200a7f90, op=op@entry=0x7f944ca77ec0,
        val=val@entry=0x7f944ca77e70, anchor=0x0, optype=BTREE_SAVE_UPDATE, zonemask=2, key=<optimized out>, key=<optimized out>)
        at be/btree.c:339
    Seagate#5  0x00007f9454c086f7 in m0_be_btree_update (tree=tree@entry=0x40000010ed80, tx=tx@entry=0x7f94200a7f90,
        op=op@entry=0x7f944ca77ec0, key=key@entry=0x7f944ca77e60, val=val@entry=0x7f944ca77e70) at be/btree.c:1952
    Seagate#6  0x00007f9454bfd62b in btree_update_sync (val=0x7f944ca77e70, key=0x7f944ca77e60, tx=0x7f94200a7f90, tree=0x40000010ed80)
        at balloc/balloc.c:95
    Seagate#7  balloc_gi_sync (cb=cb@entry=0x40000010eb40, tx=tx@entry=0x7f94200a7f90, gi=gi@entry=0x13ff860) at balloc/balloc.c:928
    Seagate#8  0x00007f9454bfe36e in balloc_free_db_update (motr=motr@entry=0x40000010eb40, tx=tx@entry=0x7f94200a7f90,
        grp=grp@entry=0x13ff860, tgt=tgt@entry=0x7f944ca78470, alloc_flag=<optimized out>) at balloc/balloc.c:1934
    Seagate#9  0x00007f9454bff9c6 in balloc_free_internal (req=<synthetic pointer>, req=<synthetic pointer>, tx=0x7f94200a7f90,
        ctx=0x40000010eb40) at balloc/balloc.c:2716
    Seagate#10 balloc_free (ballroom=0x40000010ec68, tx=0x7f94200a7f88, ext=0x7f944ca78560) at balloc/balloc.c:2929
    Seagate#11 0x00007f9454d97681 in stob_ad_bfree (adom=<optimized out>, adom=<optimized out>, ext=0x7f944ca78530, ext=0x7f944ca78530,
        tx=0x7f94200a7f88) at stob/ad.c:1098
    Seagate#12 stob_ad_seg_free (tx=0x7f94200a7f88, adom=<optimized out>, ext=ext@entry=0x7f944ca79160, val=1594, seg=<optimized out>)
        at stob/ad.c:1647
    Seagate#13 0x00007f9454d9783d in __lambda (seg=0x7f944ca79150) at stob/ad.c:1719
    Seagate#14 0x00007f9454c10802 in m0_be_emap_paste (it=it@entry=0x7f944ca79140, tx=0x7f94200a7f90, ext=ext@entry=0x7f944ca78a90,
        val=1794, del=del@entry=0x7f944ca78b1c, cut_left=cut_left@entry=0x7f944ca78b38, cut_right=0x7f944ca78b54)
        at be/extmap.c:628
    Seagate#15 0x00007f9454d9a546 in stob_ad_write_map_ext (orig=<optimized out>, off=464, adom=0x4000001120d8) at stob/ad.c:1731
    Seagate#16 stob_ad_write_map (map=0x7f944ca78900, frags=18, wc=0x7f944ca78920, dst=0x7f944ca789b0, adom=0x4000001120d8,
        io=0x7f94340b4298) at stob/ad.c:1858
    Seagate#17 stob_ad_write_prepare (map=0x7f944ca78900, src=0x7f944ca78970, adom=0x4000001120d8, io=<optimized out>) at stob/ad.c:2006
    Seagate#18 stob_ad_io_launch_prepare (io=<optimized out>) at stob/ad.c:2052
    Seagate#19 0x00007f9454d9ca47 in m0_stob_io_prepare (io=io@entry=0x7f94340b4298, obj=obj@entry=0x7f94341170a0,
        tx=tx@entry=0x7f94200a7f88, scope=scope@entry=0x0) at stob/io.c:178
    Seagate#20 0x00007f9454d9ce92 in m0_stob_io_prepare_and_launch (io=io@entry=0x7f94340b4298, obj=0x7f94341170a0,
        tx=tx@entry=0x7f94200a7f88, scope=scope@entry=0x0) at stob/io.c:226
    Seagate#21 0x00007f9454cb702c in io_launch (fom=0x7f94200a7ec0) at ioservice/io_foms.c:1837
    Seagate#22 0x00007f9454cb47a0 in m0_io_fom_cob_rw_tick (fom=0x7f94200a7ec0) at ioservice/io_foms.c:2333
    Seagate#23 0x00007f9454c9edf1 in fom_exec (fom=0x7f94200a7ec0) at fop/fom.c:791
    Seagate#24 loc_handler_thread (th=0x11ed150) at fop/fom.c:931

RCA: the regression of BE credit calculation in
stob/ad.c:stob_ad_write_credit() code was introduced at
commit ab22d23.

Solution: rollback the change in stob/ad.c:stob_ad_write_credit()
introduced at commit ab22d23.

Signed-off-by: Andriy Tkachuk <andriy.tkachuk@seagate.com>
andriytk added a commit to andriytk/cortx-motr that referenced this issue Apr 27, 2022
@andriytk
Fix crash of all ios processes in some write i/o scenarios
4f65eff 
Panic: ((cr->tc_balance[cu]) != 0) at btree_save() (be/btree.c:1393)

Stack:

    Seagate#3  0x00007f9454ccbe37 in m0_panic (ctx=ctx@entry=0x7f94550e15a0 <__pctx.8664>) at lib/assert.c:52
    Seagate#4  0x00007f9454c0747c in btree_save (tree=tree@entry=0x40000010ed80, tx=tx@entry=0x7f94200a7f90, op=op@entry=0x7f944ca77ec0,
        val=val@entry=0x7f944ca77e70, anchor=0x0, optype=BTREE_SAVE_UPDATE, zonemask=2, key=<optimized out>, key=<optimized out>)
        at be/btree.c:339
    Seagate#5  0x00007f9454c086f7 in m0_be_btree_update (tree=tree@entry=0x40000010ed80, tx=tx@entry=0x7f94200a7f90,
        op=op@entry=0x7f944ca77ec0, key=key@entry=0x7f944ca77e60, val=val@entry=0x7f944ca77e70) at be/btree.c:1952
    Seagate#6  0x00007f9454bfd62b in btree_update_sync (val=0x7f944ca77e70, key=0x7f944ca77e60, tx=0x7f94200a7f90, tree=0x40000010ed80)
        at balloc/balloc.c:95
    Seagate#7  balloc_gi_sync (cb=cb@entry=0x40000010eb40, tx=tx@entry=0x7f94200a7f90, gi=gi@entry=0x13ff860) at balloc/balloc.c:928
    Seagate#8  0x00007f9454bfe36e in balloc_free_db_update (motr=motr@entry=0x40000010eb40, tx=tx@entry=0x7f94200a7f90,
        grp=grp@entry=0x13ff860, tgt=tgt@entry=0x7f944ca78470, alloc_flag=<optimized out>) at balloc/balloc.c:1934
    Seagate#9  0x00007f9454bff9c6 in balloc_free_internal (req=<synthetic pointer>, req=<synthetic pointer>, tx=0x7f94200a7f90,
        ctx=0x40000010eb40) at balloc/balloc.c:2716
    Seagate#10 balloc_free (ballroom=0x40000010ec68, tx=0x7f94200a7f88, ext=0x7f944ca78560) at balloc/balloc.c:2929
    Seagate#11 0x00007f9454d97681 in stob_ad_bfree (adom=<optimized out>, adom=<optimized out>, ext=0x7f944ca78530, ext=0x7f944ca78530,
        tx=0x7f94200a7f88) at stob/ad.c:1098
    Seagate#12 stob_ad_seg_free (tx=0x7f94200a7f88, adom=<optimized out>, ext=ext@entry=0x7f944ca79160, val=1594, seg=<optimized out>)
        at stob/ad.c:1647
    Seagate#13 0x00007f9454d9783d in __lambda (seg=0x7f944ca79150) at stob/ad.c:1719
    Seagate#14 0x00007f9454c10802 in m0_be_emap_paste (it=it@entry=0x7f944ca79140, tx=0x7f94200a7f90, ext=ext@entry=0x7f944ca78a90,
        val=1794, del=del@entry=0x7f944ca78b1c, cut_left=cut_left@entry=0x7f944ca78b38, cut_right=0x7f944ca78b54)
        at be/extmap.c:628
    Seagate#15 0x00007f9454d9a546 in stob_ad_write_map_ext (orig=<optimized out>, off=464, adom=0x4000001120d8) at stob/ad.c:1731
    Seagate#16 stob_ad_write_map (map=0x7f944ca78900, frags=18, wc=0x7f944ca78920, dst=0x7f944ca789b0, adom=0x4000001120d8,
        io=0x7f94340b4298) at stob/ad.c:1858
    Seagate#17 stob_ad_write_prepare (map=0x7f944ca78900, src=0x7f944ca78970, adom=0x4000001120d8, io=<optimized out>) at stob/ad.c:2006
    Seagate#18 stob_ad_io_launch_prepare (io=<optimized out>) at stob/ad.c:2052
    Seagate#19 0x00007f9454d9ca47 in m0_stob_io_prepare (io=io@entry=0x7f94340b4298, obj=obj@entry=0x7f94341170a0,
        tx=tx@entry=0x7f94200a7f88, scope=scope@entry=0x0) at stob/io.c:178
    Seagate#20 0x00007f9454d9ce92 in m0_stob_io_prepare_and_launch (io=io@entry=0x7f94340b4298, obj=0x7f94341170a0,
        tx=tx@entry=0x7f94200a7f88, scope=scope@entry=0x0) at stob/io.c:226
    Seagate#21 0x00007f9454cb702c in io_launch (fom=0x7f94200a7ec0) at ioservice/io_foms.c:1837
    Seagate#22 0x00007f9454cb47a0 in m0_io_fom_cob_rw_tick (fom=0x7f94200a7ec0) at ioservice/io_foms.c:2333
    Seagate#23 0x00007f9454c9edf1 in fom_exec (fom=0x7f94200a7ec0) at fop/fom.c:791
    Seagate#24 loc_handler_thread (th=0x11ed150) at fop/fom.c:931

Setup: 1-node, 5 ios processes configured with 2 disks each,
       4+2+0 EC data pool.

Scenario: write the same object twice like this:

    $ m0cp <motr-conn-params> -s 1m -c 40 -L 4 /dev/zero -o 0x12345678:0x678900207
    $ m0cp <motr-conn-params> -s 1m -c 40 -L 4 /dev/zero -o 0x12345678:0x678900207 -u

RCA: regression of BE credit calculation in stob_ad_write_credit()
code was introduced at commit ab22d23.

Solution: rollback the regression change.

Signed-off-by: Andriy Tkachuk <andriy.tkachuk@seagate.com>
andriytk added a commit to andriytk/cortx-motr that referenced this issue Apr 27, 2022
@andriytk
Fix crash of all ios processes in some write i/o scenarios
d3ff93e 
Panic: ((cr->tc_balance[cu]) != 0) at btree_save() (be/btree.c:1393)

Stack:

    Seagate#3  0x00007f9454ccbe37 in m0_panic (ctx=ctx@entry=0x7f94550e15a0 <__pctx.8664>) at lib/assert.c:52
    Seagate#4  0x00007f9454c0747c in btree_save (tree=tree@entry=0x40000010ed80, tx=tx@entry=0x7f94200a7f90, op=op@entry=0x7f944ca77ec0,
        val=val@entry=0x7f944ca77e70, anchor=0x0, optype=BTREE_SAVE_UPDATE, zonemask=2, key=<optimized out>, key=<optimized out>)
        at be/btree.c:339
    Seagate#5  0x00007f9454c086f7 in m0_be_btree_update (tree=tree@entry=0x40000010ed80, tx=tx@entry=0x7f94200a7f90,
        op=op@entry=0x7f944ca77ec0, key=key@entry=0x7f944ca77e60, val=val@entry=0x7f944ca77e70) at be/btree.c:1952
    Seagate#6  0x00007f9454bfd62b in btree_update_sync (val=0x7f944ca77e70, key=0x7f944ca77e60, tx=0x7f94200a7f90, tree=0x40000010ed80)
        at balloc/balloc.c:95
    Seagate#7  balloc_gi_sync (cb=cb@entry=0x40000010eb40, tx=tx@entry=0x7f94200a7f90, gi=gi@entry=0x13ff860) at balloc/balloc.c:928
    Seagate#8  0x00007f9454bfe36e in balloc_free_db_update (motr=motr@entry=0x40000010eb40, tx=tx@entry=0x7f94200a7f90,
        grp=grp@entry=0x13ff860, tgt=tgt@entry=0x7f944ca78470, alloc_flag=<optimized out>) at balloc/balloc.c:1934
    Seagate#9  0x00007f9454bff9c6 in balloc_free_internal (req=<synthetic pointer>, req=<synthetic pointer>, tx=0x7f94200a7f90,
        ctx=0x40000010eb40) at balloc/balloc.c:2716
    Seagate#10 balloc_free (ballroom=0x40000010ec68, tx=0x7f94200a7f88, ext=0x7f944ca78560) at balloc/balloc.c:2929
    Seagate#11 0x00007f9454d97681 in stob_ad_bfree (adom=<optimized out>, adom=<optimized out>, ext=0x7f944ca78530, ext=0x7f944ca78530,
        tx=0x7f94200a7f88) at stob/ad.c:1098
    Seagate#12 stob_ad_seg_free (tx=0x7f94200a7f88, adom=<optimized out>, ext=ext@entry=0x7f944ca79160, val=1594, seg=<optimized out>)
        at stob/ad.c:1647
    Seagate#13 0x00007f9454d9783d in __lambda (seg=0x7f944ca79150) at stob/ad.c:1719
    Seagate#14 0x00007f9454c10802 in m0_be_emap_paste (it=it@entry=0x7f944ca79140, tx=0x7f94200a7f90, ext=ext@entry=0x7f944ca78a90,
        val=1794, del=del@entry=0x7f944ca78b1c, cut_left=cut_left@entry=0x7f944ca78b38, cut_right=0x7f944ca78b54)
        at be/extmap.c:628
    Seagate#15 0x00007f9454d9a546 in stob_ad_write_map_ext (orig=<optimized out>, off=464, adom=0x4000001120d8) at stob/ad.c:1731
    Seagate#16 stob_ad_write_map (map=0x7f944ca78900, frags=18, wc=0x7f944ca78920, dst=0x7f944ca789b0, adom=0x4000001120d8,
        io=0x7f94340b4298) at stob/ad.c:1858
    Seagate#17 stob_ad_write_prepare (map=0x7f944ca78900, src=0x7f944ca78970, adom=0x4000001120d8, io=<optimized out>) at stob/ad.c:2006
    Seagate#18 stob_ad_io_launch_prepare (io=<optimized out>) at stob/ad.c:2052
    Seagate#19 0x00007f9454d9ca47 in m0_stob_io_prepare (io=io@entry=0x7f94340b4298, obj=obj@entry=0x7f94341170a0,
        tx=tx@entry=0x7f94200a7f88, scope=scope@entry=0x0) at stob/io.c:178
    Seagate#20 0x00007f9454d9ce92 in m0_stob_io_prepare_and_launch (io=io@entry=0x7f94340b4298, obj=0x7f94341170a0,
        tx=tx@entry=0x7f94200a7f88, scope=scope@entry=0x0) at stob/io.c:226
    Seagate#21 0x00007f9454cb702c in io_launch (fom=0x7f94200a7ec0) at ioservice/io_foms.c:1837
    Seagate#22 0x00007f9454cb47a0 in m0_io_fom_cob_rw_tick (fom=0x7f94200a7ec0) at ioservice/io_foms.c:2333
    Seagate#23 0x00007f9454c9edf1 in fom_exec (fom=0x7f94200a7ec0) at fop/fom.c:791
    Seagate#24 loc_handler_thread (th=0x11ed150) at fop/fom.c:931

Setup: 1-node, 4+2+0 EC data pool with 10 disks.
Scenario: write the same object twice like this:

    $ m0cp <motr-conn-params> -s 1m -c 40 -L 4 /dev/zero -o 0x12345678:0x678900207
    $ m0cp <motr-conn-params> -s 1m -c 40 -L 4 /dev/zero -o 0x12345678:0x678900207 -u

RCA: regression of BE credit calculation in stob_ad_write_credit()
code was introduced at commit ab22d23.

Solution: rollback the regression change.

Signed-off-by: Andriy Tkachuk <andriy.tkachuk@seagate.com>
andriytk added a commit to andriytk/cortx-motr that referenced this issue Apr 27, 2022
@andriytk @madhavemuri
Fix crash of all ios processes in some write scenarios
c2f8e32 
Panic: ((cr->tc_balance[cu]) != 0) at btree_save() (be/btree.c:1393)

Stack:

    Seagate#3  m0_panic() at lib/assert.c:52
    Seagate#4  btree_save() at be/btree.c:339
    Seagate#5  m0_be_btree_update() at be/btree.c:1952
    Seagate#6  btree_update_sync() at balloc/balloc.c:95
    Seagate#7  balloc_gi_sync() at balloc/balloc.c:928
    Seagate#8  balloc_free_db_update() at balloc/balloc.c:1934
    Seagate#9  balloc_free_internal() at balloc/balloc.c:2716
    Seagate#10 balloc_free() at balloc/balloc.c:2929
    Seagate#11 stob_ad_bfree() at stob/ad.c:1098
    Seagate#12 stob_ad_seg_free (val=1594) at stob/ad.c:1647
    Seagate#13 __lambda() at stob/ad.c:1719
    Seagate#14 m0_be_emap_paste(val=1794) at be/extmap.c:628
    Seagate#15 stob_ad_write_map_ext(off=464) at stob/ad.c:1731
    Seagate#16 stob_ad_write_map(frags=18) at stob/ad.c:1858
    Seagate#17 stob_ad_write_prepare() at stob/ad.c:2006
    Seagate#18 stob_ad_io_launch_prepare() at stob/ad.c:2052
    Seagate#19 m0_stob_io_prepare() at stob/io.c:178
    Seagate#20 m0_stob_io_prepare_and_launch() at stob/io.c:226
    Seagate#21 io_launch() at ioservice/io_foms.c:1837
    Seagate#22 m0_io_fom_cob_rw_tick() at ioservice/io_foms.c:2333
    Seagate#23 fom_exec() at fop/fom.c:791
    Seagate#24 loc_handler_thread() at fop/fom.c:931

Setup: 1 node, 4+2+0 EC data pool with 10 disks.
Scenario: write the same object twice like this:

    $ m0cp <motr-conn-params> -s 1m -c 40 -L 4 /dev/zero -o 0x12345678:0x678900207
    $ m0cp <motr-conn-params> -s 1m -c 40 -L 4 /dev/zero -o 0x12345678:0x678900207 -u

RCA: regression of BE credit calculation in stob_ad_write_credit()
code was introduced at commit ab22d23.

Solution: rollback the regression change.

Co-authored-by: Madhavrao Vemuri <madhav.vemuri@seagate.com>
Signed-off-by: Andriy Tkachuk <andriy.tkachuk@seagate.com>
andriytk added a commit to andriytk/cortx-motr that referenced this issue Apr 27, 2022
@andriytk @madhavemuri
Fix crash of all ios processes in some write scenarios
710f283 
Panic: ((cr->tc_balance[cu]) != 0) at btree_save() (be/btree.c:1393)

Stack:

    Seagate#3  m0_panic() at lib/assert.c:52
    Seagate#4  btree_save() at be/btree.c:339
    Seagate#5  m0_be_btree_update() at be/btree.c:1952
    Seagate#6  btree_update_sync() at balloc/balloc.c:95
    Seagate#7  balloc_gi_sync() at balloc/balloc.c:928
    Seagate#8  balloc_free_db_update() at balloc/balloc.c:1934
    Seagate#9  balloc_free_internal() at balloc/balloc.c:2716
    Seagate#10 balloc_free() at balloc/balloc.c:2929
    Seagate#11 stob_ad_bfree() at stob/ad.c:1098
    Seagate#12 stob_ad_seg_free (val=1594) at stob/ad.c:1647
    Seagate#13 __lambda() at stob/ad.c:1719
    Seagate#14 m0_be_emap_paste(val=1794) at be/extmap.c:628
    Seagate#15 stob_ad_write_map_ext(off=464) at stob/ad.c:1731
    Seagate#16 stob_ad_write_map(frags=18) at stob/ad.c:1858
    Seagate#17 stob_ad_write_prepare() at stob/ad.c:2006
    Seagate#18 stob_ad_io_launch_prepare() at stob/ad.c:2052
    Seagate#19 m0_stob_io_prepare() at stob/io.c:178
    Seagate#20 m0_stob_io_prepare_and_launch() at stob/io.c:226
    Seagate#21 io_launch() at ioservice/io_foms.c:1837
    Seagate#22 m0_io_fom_cob_rw_tick() at ioservice/io_foms.c:2333
    Seagate#23 fom_exec() at fop/fom.c:791
    Seagate#24 loc_handler_thread() at fop/fom.c:931

Setup: 1 node, 4+2+0 EC data pool with 10 disks.
Scenario: write the same object twice like this:

    $ m0cp <motr-conn-params> -s 1m -c 40 -L 4 /dev/zero -o 0x12345678:0x678900207
    $ m0cp <motr-conn-params> -s 1m -c 40 -L 4 /dev/zero -o 0x12345678:0x678900207 -u

RCA: regression of BE credit calculation in stob_ad_write_credit()
code was introduced at commit ab22d23.

Solution: rollback the regression change.

Co-authored-by: Madhavrao Vemuri <madhav.vemuri@seagate.com>
Signed-off-by: Andriy Tkachuk <andriy.tkachuk@seagate.com>
madhavemuri pushed a commit that referenced this issue May 4, 2022
@andriytk
motr: fix crash of all ios processes in some write scenarios (#1686)
317b5ca 
Problem: Following panic occurs if update operation is done,
Panic: ((cr->tc_balance[cu]) != 0) at btree_save() (be/btree.c:1393)

Stack:

    #3  m0_panic() at lib/assert.c:52
    #4  btree_save() at be/btree.c:339
    #5  m0_be_btree_update() at be/btree.c:1952
    #6  btree_update_sync() at balloc/balloc.c:95
    #7  balloc_gi_sync() at balloc/balloc.c:928
    #8  balloc_free_db_update() at balloc/balloc.c:1934
    #9  balloc_free_internal() at balloc/balloc.c:2716
    #10 balloc_free() at balloc/balloc.c:2929
    #11 stob_ad_bfree() at stob/ad.c:1098
    #12 stob_ad_seg_free (val=1594) at stob/ad.c:1647
    #13 __lambda() at stob/ad.c:1719
    #14 m0_be_emap_paste(val=1794) at be/extmap.c:628
    #15 stob_ad_write_map_ext(off=464) at stob/ad.c:1731
    #16 stob_ad_write_map(frags=18) at stob/ad.c:1858
    #17 stob_ad_write_prepare() at stob/ad.c:2006
    #18 stob_ad_io_launch_prepare() at stob/ad.c:2052
    #19 m0_stob_io_prepare() at stob/io.c:178
    #20 m0_stob_io_prepare_and_launch() at stob/io.c:226
    #21 io_launch() at ioservice/io_foms.c:1837
    #22 m0_io_fom_cob_rw_tick() at ioservice/io_foms.c:2333
    #23 fom_exec() at fop/fom.c:791
    #24 loc_handler_thread() at fop/fom.c:931

Setup: 1 node, 4+2+0 EC data pool with 10 disks.
Scenario: write the same object twice like this:

    $ m0cp <motr-conn-params> -s 1m -c 40 -L 4 /dev/zero -o 0x12345678:0x678900207
    $ m0cp <motr-conn-params> -s 1m -c 40 -L 4 /dev/zero -o 0x12345678:0x678900207 -u

RCA: regression of BE credit calculation in stob_ad_write_credit()
code was introduced at commit ab22d23.

Solution: rollback the regression change.

Signed-off-by: Andriy Tkachuk <andriy.tkachuk@seagate.com>
andriytk added a commit to andriytk/cortx-motr that referenced this issue May 10, 2022
@andriytk @madhavemuri
Fix crash of all ios processes in some write i/o scenarios
96b2421 
Panic: ((cr->tc_balance[cu]) != 0) at btree_save() (be/btree.c:1393)

Stack:

    Seagate#3  m0_panic() at lib/assert.c:52
    Seagate#4  btree_save() at be/btree.c:339
    Seagate#5  m0_be_btree_update() at be/btree.c:1952
    Seagate#6  btree_update_sync() at balloc/balloc.c:95
    Seagate#7  balloc_gi_sync() at balloc/balloc.c:928
    Seagate#8  balloc_free_db_update() at balloc/balloc.c:1934
    Seagate#9  balloc_free_internal() at balloc/balloc.c:2716
    Seagate#10 balloc_free() at balloc/balloc.c:2929
    Seagate#11 stob_ad_bfree() at stob/ad.c:1098
    Seagate#12 stob_ad_seg_free (val=1594) at stob/ad.c:1647
    Seagate#13 __lambda() at stob/ad.c:1719
    Seagate#14 m0_be_emap_paste(val=1794) at be/extmap.c:628
    Seagate#15 stob_ad_write_map_ext(off=464) at stob/ad.c:1731
    Seagate#16 stob_ad_write_map(frags=18) at stob/ad.c:1858
    Seagate#17 stob_ad_write_prepare() at stob/ad.c:2006
    Seagate#18 stob_ad_io_launch_prepare() at stob/ad.c:2052
    Seagate#19 m0_stob_io_prepare() at stob/io.c:178
    Seagate#20 m0_stob_io_prepare_and_launch() at stob/io.c:226
    Seagate#21 io_launch() at ioservice/io_foms.c:1837
    Seagate#22 m0_io_fom_cob_rw_tick() at ioservice/io_foms.c:2333
    Seagate#23 fom_exec() at fop/fom.c:791
    Seagate#24 loc_handler_thread() at fop/fom.c:931

Setup: 1 node, 4+2+0 EC data pool with 10 disks.
Scenario: write the same object twice like this:

    $ m0cp <motr-conn-params> -s 1m -c 40 -L 4 /dev/zero -o 0x12345678:0x678900207
    $ m0cp <motr-conn-params> -s 1m -c 40 -L 4 /dev/zero -o 0x12345678:0x678900207 -u

RCA: regression of BE credit calculation in stob_ad_write_credit()
code was introduced at commit ab22d23.

Solution: rollback the regression change.

Co-authored-by: Madhavrao Vemuri <madhav.vemuri@seagate.com>
Signed-off-by: Andriy Tkachuk <andriy.tkachuk@seagate.com>
@vidyadhar-pinglikar vidyadhar-pinglikar mentioned this issue Jun 7, 2022
Merged
12 tasks
mehjoshi pushed a commit that referenced this issue Jun 7, 2022
@vidyadhar-pinglikar
CORTX-30993 - RCA: Due to recursive calls to be_op_state_change where…
6d1944d 
… gc callback of (#1820)

Problem : In m0_be_op_fini, when bos_tlink_fini is performed then its expected that bo_set_link should not have link for link for parent's m0_be_op::bo_children.

State seen at the time of crash:
Two gft_pd_io in progress state, with corresponding two bio in sched queue; crash is hit while performing the gc callback processing for gft whhose gft_pd_io is in progress state and bio is queued behind an active io.

Panic:
2022-04-24 11:19:15,672 - motr[00107]: e2e0 FATAL [lib/assert.c:50:m0_panic] panic: (!m0_list_link_is_in(link)) at m0_list_link_fini() (lib/list.c:178) [git: 2.0.0-670-27-g0012fe90] /etc/cortx/log/motr/0696b1d9e4744c59a92cb2bdded112ac/trace/m0d-0x7200000000000001:0x2e/m0trace.107
2022-04-24 11:19:15,672 - Motr panic: (!m0_list_link_is_in(link)) at m0_list_link_fini() lib/list.c:178 (errno: 0) (last failed: none) [git: 2.0.0-670-27-g0012fe90] pid: 107 /etc/cortx/log/motr/0696b1d9e4744c59a92cb2bdded112ac/trace/m0d-0x7200000000000001:0x2e/m0trace.107
2022-04-24 11:19:15,706 - /lib64/libmotr.so.2(m0_arch_backtrace+0x33)[0x7f7514e79c83]
2022-04-24 11:19:15,706 - /lib64/libmotr.so.2(m0_arch_panic+0xe9)[0x7f7514e79e59]
2022-04-24 11:19:15,706 - /lib64/libmotr.so.2(m0_panic+0x13d)[0x7f7514e6890d]
2022-04-24 11:19:15,706 - /lib64/libmotr.so.2(+0x3895f6)[0x7f7514e6c5f6]
2022-04-24 11:19:15,706 - /lib64/libmotr.so.2(m0_be_op_fini+0x1f)[0x7f7514dae66f]
2022-04-24 11:19:15,706 - /lib64/libmotr.so.2(+0x2cb826)[0x7f7514dae826]
2022-04-24 11:19:15,707 - /lib64/libmotr.so.2(+0x2c4c5b)[0x7f7514da7c5b]
2022-04-24 11:19:15,707 - /lib64/libmotr.so.2(+0x2cb826)[0x7f7514dae826]
2022-04-24 11:19:15,707 - /lib64/libmotr.so.2(+0x2c300a)[0x7f7514da600a]
2022-04-24 11:19:15,707 - /lib64/libmotr.so.2(+0x2c3119)[0x7f7514da6119]
2022-04-24 11:19:15,707 - /lib64/libmotr.so.2(+0x386f7f)[0x7f7514e69f7f]
2022-04-24 11:19:15,707 - /lib64/libmotr.so.2(+0x386ffa)[0x7f7514e69ffa]
2022-04-24 11:19:15,707 - /lib64/libmotr.so.2(m0_chan_broadcast_lock+0x1d)[0x7f7514e6a08d]

Backtrace:
(gdb) bt
#0 0x00007f7512d8938f in raise () from /lib64/libc.so.6
#1 0x00007f7512d73dc5 in abort () from /lib64/libc.so.6
#2 0x00007f7514e79e63 in m0_arch_panic (c=c@entry=0x7f751531ade0 <__pctx.4611>, ap=ap@entry=0x7f74afffe390)
at lib/user_space/uassert.c:131
#3 0x00007f7514e6890d in m0_panic (ctx=ctx@entry=0x7f751531ade0 <__pctx.4611>) at lib/assert.c:52
#4 0x00007f7514e6c5f6 in m0_list_link_fini (link=) at lib/list.c:178
#5 0x00007f7514e70310 in m0_tlink_fini (d=d@entry=0x7f75152880a0 <bos_tl>, obj=obj@entry=0x56523e641a90) at lib/tlist.c:283
#6 0x00007f7514dae66f in bos_tlink_fini (amb=0x56523e641a90) at be/op.c:109
#7 m0_be_op_fini (op=0x56523e641a90) at be/op.c:109
#8 0x00007f7514dae826 in be_op_state_change (op=, state=state@entry=M0_BOS_DONE) at be/op.c:213
#9 0x00007f7514daea17 in m0_be_op_done (op=) at be/op.c:231
#10 0x00007f7514da7c5b in be_io_sched_cb (op=op@entry=0x56523e5f7870, param=param@entry=0x56523e5f7798) at be/io_sched.c:141
#11 0x00007f7514dae826 in be_op_state_change (op=op@entry=0x56523e5f7870, state=state@entry=M0_BOS_DONE) at be/op.c:213
#12 0x00007f7514daea17 in m0_be_op_done (op=op@entry=0x56523e5f7870) at be/op.c:231
#13 0x00007f7514da600a in be_io_finished (bio=bio@entry=0x56523e5f7798) at be/io.c:555
#14 0x00007f7514da6119 in be_io_cb (link=0x56523e61ac60) at be/io.c:587
#15 0x00007f7514e69f7f in clink_signal (clink=clink@entry=0x56523e61ac60) at lib/chan.c:135
#16 0x00007f7514e69ffa in chan_signal_nr (chan=chan@entry=0x56523e61ab58, nr=0) at lib/chan.c:154
#17 0x00007f7514e6a06c in m0_chan_broadcast (chan=chan@entry=0x56523e61ab58) at lib/chan.c:174
#18 0x00007f7514e6a08d in m0_chan_broadcast_lock (chan=chan@entry=0x56523e61ab58) at lib/chan.c:181
#19 0x00007f7514f4209a in ioq_complete (res2=, res=, qev=, ioq=0x56523e5de610)
at stob/ioq.c:587
#20 stob_ioq_thread (ioq=0x56523e5de610) at stob/ioq.c:669
#21 0x00007f7514e6f49e in m0_thread_trampoline (arg=arg@entry=0x56523e5de6e8) at lib/thread.c:117
#22 0x00007f7514e7ab11 in uthread_trampoline (arg=0x56523e5de6e8) at lib/user_space/uthread.c:98
#23 0x00007f751454915a in start_thread () from /lib64/libpthread.so.0
#24 0x00007f7512e4edd3 in clone () from /lib64/libc.so.6

RCA - Sequence of Events:

be_tx_group_format_seg_io_op_gc invoked for gft_pd_io_op of tx_group_fom_1 (last_child is false)
(gdb) p &((struct m0_be_group_format *)cb_gc_param)->gft_pd_io_op
$29 = (struct m0_be_op *) 0x56523e641a90

be_tx_group_format_seg_io_op_gc handling of gft_pd_io_op invokes m0_be_op_done for gft_tmp_op (no callbacks for gft_tmp_op) but now last_child is set true for parent as its both child (gft_tmp_op and gft_pd_io_op) op dones have been invoked

m0_be_op_done handling of gft_tmp_op invokes be_op_state_change with M0_BOS_DONE for parent(tgf_op)

During be_op_state_change processing for main parent tgf_op, m0_sm_state_set will update bo_sm state and it will unblock the tx_group_fom_1 by triggering op->bo_sm.sm_chan
This recursive callback processing happens in context of stob_ioq_thread which is initialized on M0_STOB_IOQ_NR_THREADS.
Here due to invocation of gft_tmp_op (i.e peer) child done processing from gft_pd_io_op child gc processing results in their parent early callback invocation.

Parent Callback Prcoseeing:
6. This now unblocks tx_group_fom_1 which will lead to m0_be_pd_io_put in m0_be_group_format_reset and and tx_group_fom_1 will move to TGS_OPEN.
So pd_io and tx_group_fom_1 is now ready for reuse.

Problem window:
7. problem will now occur in window if remaining gc callback processing of gft_pd_io_op
i.e.
m0_be_op_fini(&gft->gft_tmp_op);
m0_be_op_fini(op);
is being done if the pd_io and/or tx_group_fom_1 is reused with new context.

Solution:
Removal of gft_tmp_op altogether will ensure that parent callback processing never invoked ahead of its child callback processing
This way tx_group_fom will always be notifed of seg io completion only after all the relevent child calbback processing is completed and thereby
will avoid the crashes seen in the gc callback processing(be_tx_group_format_seg_io_op_gc) after m0_be_op_done(&gft->gft_tmp_op);
In proposed solution main parent op is made active at the start at the same place where gft_tmp_op was being activated in order to put this parent
into active state; there by making gft_tmp_op redundent and avoiding the out of order execution of child/parent callback executions;
RCA: Due to recursive calls to be_op_state_change where gc callback of gft_op i.e. child1 invokes done callback of gft_tmp_op i.e. child 2 which subsequently results in invocation of parent be_op_state_change. This results in group fom getting completed ahead of child op callback processing. so the subsequently crash is observed when group is reused before child callback processing is finished.

Signed-off-by: Vidyadhar Pinglikar vidyadhar.pinglikar@seagate.com
t7ko-seagate added a commit to t7ko-seagate/cortx-motr that referenced this issue Jun 10, 2022
@t7ko-seagate
Check that conf is initialized before accessing it (fix regression af…
eb5a9f4 
…ter merging domain/recovered, see Seagate#1744).

Problem: client-ut fails:

```
$ sudo ./utils/m0run -- m0ut -t client-ut
START Iteration: 1 out of 1
client-ut
  m0_client_init  motr[648725]:  6ba0  FATAL  [lib/assert.c:50:m0_panic]  panic: (confc->cc_root != ((void *)0)) at m0_confc_root_open() (conf/helpers.c:226)  [git: 2.0.0-794-16-g4bdd8326-dirty] /var/motr/m0ut/m0trace.648725.2022-06-10-03:33:52
Motr panic: (confc->cc_root != ((void *)0)) at m0_confc_root_open() conf/helpers.c:226 (errno: 0) (last failed: none) [git: 2.0.0-794-16-g4bdd8326-dirty] pid: 648725  /var/motr/m0ut/m0trace.648725.2022-06-10-03:33:52
```

```
(gdb) bt
#0  0x00007fffe9ba837f in raise () from /lib64/libc.so.6
Seagate#1  0x00007fffe9b92db5 in abort () from /lib64/libc.so.6
Seagate#2  0x00007fffebd8d2de in m0_arch_panic (c=0x7fffec2c12e0 <__pctx.14974>, ap=0x7fffffffdb18) at lib/user_space/uassert.c:131
Seagate#3  0x00007fffebd6d626 in m0_panic (ctx=0x7fffec2c12e0 <__pctx.14974>) at lib/assert.c:52
Seagate#4  0x00007fffebc91476 in m0_confc_root_open (confc=0x87f5f8, root=0x7fffffffdcc8) at conf/helpers.c:226
Seagate#5  0x00007fffebcefc2c in has_in_conf (reqh=0x87e6b8) at dtm0/domain.c:233
Seagate#6  0x00007fffebcefcdb in m0_dtm0_domain_is_recoverable (dod=0x887b88, reqh=0x87e6b8) at dtm0/domain.c:259
Seagate#7  0x00007fffed5b6baa in m0_client_init (m0c_p=0x7fffffffde20, conf=0x7ffff209be20 <default_config>, init_m0=false) at /root/cortx-motr/motr/client_init.c:1674
Seagate#8  0x00007fffed5ae4b3 in do_init (instance=0x7fffffffde20) at /root/cortx-motr/motr/ut/client.h:55
Seagate#9  0x00007fffed5b7931 in ut_test_m0_client_init () at motr/ut/client.c:255
Seagate#10 0x00007fffed6a917f in run_test (test=0x707908 <ut_suite+4488>, max_name_len=43) at ut/ut.c:390
Seagate#11 0x00007fffed6a9468 in run_suite (suite=0x706780 <ut_suite>, max_name_len=43) at ut/ut.c:459
Seagate#12 0x00007fffed6a9706 in tests_run_all (m=0x7ffff7dc0220 <ut>) at ut/ut.c:513
Seagate#13 0x00007fffed6a9764 in m0_ut_run () at ut/ut.c:539
Seagate#14 0x0000000000404b13 in main (argc=3, argv=0x7fffffffe598) at ut/m0ut.c:533
```

Solution: check that conf is initialized before accessing it.

Signed-off-by: Ivan Tishchenko <ivan.tishchenko@seagate.com>

# Please enter the commit message for your changes. Lines starting
# with '#' will be kept; you may remove them yourself if you want to.
# An empty message aborts the commit.
#
# Date:      Fri Jun 10 04:00:37 2022 -0600
#
# On branch br/it/fix-client-ut-after-domain-recovered
# Changes to be committed:
#	modified:   dtm0/domain.c
#
# Changes not staged for commit:
#	modified:   scripts/install-build-deps
#
# Untracked files:
#	run_st.sh
#
t7ko-seagate added a commit to t7ko-seagate/cortx-motr that referenced this issue Jun 10, 2022
@t7ko-seagate
Check that conf is initialized before accessing it (fix regression af…
0a49f6a 
…ter merging domain/recovered, see Seagate#1744).

Problem: client-ut fails:

```
$ sudo ./utils/m0run -- m0ut -t client-ut
START Iteration: 1 out of 1
client-ut
  m0_client_init  motr[648725]:  6ba0  FATAL  [lib/assert.c:50:m0_panic]  panic: (confc->cc_root != ((void *)0)) at m0_confc_root_open() (conf/helpers.c:226)  [git: 2.0.0-794-16-g4bdd8326-dirty] /var/motr/m0ut/m0trace.648725.2022-06-10-03:33:52
Motr panic: (confc->cc_root != ((void *)0)) at m0_confc_root_open() conf/helpers.c:226 (errno: 0) (last failed: none) [git: 2.0.0-794-16-g4bdd8326-dirty] pid: 648725  /var/motr/m0ut/m0trace.648725.2022-06-10-03:33:52
```

```
(gdb) bt
#0  0x00007fffe9ba837f in raise () from /lib64/libc.so.6
Seagate#1  0x00007fffe9b92db5 in abort () from /lib64/libc.so.6
Seagate#2  0x00007fffebd8d2de in m0_arch_panic (c=0x7fffec2c12e0 <__pctx.14974>, ap=0x7fffffffdb18) at lib/user_space/uassert.c:131
Seagate#3  0x00007fffebd6d626 in m0_panic (ctx=0x7fffec2c12e0 <__pctx.14974>) at lib/assert.c:52
Seagate#4  0x00007fffebc91476 in m0_confc_root_open (confc=0x87f5f8, root=0x7fffffffdcc8) at conf/helpers.c:226
Seagate#5  0x00007fffebcefc2c in has_in_conf (reqh=0x87e6b8) at dtm0/domain.c:233
Seagate#6  0x00007fffebcefcdb in m0_dtm0_domain_is_recoverable (dod=0x887b88, reqh=0x87e6b8) at dtm0/domain.c:259
Seagate#7  0x00007fffed5b6baa in m0_client_init (m0c_p=0x7fffffffde20, conf=0x7ffff209be20 <default_config>, init_m0=false) at /root/cortx-motr/motr/client_init.c:1674
Seagate#8  0x00007fffed5ae4b3 in do_init (instance=0x7fffffffde20) at /root/cortx-motr/motr/ut/client.h:55
Seagate#9  0x00007fffed5b7931 in ut_test_m0_client_init () at motr/ut/client.c:255
Seagate#10 0x00007fffed6a917f in run_test (test=0x707908 <ut_suite+4488>, max_name_len=43) at ut/ut.c:390
Seagate#11 0x00007fffed6a9468 in run_suite (suite=0x706780 <ut_suite>, max_name_len=43) at ut/ut.c:459
Seagate#12 0x00007fffed6a9706 in tests_run_all (m=0x7ffff7dc0220 <ut>) at ut/ut.c:513
Seagate#13 0x00007fffed6a9764 in m0_ut_run () at ut/ut.c:539
Seagate#14 0x0000000000404b13 in main (argc=3, argv=0x7fffffffe598) at ut/m0ut.c:533
```

Solution: check that conf is initialized before accessing it.

Signed-off-by: Ivan Tishchenko <ivan.tishchenko@seagate.com>
mehjoshi pushed a commit that referenced this issue Jun 14, 2022
@t7ko-seagate
Check that conf is initialized before accessing it (fix regression af…
7f35ff2 
…ter merging domain/recovered, see #1744). (#1871)

Problem: client-ut fails:

```
$ sudo ./utils/m0run -- m0ut -t client-ut
START Iteration: 1 out of 1
client-ut
  m0_client_init  motr[648725]:  6ba0  FATAL  [lib/assert.c:50:m0_panic]  panic: (confc->cc_root != ((void *)0)) at m0_confc_root_open() (conf/helpers.c:226)  [git: 2.0.0-794-16-g4bdd8326-dirty] /var/motr/m0ut/m0trace.648725.2022-06-10-03:33:52
Motr panic: (confc->cc_root != ((void *)0)) at m0_confc_root_open() conf/helpers.c:226 (errno: 0) (last failed: none) [git: 2.0.0-794-16-g4bdd8326-dirty] pid: 648725  /var/motr/m0ut/m0trace.648725.2022-06-10-03:33:52
```

```
(gdb) bt
#0  0x00007fffe9ba837f in raise () from /lib64/libc.so.6
#1  0x00007fffe9b92db5 in abort () from /lib64/libc.so.6
#2  0x00007fffebd8d2de in m0_arch_panic (c=0x7fffec2c12e0 <__pctx.14974>, ap=0x7fffffffdb18) at lib/user_space/uassert.c:131
#3  0x00007fffebd6d626 in m0_panic (ctx=0x7fffec2c12e0 <__pctx.14974>) at lib/assert.c:52
#4  0x00007fffebc91476 in m0_confc_root_open (confc=0x87f5f8, root=0x7fffffffdcc8) at conf/helpers.c:226
#5  0x00007fffebcefc2c in has_in_conf (reqh=0x87e6b8) at dtm0/domain.c:233
#6  0x00007fffebcefcdb in m0_dtm0_domain_is_recoverable (dod=0x887b88, reqh=0x87e6b8) at dtm0/domain.c:259
#7  0x00007fffed5b6baa in m0_client_init (m0c_p=0x7fffffffde20, conf=0x7ffff209be20 <default_config>, init_m0=false) at /root/cortx-motr/motr/client_init.c:1674
#8  0x00007fffed5ae4b3 in do_init (instance=0x7fffffffde20) at /root/cortx-motr/motr/ut/client.h:55
#9  0x00007fffed5b7931 in ut_test_m0_client_init () at motr/ut/client.c:255
#10 0x00007fffed6a917f in run_test (test=0x707908 <ut_suite+4488>, max_name_len=43) at ut/ut.c:390
#11 0x00007fffed6a9468 in run_suite (suite=0x706780 <ut_suite>, max_name_len=43) at ut/ut.c:459
#12 0x00007fffed6a9706 in tests_run_all (m=0x7ffff7dc0220 <ut>) at ut/ut.c:513
#13 0x00007fffed6a9764 in m0_ut_run () at ut/ut.c:539
#14 0x0000000000404b13 in main (argc=3, argv=0x7fffffffe598) at ut/m0ut.c:533
```

Solution: check that conf is initialized before accessing it.

Signed-off-by: Ivan Tishchenko <ivan.tishchenko@seagate.com>
@yatin-mahajan yatin-mahajan mentioned this issue Jul 11, 2022
Merged
12 tasks
yatin-mahajan added a commit to yatin-mahajan/cortx-motr-1 that referenced this issue Jul 12, 2022
@yatin-mahajan
CORTX-33564: Fixed panic in rpc_session_cancelled() due to session state
2b01852 
Problem:
  While session was getting canceled some other thread is trying to terminate
  that session and moves session state to M0_RPC_SESSION_TERMINATING, which
  lead to hit assert M0_POST(session->s_sm.sm_state == M0_RPC_SESSION_IDLE)
  in rpc_session_cancel().

  Seagate#5  in m0_arch_panic (c=c@entry=0x7f7276a91b40 <__pctx.14289>, ap=ap@entry=0x7f7268c05ce0) at lib/user_space/uassert.c:131
  Seagate#6  in m0_panic (ctx=ctx@entry=0x7f7276a91b40 <__pctx.14289>) at lib/assert.c:52
  Seagate#7  in m0_rpc_session_cancel (session=session@entry=0x56283c7c13d8) at rpc/session.c:863
  Seagate#8  in m0_rpc_conn_sessions_cancel (conn=conn@entry=0x56283c7c1030) at rpc/conn.c:1333
  Seagate#9  in rpc_conn__on_service_event_cb (clink=<optimized out>) at rpc/conn.c:1364
  Seagate#10 in clink_signal (clink=clink@entry=0x56283c7c12c0) at lib/chan.c:135
  Seagate#11 in chan_signal_nr (chan=chan@entry=0x56283c6a8768, nr=1) at lib/chan.c:154
  Seagate#12 in m0_chan_broadcast (chan=chan@entry=0x56283c6a8768) at lib/chan.c:174
  Seagate#13 in ha_state_accept (ignore_same_state=1, note=0x7f7268c06060, confc=0x56283816b028) at ha/note.c:18

Solution:
  It is possible that some other thread is trying to terminate the same session
  while session is getting cancelled, only the IDLE/BUSY sessions are allowed to
  cancel. Updated pre check to return from m0_rpc_cancel instead of panic/assert.
  Also replaced M0_POST()/assert with  proper debug log.

Signed-off-by: Yatin Mahajan <yatin.mahajan@seagate.com>
mehjoshi pushed a commit to mehjoshi/cortx-motr that referenced this issue Jul 18, 2022
@vidyadhar-pinglikar
CORTX-30993 - RCA: Due to recursive calls to be_op_state_change where…
9dfc351 
… gc callback of (Seagate#1820)

Problem : In m0_be_op_fini, when bos_tlink_fini is performed then its expected that bo_set_link should not have link for link for parent's m0_be_op::bo_children.

State seen at the time of crash:
Two gft_pd_io in progress state, with corresponding two bio in sched queue; crash is hit while performing the gc callback processing for gft whhose gft_pd_io is in progress state and bio is queued behind an active io.

Panic:
2022-04-24 11:19:15,672 - motr[00107]: e2e0 FATAL [lib/assert.c:50:m0_panic] panic: (!m0_list_link_is_in(link)) at m0_list_link_fini() (lib/list.c:178) [git: 2.0.0-670-27-g0012fe90] /etc/cortx/log/motr/0696b1d9e4744c59a92cb2bdded112ac/trace/m0d-0x7200000000000001:0x2e/m0trace.107
2022-04-24 11:19:15,672 - Motr panic: (!m0_list_link_is_in(link)) at m0_list_link_fini() lib/list.c:178 (errno: 0) (last failed: none) [git: 2.0.0-670-27-g0012fe90] pid: 107 /etc/cortx/log/motr/0696b1d9e4744c59a92cb2bdded112ac/trace/m0d-0x7200000000000001:0x2e/m0trace.107
2022-04-24 11:19:15,706 - /lib64/libmotr.so.2(m0_arch_backtrace+0x33)[0x7f7514e79c83]
2022-04-24 11:19:15,706 - /lib64/libmotr.so.2(m0_arch_panic+0xe9)[0x7f7514e79e59]
2022-04-24 11:19:15,706 - /lib64/libmotr.so.2(m0_panic+0x13d)[0x7f7514e6890d]
2022-04-24 11:19:15,706 - /lib64/libmotr.so.2(+0x3895f6)[0x7f7514e6c5f6]
2022-04-24 11:19:15,706 - /lib64/libmotr.so.2(m0_be_op_fini+0x1f)[0x7f7514dae66f]
2022-04-24 11:19:15,706 - /lib64/libmotr.so.2(+0x2cb826)[0x7f7514dae826]
2022-04-24 11:19:15,707 - /lib64/libmotr.so.2(+0x2c4c5b)[0x7f7514da7c5b]
2022-04-24 11:19:15,707 - /lib64/libmotr.so.2(+0x2cb826)[0x7f7514dae826]
2022-04-24 11:19:15,707 - /lib64/libmotr.so.2(+0x2c300a)[0x7f7514da600a]
2022-04-24 11:19:15,707 - /lib64/libmotr.so.2(+0x2c3119)[0x7f7514da6119]
2022-04-24 11:19:15,707 - /lib64/libmotr.so.2(+0x386f7f)[0x7f7514e69f7f]
2022-04-24 11:19:15,707 - /lib64/libmotr.so.2(+0x386ffa)[0x7f7514e69ffa]
2022-04-24 11:19:15,707 - /lib64/libmotr.so.2(m0_chan_broadcast_lock+0x1d)[0x7f7514e6a08d]

Backtrace:
(gdb) bt
#0 0x00007f7512d8938f in raise () from /lib64/libc.so.6
Seagate#1 0x00007f7512d73dc5 in abort () from /lib64/libc.so.6
Seagate#2 0x00007f7514e79e63 in m0_arch_panic (c=c@entry=0x7f751531ade0 <__pctx.4611>, ap=ap@entry=0x7f74afffe390)
at lib/user_space/uassert.c:131
Seagate#3 0x00007f7514e6890d in m0_panic (ctx=ctx@entry=0x7f751531ade0 <__pctx.4611>) at lib/assert.c:52
Seagate#4 0x00007f7514e6c5f6 in m0_list_link_fini (link=) at lib/list.c:178
Seagate#5 0x00007f7514e70310 in m0_tlink_fini (d=d@entry=0x7f75152880a0 <bos_tl>, obj=obj@entry=0x56523e641a90) at lib/tlist.c:283
Seagate#6 0x00007f7514dae66f in bos_tlink_fini (amb=0x56523e641a90) at be/op.c:109
Seagate#7 m0_be_op_fini (op=0x56523e641a90) at be/op.c:109
Seagate#8 0x00007f7514dae826 in be_op_state_change (op=, state=state@entry=M0_BOS_DONE) at be/op.c:213
Seagate#9 0x00007f7514daea17 in m0_be_op_done (op=) at be/op.c:231
Seagate#10 0x00007f7514da7c5b in be_io_sched_cb (op=op@entry=0x56523e5f7870, param=param@entry=0x56523e5f7798) at be/io_sched.c:141
Seagate#11 0x00007f7514dae826 in be_op_state_change (op=op@entry=0x56523e5f7870, state=state@entry=M0_BOS_DONE) at be/op.c:213
Seagate#12 0x00007f7514daea17 in m0_be_op_done (op=op@entry=0x56523e5f7870) at be/op.c:231
Seagate#13 0x00007f7514da600a in be_io_finished (bio=bio@entry=0x56523e5f7798) at be/io.c:555
Seagate#14 0x00007f7514da6119 in be_io_cb (link=0x56523e61ac60) at be/io.c:587
Seagate#15 0x00007f7514e69f7f in clink_signal (clink=clink@entry=0x56523e61ac60) at lib/chan.c:135
Seagate#16 0x00007f7514e69ffa in chan_signal_nr (chan=chan@entry=0x56523e61ab58, nr=0) at lib/chan.c:154
Seagate#17 0x00007f7514e6a06c in m0_chan_broadcast (chan=chan@entry=0x56523e61ab58) at lib/chan.c:174
Seagate#18 0x00007f7514e6a08d in m0_chan_broadcast_lock (chan=chan@entry=0x56523e61ab58) at lib/chan.c:181
Seagate#19 0x00007f7514f4209a in ioq_complete (res2=, res=, qev=, ioq=0x56523e5de610)
at stob/ioq.c:587
Seagate#20 stob_ioq_thread (ioq=0x56523e5de610) at stob/ioq.c:669
Seagate#21 0x00007f7514e6f49e in m0_thread_trampoline (arg=arg@entry=0x56523e5de6e8) at lib/thread.c:117
Seagate#22 0x00007f7514e7ab11 in uthread_trampoline (arg=0x56523e5de6e8) at lib/user_space/uthread.c:98
Seagate#23 0x00007f751454915a in start_thread () from /lib64/libpthread.so.0
Seagate#24 0x00007f7512e4edd3 in clone () from /lib64/libc.so.6

RCA - Sequence of Events:

be_tx_group_format_seg_io_op_gc invoked for gft_pd_io_op of tx_group_fom_1 (last_child is false)
(gdb) p &((struct m0_be_group_format *)cb_gc_param)->gft_pd_io_op
$29 = (struct m0_be_op *) 0x56523e641a90

be_tx_group_format_seg_io_op_gc handling of gft_pd_io_op invokes m0_be_op_done for gft_tmp_op (no callbacks for gft_tmp_op) but now last_child is set true for parent as its both child (gft_tmp_op and gft_pd_io_op) op dones have been invoked

m0_be_op_done handling of gft_tmp_op invokes be_op_state_change with M0_BOS_DONE for parent(tgf_op)

During be_op_state_change processing for main parent tgf_op, m0_sm_state_set will update bo_sm state and it will unblock the tx_group_fom_1 by triggering op->bo_sm.sm_chan
This recursive callback processing happens in context of stob_ioq_thread which is initialized on M0_STOB_IOQ_NR_THREADS.
Here due to invocation of gft_tmp_op (i.e peer) child done processing from gft_pd_io_op child gc processing results in their parent early callback invocation.

Parent Callback Prcoseeing:
6. This now unblocks tx_group_fom_1 which will lead to m0_be_pd_io_put in m0_be_group_format_reset and and tx_group_fom_1 will move to TGS_OPEN.
So pd_io and tx_group_fom_1 is now ready for reuse.

Problem window:
7. problem will now occur in window if remaining gc callback processing of gft_pd_io_op
i.e.
m0_be_op_fini(&gft->gft_tmp_op);
m0_be_op_fini(op);
is being done if the pd_io and/or tx_group_fom_1 is reused with new context.

Solution:
Removal of gft_tmp_op altogether will ensure that parent callback processing never invoked ahead of its child callback processing
This way tx_group_fom will always be notifed of seg io completion only after all the relevent child calbback processing is completed and thereby
will avoid the crashes seen in the gc callback processing(be_tx_group_format_seg_io_op_gc) after m0_be_op_done(&gft->gft_tmp_op);
In proposed solution main parent op is made active at the start at the same place where gft_tmp_op was being activated in order to put this parent
into active state; there by making gft_tmp_op redundent and avoiding the out of order execution of child/parent callback executions;
RCA: Due to recursive calls to be_op_state_change where gc callback of gft_op i.e. child1 invokes done callback of gft_tmp_op i.e. child 2 which subsequently results in invocation of parent be_op_state_change. This results in group fom getting completed ahead of child op callback processing. so the subsequently crash is observed when group is reused before child callback processing is finished.

Signed-off-by: Vidyadhar Pinglikar vidyadhar.pinglikar@seagate.com
mehjoshi pushed a commit to mehjoshi/cortx-motr that referenced this issue Jul 18, 2022
@t7ko-seagate
Check that conf is initialized before accessing it (fix regression af…
5a99c8d 
…ter merging domain/recovered, see Seagate#1744). (Seagate#1871)

Problem: client-ut fails:

```
$ sudo ./utils/m0run -- m0ut -t client-ut
START Iteration: 1 out of 1
client-ut
  m0_client_init  motr[648725]:  6ba0  FATAL  [lib/assert.c:50:m0_panic]  panic: (confc->cc_root != ((void *)0)) at m0_confc_root_open() (conf/helpers.c:226)  [git: 2.0.0-794-16-g4bdd8326-dirty] /var/motr/m0ut/m0trace.648725.2022-06-10-03:33:52
Motr panic: (confc->cc_root != ((void *)0)) at m0_confc_root_open() conf/helpers.c:226 (errno: 0) (last failed: none) [git: 2.0.0-794-16-g4bdd8326-dirty] pid: 648725  /var/motr/m0ut/m0trace.648725.2022-06-10-03:33:52
```

```
(gdb) bt
#0  0x00007fffe9ba837f in raise () from /lib64/libc.so.6
Seagate#1  0x00007fffe9b92db5 in abort () from /lib64/libc.so.6
Seagate#2  0x00007fffebd8d2de in m0_arch_panic (c=0x7fffec2c12e0 <__pctx.14974>, ap=0x7fffffffdb18) at lib/user_space/uassert.c:131
Seagate#3  0x00007fffebd6d626 in m0_panic (ctx=0x7fffec2c12e0 <__pctx.14974>) at lib/assert.c:52
Seagate#4  0x00007fffebc91476 in m0_confc_root_open (confc=0x87f5f8, root=0x7fffffffdcc8) at conf/helpers.c:226
Seagate#5  0x00007fffebcefc2c in has_in_conf (reqh=0x87e6b8) at dtm0/domain.c:233
Seagate#6  0x00007fffebcefcdb in m0_dtm0_domain_is_recoverable (dod=0x887b88, reqh=0x87e6b8) at dtm0/domain.c:259
Seagate#7  0x00007fffed5b6baa in m0_client_init (m0c_p=0x7fffffffde20, conf=0x7ffff209be20 <default_config>, init_m0=false) at /root/cortx-motr/motr/client_init.c:1674
Seagate#8  0x00007fffed5ae4b3 in do_init (instance=0x7fffffffde20) at /root/cortx-motr/motr/ut/client.h:55
Seagate#9  0x00007fffed5b7931 in ut_test_m0_client_init () at motr/ut/client.c:255
Seagate#10 0x00007fffed6a917f in run_test (test=0x707908 <ut_suite+4488>, max_name_len=43) at ut/ut.c:390
Seagate#11 0x00007fffed6a9468 in run_suite (suite=0x706780 <ut_suite>, max_name_len=43) at ut/ut.c:459
Seagate#12 0x00007fffed6a9706 in tests_run_all (m=0x7ffff7dc0220 <ut>) at ut/ut.c:513
Seagate#13 0x00007fffed6a9764 in m0_ut_run () at ut/ut.c:539
Seagate#14 0x0000000000404b13 in main (argc=3, argv=0x7fffffffe598) at ut/m0ut.c:533
```

Solution: check that conf is initialized before accessing it.

Signed-off-by: Ivan Tishchenko <ivan.tishchenko@seagate.com>
rkothiya pushed a commit that referenced this issue Jul 18, 2022
@yatin-mahajan
CORTX-33564: Fixed panic in rpc_session_cancelled() due to session st…
773eea4 
…ate (#1969)

Problem:
  While session was getting canceled some other thread is trying to terminate
  that session and moves session state to M0_RPC_SESSION_TERMINATING, which
  lead to hit assert M0_POST(session->s_sm.sm_state == M0_RPC_SESSION_IDLE)
  in rpc_session_cancel().

  #5  in m0_arch_panic (c=c@entry=0x7f7276a91b40 <__pctx.14289>, ap=ap@entry=0x7f7268c05ce0) at lib/user_space/uassert.c:131
  #6  in m0_panic (ctx=ctx@entry=0x7f7276a91b40 <__pctx.14289>) at lib/assert.c:52
  #7  in m0_rpc_session_cancel (session=session@entry=0x56283c7c13d8) at rpc/session.c:863
  #8  in m0_rpc_conn_sessions_cancel (conn=conn@entry=0x56283c7c1030) at rpc/conn.c:1333
  #9  in rpc_conn__on_service_event_cb (clink=<optimized out>) at rpc/conn.c:1364
  #10 in clink_signal (clink=clink@entry=0x56283c7c12c0) at lib/chan.c:135
  #11 in chan_signal_nr (chan=chan@entry=0x56283c6a8768, nr=1) at lib/chan.c:154
  #12 in m0_chan_broadcast (chan=chan@entry=0x56283c6a8768) at lib/chan.c:174
  #13 in ha_state_accept (ignore_same_state=1, note=0x7f7268c06060, confc=0x56283816b028) at ha/note.c:18

Solution:
  It is possible that some other thread is trying to terminate the same session
  while session is getting cancelled, only the IDLE/BUSY sessions are allowed to
  cancel. Updated pre check to return from m0_rpc_cancel instead of panic/assert.
  Also replaced M0_POST()/assert with  proper debug log.

Signed-off-by: Yatin Mahajan <yatin.mahajan@seagate.com>
@cortx-admin cortx-admin mentioned this issue Aug 2, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@madhavemuri madhavemuri

@huanghua78 huanghua78

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@justinzw @madhavemuri @huanghua78 @yanqingfu