[Codacy code cleanup] occurrence: 1688 pattern: Double quote to prevent globbing and word splitting #1606

rkothiya · 2022-04-12T08:26:43Z

Problem

We see 1688 occurrence of pattern, "Double quote to prevent globbing and word splitting".

Expected behavior

We should not be getting these warnings

How to reproduce

Fire the below command to list all the warnings :

# shellcheck -x <file name>

Deployment information

Install the shellcheck package. For example to install it on Fedora/RHEL/centos you can fire :

# yum -y install ShellCheck

Additional information

Following files contains this warnings

./addb2/st/addb2dump-plugin.sh
./cas/st/ctgdump_tesh.sh
./console/st/console-st.sh
./dix/cm/st/m0t1fs_dix_repair.sh
./dix/cm/st/m0t1fs_dix_repair_quiesce.sh
./fdmi/plugins/fdmi_plugin_st.sh
./fdmi/st/echo/echo_plugin_start.sh
./fdmi/st/fdmi_test.sh
./m0t1fs/linux_kernel/st/m0t1fs_cc_io_with_sns_repair.sh
./m0t1fs/linux_kernel/st/m0t1fs_client.sh
./m0t1fs/linux_kernel/st/m0t1fs_client_inc.sh
./m0t1fs/linux_kernel/st/m0t1fs_common_inc.sh
./m0t1fs/linux_kernel/st/m0t1fs_dgmode_io.sh
./m0t1fs/linux_kernel/st/m0t1fs_failure_after_sns_repair_quiesce.sh
./m0t1fs/linux_kernel/st/m0t1fs_fsync_test.sh
./m0t1fs/linux_kernel/st/m0t1fs_fwait_test.sh
./m0t1fs/linux_kernel/st/m0t1fs_multi_clients.sh
./m0t1fs/linux_kernel/st/m0t1fs_pool_version_assignment.sh
./m0t1fs/linux_kernel/st/m0t1fs_poolmach.sh
./m0t1fs/linux_kernel/st/m0t1fs_rconfc_fail_test.sh
./m0t1fs/linux_kernel/st/m0t1fs_restart_motr_service.sh
./m0t1fs/linux_kernel/st/m0t1fs_rlock_revoke.sh
./m0t1fs/linux_kernel/st/m0t1fs_rpc_cancel_test.sh
./m0t1fs/linux_kernel/st/m0t1fs_server.sh
./m0t1fs/linux_kernel/st/m0t1fs_server_inc.sh
./m0t1fs/linux_kernel/st/m0t1fs_sns_common_inc.sh
./m0t1fs/linux_kernel/st/m0t1fs_sns_repair_1f.sh
./m0t1fs/linux_kernel/st/m0t1fs_sns_repair_1k_1f.sh
./m0t1fs/linux_kernel/st/m0t1fs_sns_repair_1n_1f.sh
./m0t1fs/linux_kernel/st/m0t1fs_sns_repair_abort.sh
./m0t1fs/linux_kernel/st/m0t1fs_sns_repair_abort_quiesce.sh
./m0t1fs/linux_kernel/st/m0t1fs_sns_repair_ios_fail.sh
./m0t1fs/linux_kernel/st/m0t1fs_sns_repair_mf.sh
./m0t1fs/linux_kernel/st/m0t1fs_sns_repair_quiesce.sh
./m0t1fs/linux_kernel/st/m0t1fs_sns_repair_shutdown.sh
./m0t1fs/linux_kernel/st/m0t1fs_spare_space_reserve.sh
./m0t1fs/linux_kernel/st/m0t1fs_test.sh
./motr/st/utils/ha_msg_send.sh
./motr/st/utils/m0crate_iem_freespace_st.sh
./motr/st/utils/m0crate_st.sh
./motr/st/utils/m0kv_start.sh
./motr/st/utils/motr_client_st.sh
./motr/st/utils/motr_cmd.sh
./motr/st/utils/motr_conf_update_st.sh
./motr/st/utils/motr_device_util.sh
./motr/st/utils/motr_dgmode_io_st.sh
./motr/st/utils/motr_fs.sh
./motr/st/utils/motr_local_conf.sh
./motr/st/utils/motr_raid0_st.sh
./motr/st/utils/motr_remote_conf.sh
./motr/st/utils/motr_rm_lock_cc_io.sh
./motr/st/utils/motr_rmw_st.sh
./motr/st/utils/motr_rpc_cancel_test.sh
./motr/st/utils/motr_services.sh
./motr/st/utils/motr_sns_common.sh
./motr/st/utils/motr_sns_repair_N_1.sh
./motr/st/utils/motr_sns_repair_st.sh
./motr/st/utils/motr_st_inc.sh
./motr/st/utils/motr_sync_replication_st.sh
./motr/st/utils/motr_sys_test.sh
./motr/st/utils/motr_utils_st.sh
./motr/st/utils/sns_failure_after_repair_quiesce.sh
./motr/st/utils/sns_repair_common_inc.sh
./motr/st/utils/sns_repair_motr_1f.sh
./motr/st/utils/sns_repair_motr_1k_1f.sh
./motr/st/utils/sns_repair_motr_1n_1f.sh
./motr/st/utils/sns_repair_motr_abort.sh
./motr/st/utils/sns_repair_motr_abort_quiesce.sh
./motr/st/utils/sns_repair_motr_ios_fail.sh
./motr/st/utils/sns_repair_motr_mf.sh
./motr/st/utils/sns_repair_motr_quiesce.sh
./motr/st/utils/sns_repair_motr_shutdown.sh
./motr/st/utils/spiel_sns_motr_repair.sh
./motr/st/utils/spiel_sns_motr_repair_quiesce.sh
./net/lnet/st/linux_kernel/m0lnetping.sh
./net/test/demo/demo-list-nids.sh
./net/test/demo/demo-test-run.sh
./net/test/demo/demo.sh
./net/test/st/run-1x1.sh
./net/test/st/st-bulk.sh
./net/test/st/st-ping.sh
./net/test/test.sh
./net/test/demo/test.sh
./rpc/it/linux_kernel/rpcload.sh
./rpc/ub/plot.sh
./scripts/addb-py/chronometry/fom_req.sh
./scripts/addb-py/chronometry/restart_ios.sh
./scripts/addb-py/chronometry/s3_build_fix/rebuildall.sh
./scripts/build-prep-1node-cortx-mgw.sh
./scripts/build-prep-1node.sh
./scripts/demo/2015-10-dev2.sh
./scripts/install/opt/seagate/cortx/motr/common/cortx_util_funcs.sh
./scripts/install/opt/seagate/cortx/motr/common/m0_sns_utils_common.sh
./scripts/install/opt/seagate/cortx/motr/libexec/m0addb_logrotate.sh
./scripts/install/opt/seagate/cortx/motr/libexec/m0trace_logrotate.sh
./scripts/install/opt/seagate/cortx/motr/libexec/motr_cfg.sh
./scripts/install/opt/seagate/cortx/motr/libexec/motr_data_recovery.sh
./scripts/install/opt/seagate/cortx/motr/sanity/cortx_lnet_sanity.sh
./scripts/install/opt/seagate/cortx/motr/sanity/cortx_srvc_sanity.sh
./scripts/install/opt/seagate/cortx/motr/sanity/motr_sanity.sh
./scripts/provisioning/vmhost/create-cluster.sh
./scripts/provisioning/vmhost/destroy-cluster.sh
./scripts/provisioning/vmhost/gci-compile-install-hare.sh
./scripts/provisioning/vmhost/gci-create-cluster.sh
./scripts/provisioning/vmhost/prepare-host.sh
./scripts/provisioning/vmhost/super-cleanup.sh
./scripts/systemtap/kem/kem_run.sh
./scripts/systemtap/stp-runner.sh
./sns/cm/st/repair_test.sh
./spiel/st/m0t1fs_spiel_dix_common_inc.sh
./spiel/st/m0t1fs_spiel_dix_repair.sh
./spiel/st/m0t1fs_spiel_dix_repair_quiesce.sh
./spiel/st/m0t1fs_spiel_sns_common_inc.sh
./spiel/st/m0t1fs_spiel_sns_repair.sh
./spiel/st/m0t1fs_spiel_sns_repair_quiesce.sh
./spiel/st/m0t1fs_spiel_st.sh
./spiel/st/spiel_multiple_confd.sh
./st/m0d-device-detach-test.sh
./st/m0d-fsync-test.sh
./st/m0d-signal-test.sh
./st/m0mt-singlenode.sh
./st/m0t1fs-buffsize-layout-change-test.sh
./st/sanity.sh
./st/stob_domain_recreate_on_corruption.sh

The text was updated successfully, but these errors were encountered:

cortx-admin · 2022-04-12T08:27:58Z

For the convenience of the Seagate development team, this issue has been mirrored in a private Seagate Jira Server: https://jts.seagate.com/browse/CORTX-30751. Note that community members will not be able to access that Jira server but that is not a problem since all activity in that Jira mirror will be copied into this GitHub issue.

rkothiya · 2022-04-13T06:46:16Z

The below pull request addresses many warnings but not all. Since the number of occurrence of these warnings are huge I will resolve these in multiple patches which should make the review easier.
#1621

cortx-admin · 2022-04-13T07:39:59Z

The below pull request addresses many warnings but not all. Since the number of occurrence of these warnings are huge I will resolve these in multiple patches which should make the review easier.
[https://github.com//pull/1621]

cortx-admin · 2022-04-13T07:40:00Z

I have fired the below job to test this patch :
[https://eos-jenkins.colo.seagate.com/job/Cortx-PR-Build/job/Motr/1135/]

cortx-admin · 2022-04-14T11:48:56Z

Screen shot of the test results have been attached to this ticket.

The below 3 tests failed :
00userspace-tests
52motr-singlenode-sanity
44motr-rm-lock-cc-io <<<<<<<<<<<<< Only failure which is suspected due to proposed patch.

I have attached the logs of all the 3 failures to this ticket for details.

This patch fixes some of the codacy warnings. Warning fixed: "Double quote to prevent globing and words splitting." Signed-off-by: alfhad <fahadshah2411@gmail.com> Signed-off-by: Rinku Kothiya <rinku.kothiya@seagate.com>

This patch fixes some of the codacy warnings. warning fixed : "Double quote to prevent globing and words splitting". Signed-off-by: Rinku Kothiya <rinku.kothiya@seagate.com>

cortx-admin · 2022-04-18T09:42:30Z

Updated the pull request and fired the test again :
[https://eos-jenkins.colo.seagate.com/job/Cortx-PR-Build/job/Motr/1137/]

cortx-admin · 2022-04-19T07:41:36Z

This time also we had 44motr-rm-lock-cc-io failed.

Failure not related to the patch :
{code:java}
motr[00000]: 6fa0 ERROR [st/utils/helper.c:178:client_init] <! rc=-22
config parameters not initialized.
Client init failed: rc=-22
pver is : <0:0>
motr[00000]: 5dc0 ERROR [st/utils/helper.c:178:client_init] <! rc=-22
config parameters not initialized.
init failed! rc = -22
81.82user 10.73system 3:10.88elapsed 48%CPU (0avgtext+0avgdata 555448maxresident)k
2096inputs+2782792outputs (42major+976525minor)pagefaults 0swaps{code}
Attaching the error log with the run number :
Run-1137-44motr-rm-lock-cc-io.stderr.log

Previous failure was related to the patch :
{code:java}
----- run_st 44motr-rm-lock-cc-io -----
<< 44motr-rm-lock-cc-io >>
/root/motr/motr_test_github_workdir/workdir/src/motr/st/utils/../../../m0t1fs/linux_kernel/st/m0t1fs_client_inc.sh: line 749: unexpected EOF while looking for matching `''
/root/motr/motr_test_github_workdir/workdir/src/motr/st/utils/../../../m0t1fs/linux_kernel/st/m0t1fs_client_inc.sh: line 915: syntax error: unexpected end of file
{code}

This patch fixes some of the codacy warnings. Warning fixed: "Double quote to prevent globing and words splitting." Signed-off-by: alfhad <fahadshah2411@gmail.com> Signed-off-by: Rinku Kothiya <rinku.kothiya@seagate.com>

stale · 2022-04-23T13:38:31Z

This issue/pull request has been marked as needs attention as it has been left pending without new activity for 4 days. Tagging @nkommuri @mehjoshi @huanghua78 for appropriate assignment. Sorry for the delay & Thank you for contributing to CORTX. We will get back to you as soon as possible.

This patch fixes some of the codacy warnings. Warning fixed: "Double quote to prevent globing and words splitting." Signed-off-by: alfhad <fahadshah2411@gmail.com> Signed-off-by: Rinku Kothiya <rinku.kothiya@seagate.com>

This patch fixes some of the codacy warnings. warning fixed : "Double quote to prevent globing and words splitting". Signed-off-by: Rinku Kothiya <rinku.kothiya@seagate.com>

rkothiya · 2022-04-25T09:06:37Z

Another pull request is :
#1644

cortx-admin · 2022-04-25T09:14:03Z

For the second pull request i.e. ([https://github.com//pull/1644]) I have fired the below test :
[https://eos-jenkins.colo.seagate.com/job/Cortx-PR-Build/job/Motr/1142/]

rkothiya · 2022-04-26T05:53:48Z

Test results :

rkothiya · 2022-04-26T05:54:40Z

I see there were 15 failures, but it does not seem related to this patch. Another pair of eyes on the test results would be preferred to confirm the same.

cortx-admin · 2022-04-26T06:19:42Z

!image-2022-04-26-11-20-38-190.png!

This patch fixes some of the codacy warnings. Warning fixed: "Double quote to prevent globing and words splitting." Signed-off-by: alfhad <fahadshah2411@gmail.com> Signed-off-by: Rinku Kothiya <rinku.kothiya@seagate.com>

This patch fixes some of the codacy warnings. warning fixed : "Double quote to prevent globing and words splitting". Signed-off-by: Rinku Kothiya <rinku.kothiya@seagate.com>

This patch fixes some of the codacy warnings. warning fixed : "Double quote to prevent globing and words splitting". Signed-off-by: alfhad <fahadshah2411@gmail.com>

This patch fixes some of the codacy warnings. warning fixed : "Double quote to prevent globing and words splitting". Signed-off-by: Rinku Kothiya <rinku.kothiya@seagate.com> Signed-off-by: alfhad <fahadshah2411@gmail.com>

stale · 2022-09-09T01:00:51Z

This issue/pull request has been marked as needs attention as it has been left pending without new activity for 4 days. Tagging @nkommuri @mehjoshi @huanghua78 for appropriate assignment. Sorry for the delay & Thank you for contributing to CORTX. We will get back to you as soon as possible.

This patch fixes some of the codacy warnings. warning fixed : "Double quote to prevent globing and words splitting". Signed-off-by: Rinku Kothiya <rinku.kothiya@seagate.com> Signed-off-by: alfhad <fahadshah2411@gmail.com>

This patch fixes some of the codacy warnings. warning fixed : "Double quote to prevent globing and words splitting". Signed-off-by: alfhad <fahadshah2411@gmail.com>

cortx-admin · 2022-09-11T05:45:33Z

{panel:bgColor=#c1c7d0}h2. motr - main branch build pipeline SUCCESS
h3. Build Info:

Author: fahadshah2411
Component Build : 5358
Release Build : 6029

h3. Artifact Location :
http://cortx-storage.colo.seagate.com/releases/cortx/github/main/rockylinux-8.4/6029

h3. Image Location :

cortx-docker.colo.seagate.com/seagate/cortx-all:2.0.0-6029
cortx-docker.colo.seagate.com/seagate/cortx-rgw:2.0.0-6029
cortx-docker.colo.seagate.com/seagate/cortx-data:2.0.0-6029
cortx-docker.colo.seagate.com/seagate/cortx-control:2.0.0-6029
{panel}

This patch fixes some of the codacy warnings. warning fixed : "Double quote to prevent globing and words splitting". Signed-off-by: Rinku Kothiya <rinku.kothiya@seagate.com> Signed-off-by: alfhad <fahadshah2411@gmail.com>

cortx-admin · 2022-09-12T10:45:37Z

{panel:bgColor=#c1c7d0}h2. motr - main branch build pipeline SUCCESS
h3. Build Info:

Author: fahadshah2411
Component Build : 5360
Release Build : 6033

h3. Artifact Location :
http://cortx-storage.colo.seagate.com/releases/cortx/github/main/rockylinux-8.4/6033

h3. Image Location :

cortx-docker.colo.seagate.com/seagate/cortx-all:2.0.0-6033
cortx-docker.colo.seagate.com/seagate/cortx-rgw:2.0.0-6033
cortx-docker.colo.seagate.com/seagate/cortx-data:2.0.0-6033
cortx-docker.colo.seagate.com/seagate/cortx-control:2.0.0-6033
{panel}

This patch fixes some of the codacy warnings. warning fixed : "Double quote to prevent globing and words splitting". Signed-off-by: Rinku Kothiya <rinku.kothiya@seagate.com> Signed-off-by: alfhad <fahadshah2411@gmail.com>

cortx-admin · 2022-09-13T09:29:38Z

{panel:bgColor=#c1c7d0}h2. motr - main branch build pipeline SUCCESS
h3. Build Info:

Author: fahadshah2411
Component Build : 5363
Release Build : 6045

h3. Artifact Location :
http://cortx-storage.colo.seagate.com/releases/cortx/github/main/rockylinux-8.4/6045

h3. Image Location :

null
cortx-docker.colo.seagate.com/seagate/cortx-rgw:2.0.0-6045
cortx-docker.colo.seagate.com/seagate/cortx-data:2.0.0-6045
cortx-docker.colo.seagate.com/seagate/cortx-control:2.0.0-6045
{panel}

This patch fixes some of the codacy warnings. warning fixed : "Double quote to prevent globing and words splitting". Signed-off-by: Rinku Kothiya <rinku.kothiya@seagate.com> Co-authored-by: Pradeep Kumbhre pradeep.kumbhre@seagate.com

stale · 2022-09-20T18:21:17Z

This issue/pull request has been marked as needs attention as it has been left pending without new activity for 4 days. Tagging @nkommuri @mehjoshi @huanghua78 for appropriate assignment. Sorry for the delay & Thank you for contributing to CORTX. We will get back to you as soon as possible.

shailesh-vaidya · 2024-02-08T17:12:45Z

Closing as an obsolete

rkothiya added the bug Something isn't working label Apr 12, 2022

rkothiya self-assigned this Apr 12, 2022

rkothiya added the codacy label Apr 12, 2022

rkothiya changed the title ~~[Codacy code cleanup] occurrence: 1688 pattern: Double quote to prevent globing and words splitting~~ [Codacy code cleanup] occurrence: 1688 pattern: Double quote to prevent globbing and word splitting Apr 15, 2022

rkothiya removed the bug Something isn't working label Apr 17, 2022

stale bot added the needs-attention label Apr 23, 2022

stale bot removed the needs-attention label Apr 25, 2022

stale bot added the needs-attention label Sep 9, 2022

rkothiya pushed a commit that referenced this issue Sep 11, 2022

CORTX-30751: Codacy code cleanup (#1606) (#1921)

19b6fbd

This patch fixes some of the codacy warnings. warning fixed : "Double quote to prevent globing and words splitting". Signed-off-by: alfhad <fahadshah2411@gmail.com>

stale bot removed the needs-attention label Sep 11, 2022

hessio added Triage: DevTeam Triage owner is on the dev team Status: WIP This PR is still being worked on Status: Backlog issue will be fixed at some point labels Sep 15, 2022

stale bot added the needs-attention label Sep 20, 2022

shailesh-vaidya closed this as completed Feb 8, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Codacy code cleanup] occurrence: 1688 pattern: Double quote to prevent globbing and word splitting #1606

[Codacy code cleanup] occurrence: 1688 pattern: Double quote to prevent globbing and word splitting #1606

rkothiya commented Apr 12, 2022 •

edited

Loading

cortx-admin commented Apr 12, 2022

rkothiya commented Apr 13, 2022

cortx-admin commented Apr 13, 2022

cortx-admin commented Apr 13, 2022

cortx-admin commented Apr 14, 2022

cortx-admin commented Apr 18, 2022

cortx-admin commented Apr 19, 2022

stale bot commented Apr 23, 2022

rkothiya commented Apr 25, 2022

cortx-admin commented Apr 25, 2022

rkothiya commented Apr 26, 2022

rkothiya commented Apr 26, 2022

cortx-admin commented Apr 26, 2022

stale bot commented Sep 9, 2022

cortx-admin commented Sep 11, 2022

cortx-admin commented Sep 12, 2022

cortx-admin commented Sep 13, 2022

stale bot commented Sep 20, 2022

shailesh-vaidya commented Feb 8, 2024

[Codacy code cleanup] occurrence: 1688 pattern: Double quote to prevent globbing and word splitting #1606

[Codacy code cleanup] occurrence: 1688 pattern: Double quote to prevent globbing and word splitting #1606

Comments

rkothiya commented Apr 12, 2022 • edited Loading

Problem

Expected behavior

How to reproduce

Deployment information

Additional information

cortx-admin commented Apr 12, 2022

rkothiya commented Apr 13, 2022

cortx-admin commented Apr 13, 2022

cortx-admin commented Apr 13, 2022

cortx-admin commented Apr 14, 2022

cortx-admin commented Apr 18, 2022

cortx-admin commented Apr 19, 2022

stale bot commented Apr 23, 2022

rkothiya commented Apr 25, 2022

cortx-admin commented Apr 25, 2022

rkothiya commented Apr 26, 2022

rkothiya commented Apr 26, 2022

cortx-admin commented Apr 26, 2022

stale bot commented Sep 9, 2022

cortx-admin commented Sep 11, 2022

cortx-admin commented Sep 12, 2022

cortx-admin commented Sep 13, 2022

stale bot commented Sep 20, 2022

shailesh-vaidya commented Feb 8, 2024

rkothiya commented Apr 12, 2022 •

edited

Loading