Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

Fix Codacy Badge #2077

Merged
merged 5 commits into from
Aug 17, 2022
Merged

Fix Codacy Badge #2077

merged 5 commits into from
Aug 17, 2022

Conversation

hessio
Copy link
Contributor

@hessio hessio commented Aug 15, 2022 •
edited
Loading

Signed-off-by: Patrick Hession patrick.hession@seagate.com

Problem Statement

  • The Codacy badge was not working

Design

  • So I changed the link so the badge works

Coding

Checklist for Author

  • Coding conventions are followed and code is consistent

Testing

Checklist for Author

  • Unit and System Tests are added
  • Test Cases cover Happy Path, Non-Happy Path and Scalability
  • Testing was performed with RPM

Impact Analysis

Checklist for Author/Reviewer/GateKeeper

  • Interface change (if any) are documented
  • Side effects on other features (deployment/upgrade)
  • Dependencies on other component(s)

Review Checklist

Checklist for Author

  • JIRA number/GitHub Issue added to PR
  • PR is self reviewed
  • Jira and state/status is updated and JIRA is updated with PR link
  • Check if the description is clear and explained

Documentation

Checklist for Author

  • Changes done to WIKI / Confluence page / Quick Start Guide

View rendered README.md

@hessio
Fix Codacy Badge
935ff7b 
Signed-off-by: Patrick Hession <patrick.hession@seagate.com>
@cla-bot cla-bot bot added the cla-signed label Aug 15, 2022
@rkothiya
Copy link
Contributor

Hi @hessio can you please update the problem description and the design section so that we know why this patch is required.

@hessio
Copy link
Contributor Author

hessio commented Aug 16, 2022

Hi @hessio can you please update the problem description and the design section so that we know why this patch is required.

Hi @rkothiya, updated please review and merge when you have time

@rkothiya
Copy link
Contributor

As change in documentation giving an exception for pre-merge jobs.

@rkothiya rkothiya added the Exception Allowed to merge without runing ut and st label Aug 17, 2022
@rkothiya rkothiya merged commit 60c6d3b into main Aug 17, 2022
kiwionly2 pushed a commit to kiwionly2/cortx-motr that referenced this pull request Aug 30, 2022
@hessio @kiwionly2
Fix Codacy Badge (Seagate#2077)
63e62d8 
Problem : 
The Codacy badge was not working.

Solution: 
Changed the link so that the badge works.

Signed-off-by: Patrick Hession <patrick.hession@seagate.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anaghadeshmukh anaghadeshmukh anaghadeshmukh approved these changes

@mehjoshi mehjoshi Awaiting requested review from mehjoshi

@madhavemuri madhavemuri Awaiting requested review from madhavemuri

@nikitadanilov nikitadanilov Awaiting requested review from nikitadanilov

@yeshpal-jain-seagate yeshpal-jain-seagate Awaiting requested review from yeshpal-jain-seagate

@huanghua78 huanghua78 Awaiting requested review from huanghua78

@andriytk andriytk Awaiting requested review from andriytk andriytk is a code owner

@siningwuseagate siningwuseagate Awaiting requested review from siningwuseagate siningwuseagate is a code owner

@vidyadhar-pinglikar vidyadhar-pinglikar Awaiting requested review from vidyadhar-pinglikar

@shashank-parulekar shashank-parulekar Awaiting requested review from shashank-parulekar

@nkommuri nkommuri Awaiting requested review from nkommuri nkommuri is a code owner

@sg-shankar sg-shankar Awaiting requested review from sg-shankar

@yatin-mahajan yatin-mahajan Awaiting requested review from yatin-mahajan

@rkothiya rkothiya Awaiting requested review from rkothiya

Assignees

@nikitadanilov nikitadanilov

@madhavemuri madhavemuri

@mehjoshi mehjoshi

Labels
cla-signed Exception Allowed to merge without runing ut and st
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hessio @rkothiya @anaghadeshmukh @nikitadanilov @madhavemuri @mehjoshi