Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

CORTX-33878_fix_alex_issues #2081

Merged
merged 3 commits into from
Aug 29, 2022

Conversation

swapnil-seagate
Copy link
Contributor

@swapnil-seagate swapnil-seagate commented Aug 16, 2022

CORTX-33878_fix_alex_issues
Fixed the issues reported by the Alex tool and added suitable replacement words for the issues reported.

Problem Statement

  • Alex tool creates a report based on the keywords which needs to be removed from motr code repo. This needs to replaced as part of this ticket.

Coding

Checklist for Author

  • [ Y] Coding conventions are followed and code is consistent

Testing

Checklist for Author

  • Unit and System Tests are added
  • Test Cases cover Happy Path, Non-Happy Path and Scalability
  • Testing was performed with RPM

Impact Analysis

Checklist for Author/Reviewer/GateKeeper

  • Interface change (if any) are documented
  • Side effects on other features (deployment/upgrade)
  • Dependencies on other component(s)

Review Checklist

Checklist for Author

  • [Y ] JIRA number/GitHub Issue added to PR
  • [ Y] PR is self reviewed
  • [ Y] Jira and state/status is updated and JIRA is updated with PR link
  • [Y ] Check if the description is clear and explained

Documentation

Checklist for Author

  • Changes done to WIKI / Confluence page / Quick Start Guide

View rendered CONTRIBUTING.md
View rendered SUPPORT.md
View rendered doc/ISC-Service-User-Guide.md
View rendered doc/Motr-Lnet-Transport.md

Fixed the issues reported by the Alex tool and added suitable replacement words for the issues reported.

Signed-off-by: Swapnil Chaudhary <swapnil.chaudhary@seagate.com>
@swapnil-seagate swapnil-seagate force-pushed the CORTX-33878_fix_alex_issues branch from 4e16a47 to 6f63fcb Compare August 16, 2022 10:21
@nkommuri
Copy link

These changes effect "make doc"? If so, can yo please test it

Copy link

@huanghua78 huanghua78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@swapnil-seagate
Copy link
Contributor Author

swapnil-seagate commented Aug 29, 2022

These changes effect "make doc"? If so, can yo please test it

Attaching the make doc output
Make_doc_output.txt

Signed-off-by: Swapnil Chaudhary <swapnil.chaudhary@seagate.com>
@swapnil-seagate swapnil-seagate force-pushed the CORTX-33878_fix_alex_issues branch from 9d0dcda to af629be Compare August 29, 2022 06:01
@rkothiya
Copy link
Contributor

Jenkins CI Result : Motr#1656

Motr Test Summary

Test ResultCountInfo
❌Failed1
📁

01motr-single-node/00userspace-tests

🏁Skipped32
📁

01motr-single-node/28sys-kvs
01motr-single-node/35m0singlenode
01motr-single-node/04initscripts
01motr-single-node/37protocol
02motr-single-node/51kem
02motr-single-node/20rpc-session-cancel
02motr-single-node/10pver-assign
02motr-single-node/21fsync-single-node
02motr-single-node/13dgmode-io
02motr-single-node/14poolmach
02motr-single-node/11m0t1fs
02motr-single-node/26motr-user-kernel-tests
02motr-single-node/08spiel
03motr-single-node/06conf
03motr-single-node/36spare-reservation
04motr-single-node/34sns-repair-1n-1f
04motr-single-node/08spiel-sns-repair-quiesce
04motr-single-node/28sys-kvs-kernel
04motr-single-node/11m0t1fs-rconfc-fail
04motr-single-node/08spiel-sns-repair
04motr-single-node/19sns-repair-abort
04motr-single-node/22sns-repair-ios-fail
05motr-single-node/18sns-repair-quiesce
05motr-single-node/12fwait
05motr-single-node/16sns-repair-multi
05motr-single-node/07mount-fail
05motr-single-node/15sns-repair-single
05motr-single-node/23sns-abort-quiesce
05motr-single-node/17sns-repair-concurrent-io
05motr-single-node/07mount
05motr-single-node/07mount-multiple
05motr-single-node/12fsync

✔️Passed44
📁

01motr-single-node/43m0crate
01motr-single-node/05confgen
01motr-single-node/06hagen
01motr-single-node/52motr-singlenode-sanity
01motr-single-node/01net
01motr-single-node/01kernel-tests
01motr-single-node/03console
01motr-single-node/02rpcping
02motr-single-node/07m0d-fatal
02motr-single-node/67fdmi-plugin-multi-filters
02motr-single-node/53clusterusage-alert
02motr-single-node/41motr-conf-update
03motr-single-node/61sns-repair-motr-1n-1f
03motr-single-node/72spiel-sns-motr-repair-quiesce
03motr-single-node/08spiel-multi-confd
03motr-single-node/69sns-repair-motr-quiesce
03motr-single-node/62sns-repair-motr-mf
03motr-single-node/70sns-failure-after-repair-quiesce
03motr-single-node/63sns-repair-motr-1k-1f
03motr-single-node/60sns-repair-motr-1f
03motr-single-node/66sns-repair-motr-abort-quiesce
03motr-single-node/24motr-dix-repair-lookup-insert-spiel
03motr-single-node/68sns-repair-motr-shutdown
03motr-single-node/64sns-repair-motr-ios-fail
03motr-single-node/71spiel-sns-motr-repair
03motr-single-node/24motr-dix-repair-lookup-insert-m0repair
03motr-single-node/04sss
03motr-single-node/65sns-repair-motr-abort
04motr-single-node/73motr-io-small-disks
04motr-single-node/48motr-raid0-io
04motr-single-node/74motr-di-corruption-detection
04motr-single-node/49motr-rpc-cancel
04motr-single-node/25m0kv
04motr-single-node/44motr-rm-lock-cc-io
04motr-single-node/45motr-rmw
05motr-single-node/23dix-repair-m0repair
05motr-single-node/43motr-sync-replication
05motr-single-node/42motr-utils
05motr-single-node/45motr-sns-repair-N-1
05motr-single-node/40motr-dgmode
05motr-single-node/23dix-repair-quiesce-m0repair
05motr-single-node/23spiel-dix-repair-quiesce
05motr-single-node/44motr-sns-repair
05motr-single-node/23spiel-dix-repair

Total77🔗

CppCheck Summary

   Cppcheck: No new warnings found 👍

@rkothiya rkothiya merged commit 2b4ee2e into Seagate:main Aug 29, 2022
kiwionly2 pushed a commit to kiwionly2/cortx-motr that referenced this pull request Aug 30, 2022
Fixed the issues reported by the Alex tool and added suitable 
replacement words for the issues reported.

Signed-off-by: Swapnil Chaudhary <swapnil.chaudhary@seagate.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants