Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

build-prep-1node.sh: improve to use by non-root users #373

Merged
merged 9 commits into from
Feb 4, 2021

Conversation

andriytk
Copy link
Contributor

It's still required that the user have sudo privileges to run the script though.

It's still required that the user have sudo privileges
to run the script though.

Signed-off-by: Andriy Tkachuk <andriy.tkachuk@seagate.com>
@nezzzu
Copy link

nezzzu commented Jan 29, 2021

Also, if we can have 3 pools and if the hctl status output resembles that of Sage cluster then same motraddr.sh script in m0client-sample-apps can be used. @andriytk ?

@nezzzu
Copy link

nezzzu commented Jan 29, 2021

A further improvement would be to completely skip the build step if the required rpms are already installed on the system (or just an option to skip the build step) and go directly to single node setup steps. This will probably require the singlenode.yaml contents incorporated in the script if they are not rpm installed by default. @andriytk ?

@andriytk
Copy link
Contributor Author

andriytk commented Jan 29, 2021

@nezzzu this is devvm - for development purposes, not just install and run. But we can add the commands to build rpms there probably also.

m0client-sample-apps can be used even now without multiple pools, one pool is enough. The rc-files for the utilities can be created manually.

Not familiar with motraddr.sh script, cannot advise on that.

Copy link

@huanghua78 huanghua78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

13 ./scripts/install-motr-service

21 make && make devinstall

also need sudo, I think.

@andriytk
Copy link
Contributor Author

Yes, thanks @huanghua78 .

The default mode would be to build and install rpms.
The development mode is available with the `-dev` option now.

Signed-off-by: Andriy Tkachuk <andriy.tkachuk@seagate.com>
@andriytk
Copy link
Contributor Author

andriytk commented Jan 29, 2021

@nezzzu as you suggested - it builds and installs rpms by default now. The development mode is still available via the -dev cmdline option.

Please review and give it a try.

@andriytk andriytk requested a review from huanghua78 January 29, 2021 13:45
Signed-off-by: Andriy Tkachuk <andriy.tkachuk@seagate.com>
Signed-off-by: Andriy Tkachuk <andriy.tkachuk@seagate.com>
Signed-off-by: Andriy Tkachuk <andriy.tkachuk@seagate.com>
Signed-off-by: Andriy Tkachuk <andriy.tkachuk@seagate.com>
Signed-off-by: Andriy Tkachuk <andriy.tkachuk@seagate.com>
Use the real node hostname instead of "cmu" always.

Signed-off-by: Andriy Tkachuk <andriy.tkachuk@seagate.com>
@stale
Copy link

stale bot commented Feb 2, 2021

This issue/pull request has been marked as needs attention as it has been left pending without new activity for 4 days. Tagging @huanghua78 @mukundkanekar for appropriate assignment. Sorry for the delay & Thank you for contributing to CORTX. We will get back to you as soon as possible.

@stale stale bot added the needs-attention label Feb 2, 2021
@stale stale bot removed the needs-attention label Feb 4, 2021
@madhavemuri madhavemuri merged commit fa8d537 into Seagate:main Feb 4, 2021
@andriytk andriytk deleted the build-prep-1node-no-sudo branch February 4, 2021 20:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants