Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

rgw_sal_motr : [CORTX-32485] Fix issues for get-object-tagging API without version-id parameter in versioning suspended bucket #384

Merged
merged 1 commit into from
Aug 9, 2022
Merged

rgw_sal_motr : [CORTX-32485] Fix issues for get-object-tagging API without version-id parameter in versioning suspended bucket #384

merged 1 commit into from
Aug 9, 2022

Conversation

priyanka25081999
Copy link

@priyanka25081999 priyanka25081999 commented Aug 8, 2022 •
edited by sachitanands
Loading

Problem Statement:

  • Get object tagging API without version-id parameter does not return tagset for latest object versions
  • Put object tagging for null version-id, adds new null object entry instead of overwrite the existing one.

Solution:

  • In put-object-tagging, removed the modified time (mtime) statement
  • For Get/HEAD object API in case of null object entry, remove the "null" from instance to avoid "VersionId" field in the response.

Signed-off-by: Priyanka Salunke priyanka.s.salunke@seagate.com

Checklist

  • Tracker (select at least one)
    • References tracker ticket
    • Very recent bug; references commit where it was introduced
    • New feature (ticket optional)
    • Doc update (no ticket needed)
    • Code cleanup (no ticket needed)
  • Component impact
    • Affects Dashboard, opened tracker ticket
    • Affects Orchestrator, opened tracker ticket
    • No impact that needs to be tracked
  • Documentation (select at least one)
    • Updates relevant documentation
    • No doc update is appropriate
  • Tests (select at least one)
Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox

@github-actions github-actions bot added the rgw label Aug 8, 2022
@priyanka25081999 priyanka25081999 self-assigned this Aug 8, 2022
sachitanands
sachitanands approved these changes Aug 8, 2022
View reviewed changes
Copy link

@sachitanands sachitanands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@priyanka25081999
Copy link
Author

Tested the deployment with below images :

shraddhaghatol
shraddhaghatol approved these changes Aug 8, 2022
View reviewed changes
Copy link

@shraddhaghatol shraddhaghatol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@priyanka25081999
rgw_sal_motr : [CORTX-32485] Fix issues for get-object-tagging API wi…
e879a8d 
…thout version-id parameter in versioning suspended bucket

Signed-off-by: Priyanka Salunke <priyanka.s.salunke@seagate.com>
@priyanka25081999
Copy link
Author

retest this please

@sachitanands sachitanands merged commit 0edd8ff into Seagate:main Aug 9, 2022
jjxsg pushed a commit that referenced this pull request Aug 22, 2022
@priyanka25081999 @jjxsg
rgw_sal_motr : [CORTX-32485] Fix issues for get-object-tagging API wi…
e0f7d3d 
…thout version-id parameter in versioning suspended bucket (#384)

Problem Statement:
1) Get object tagging API without version-id parameter does not return tagset for latest object versions
2) Put object tagging for null version-id, adds new null object entry instead of overwrite the existing one.
Solution:
1) In put-object-tagging, removed the modified time (mtime) statement
2) For Get/HEAD object API in case of null object entry, remove the "null" from instance to avoid "VersionId" field in the response.
Signed-off-by: Priyanka Salunke <priyanka.s.salunke@seagate.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shraddhaghatol shraddhaghatol shraddhaghatol approved these changes

@sachitanands sachitanands sachitanands approved these changes

@shriya-deshmukh shriya-deshmukh shriya-deshmukh approved these changes

@cdeshmukh cdeshmukh Awaiting requested review from cdeshmukh

Assignees

@priyanka25081999 priyanka25081999

Labels
rgw
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@priyanka25081999 @shriya-deshmukh @sachitanands @shraddhaghatol