This repository has been archived by the owner on Feb 8, 2024. It is now read-only.
rgw_sal_motr: [CORTX-32697] support user remove with purge data #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DPG17
approved these changes
Sep 13, 2022
jjxsg
approved these changes
Sep 13, 2022
sjain09
approved these changes
Sep 13, 2022
cdeshmukh
approved these changes
Sep 13, 2022
Problem: During Remove User code-flow till the DeleteOp is instantiated for each obj from a bucket, we don't have the access to req_state ptr via RGWObjectCtx. This causes the addb.set_id(rctx) to fail, as it tries to access the req_id from null req_state ptr. Solution: To avoid the situation, guarded the addb.set_id() call by checking if we have the req_state ptr accesible and generated the unique req_id per delete obj request. Signed-off-by: Sumedh Anantrao Kulkarni <sumedh.a.kulkarni@seagate.com>
sumedhak27
force-pushed
the
motr/user_rm/purge_delete
branch
from
cbfa323 to
6a19f5a
Compare
sjain09
approved these changes
Sep 13, 2022
jjxsg
approved these changes
Sep 13, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
During the Remove User code flow till the DeleteOp is instantiated for each obj from a bucket, we don't have the access to req_state ptr via RGWObjectCtx. This causes the addb.set_id(rctx) to fail, as it tries to access the req_id from null req_state ptr.
Solution:
To avoid the above situation, guarded the addb.set_id() call by checking if we have the req_state ptr accessible.
If inaccessible then generate the new req_id for each delete req.
Signed-off-by: Sumedh Anantrao Kulkarni sumedh.a.kulkarni@seagate.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume tox