Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

Added test comment #894

Merged
merged 2 commits into from
Apr 6, 2021

Conversation

stx-hseow
Copy link
Contributor

Signed-off-by: Harrison Seow harrison.seow@seagate.com

Describe your changes in brief

Changes

  • Why is this change required? What problem does it solve?
  • If proposing a new change then please raise an issue first

Confirmed steps in the guide by testing

How Has This Been Tested? (Optional)

  • Please describe in detail how you tested your changes.
  • Include details of your testing environment, and the tests you ran to
  • How your change affects other areas of the code, etc.

Tested on Windows 10 Desktop, running VMWare Workstation 16 Player.
More info on this issue.

Screenshots (if appropriate)

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

Signed-off-by: Harrison Seow <harrison.seow@seagate.com>
Copy link
Contributor

@shailesh-vaidya shailesh-vaidya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. @harrison-seow-seagate Thanks for validating the steps.

@mukul-seagate11
Copy link
Contributor

duplicate of #895

@shailesh-vaidya
Copy link
Contributor

@mukul-seagate11 I guess this is not a duplicate of #895 . #895 is for doc/CORTX_on_Open_Virtual_Appliance.rst and this (#894) is for doc/Release_Build_Creation.rst

@stx-hseow
Copy link
Contributor Author

Hi @mukul-seagate11, this is not a duplicate.

@mukul-seagate11
Copy link
Contributor

yes, I had re-opened the PR

Copy link
Contributor

@mukul-seagate11 mukul-seagate11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@mukul-seagate11 mukul-seagate11 merged commit a9016a8 into Seagate:main Apr 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants