Use Ruff code and body as Diagnostic code and body #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
commented
Oct 30, 2022
| @@ -13,8 +13,6 @@ use std::sync::Arc; | |||
| // TODO macro the unwrapping of state_handles | |||
|
|
|||
| fn message_into_diagnostic(msg: Message) -> lsp_types::Diagnostic { | |||
| // As ruff currently doesn't support the span of the error, | |||
| // only have it span a single character | |||
There was a problem hiding this comment.
I believe these comments are stale.
There was a problem hiding this comment.
Definitely stale, there's more stale comments around I'll look to clean up, most notably around TODOs
charliermarsh
force-pushed
the
charlie/message
branch
from
ca943c1 to
44ab6ec
Compare
Seamooo
reviewed
Oct 31, 2022
| @@ -31,10 +29,9 @@ fn message_into_diagnostic(msg: Message) -> lsp_types::Diagnostic { | |||
| }; | |||
| lsp_types::Range { start, end } | |||
| }; | |||
| let code = Some(lsp_types::NumberOrString::String(msg.kind.body())); | |||
There was a problem hiding this comment.
Thanks for catching this! I'm pretty sure it's a regression issue from when the code interface changed
|
Happy to merge after the small formatting fix |
charliermarsh
force-pushed
the
charlie/message
branch
from
44ab6ec to
29ddd04
Compare
charliermarsh
force-pushed
the
charlie/message
branch
from
29ddd04 to
5ec41f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This more closely mirrors the behavior of other linters (i.e., the code appears in parentheses):