Add memory mapping #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`DiskArrayVariable` and `DiskArrayMesh`
We now have strings as the keys for the blocks
Codecov Report
@@ Coverage Diff @@
## master #39 +/- ##
==========================================
- Coverage 92.10% 82.53% -9.58%
==========================================
Files 8 9 +1
Lines 266 292 +26
==========================================
- Hits 245 241 -4
- Misses 21 51 +30
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
MmapedVariableandMmapedParticleMesh, which memory map the underlying SDF blocks.MmapedVariableis used forPlainVariableBlockHeader&PointVariableBlockHeaderand will provide a reshaped array matching the block size.MmapedParticleMeshis used forPointMeshBlockHeaderand it also needs the user to supply the axis, as the blocks contain the data for all axes.Since
PlainMeshBlockHeaderis the mesh given by the "grid" block (the grid for fields), there's no need to mmap it, we can just represtent it with a range.This PR also introduces a breaking change in the represontation of blocks, we now use dictionaries with strings instead of symbols, as there was no advantage of using symbols and we were always converting stings to symbols.