Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(PolylinePoint): prevent accessing undefined variable on change #1597

Merged
4 commits merged into from
Jun 3, 2019

Conversation

mathstlouis
Copy link
Contributor

Bug already discussed in the following issue:
#1268

When updating only the latitude or longitude of a PolylinePoint, an error is thrown by ngOnChanges.

@codecov
Copy link

codecov bot commented Feb 15, 2019

Codecov Report

Merging #1597 into master will increase coverage by 0.26%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1597      +/-   ##
==========================================
+ Coverage   33.09%   33.35%   +0.26%     
==========================================
  Files          37       37              
  Lines        1644     1646       +2     
  Branches      129      131       +2     
==========================================
+ Hits          544      549       +5     
+ Misses       1098     1095       -3     
  Partials        2        2
Impacted Files Coverage Δ
packages/core/directives/polyline-point.ts 100% <100%> (+30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7922546...03ddd05. Read the comment docs.

@stale
Copy link

stale bot commented May 31, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label May 31, 2019
@ghost ghost removed the stale label Jun 2, 2019
@ghost ghost merged commit 21efc4f into sebholstein:master Jun 3, 2019
@ghost ghost mentioned this pull request Jun 20, 2019
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants