bug fix on polyline-point #1229
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgutix
suggested changes
Nov 14, 2017
| lat: changes['latitude'].currentValue, | ||
| lng: changes['longitude'].currentValue | ||
| lat: changes['latitude'] ? changes['latitude'].currentValue : null, // before this change it will fail if the there was no change in both latitude and longitude | ||
| lng: changes['longitude'] ? changes['longitude'].currentValue : null // before this change it will fail if the there was no change in both latitude and longitude |
There was a problem hiding this comment.
@tomokohn those values are checked in the if, I haven't found this issue, but I would suggest a more strong check like:
if (!!changes['latitude'] || !!changes['longitude']) {
instead of double checking those values.
There was a problem hiding this comment.
this change was made after i found a bug when only one of these parameters changes.
it fix this issue : #1100
There was a problem hiding this comment.
I see @tomokohn in that case the if is useless
muhammad-habib
approved these changes
Sep 16, 2018
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
ghost
suggested changes
Jun 20, 2019
|
actually, my bad, I forgot this was already fixed and merged in #1597 |
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a suggestion to fix a bug occurring when the you update position on polyline-point