Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Folder and file with the same (base)name gets ordered by creation time for a-z and true a-z orders #127

Closed
SebastianMC opened this issue Jan 25, 2024 · 1 comment · Fixed by #129
Assignees
Labels
enhancement New feature or request

Comments

@SebastianMC
Copy link
Owner

Following this suggestion from @cmasfo in discussion thread #122, remove the randomness.

Potential solution options include:

  • assume some reasonable behavior, like if none of the sorting levels (5 supported now) puts two items in order, let file go before a folder (if one item is a file and the other is a folder)
    • this option is preferred for simplicity
  • introduce new explicit sorting order which allows specifying folders or files to go first
    • tempting, yet because it would consume one level of sorting specifications, other options should also be exposed
SebastianMC added a commit that referenced this issue Jan 25, 2024
…port:

- the last-resort default fallback sorting method (which was alphabetical) is extended to give preference to files. In other words, if all the specified sorting levels don't sort two items, the file goes first (if the other item is a folder)
- added explicit syntax to specify `files-first` or `folders-first`
@SebastianMC SebastianMC self-assigned this Jan 25, 2024
@SebastianMC SebastianMC added the enhancement New feature or request label Jan 25, 2024
SebastianMC added a commit that referenced this issue Jan 25, 2024
…-same-basename-sorting

#127 - folder and file with the same (base) name advanced sorting support
@SebastianMC
Copy link
Owner Author

Done.

  • Added explicit syntax to specify files-first or folders-first orders
  • the last-resort default fallback sorting method (which was alphabetical) is extended to give preference to files. In other words, if all the specified sorting levels don't oder two items, the file goes first (if the other item is a folder)

SebastianMC added a commit that referenced this issue Jan 25, 2024
…port:

- bugfix for `files-first` or `folders-first` sorting methods
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant