Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impose File Explorer refresh with standard sorting when the plugin gets disabled (if technically possible) #137

Closed
SebastianMC opened this issue Feb 29, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@SebastianMC
Copy link
Owner

SebastianMC commented Feb 29, 2024

As reported in #131 and later on in #135, the File Explorer recovery process from messed-up state could be confusing to the user. When Obsidian with breaking changes in File Explorer (1.5.4 or newer Obsidian release) meets the plugin in version earlier than 2.1.7, the File Explorer view stops showing correctly the deeper levels (2nd and deeper) of folders tree. The recovery process is multi-step and doesn't include only disabling/uninstalling the plugin, a restart of Obsidian is required.

Let me find out if a plugin (like custom-sort) is capable of graceful handling of the disable / uninstall scenario: detect the disabling / uninstalling action and, in the last second of its existence, impose the File Explorer view refresh with standard sorting. This would make the potential future scenarios of recovery from Obsidian breaking changes a little bit less confusing.

@SebastianMC SebastianMC added the enhancement New feature or request label Feb 29, 2024
@SebastianMC SebastianMC self-assigned this Feb 29, 2024
@SebastianMC SebastianMC changed the title Impose File Explorer refresh with standard sorting when the plugin gets disabled Impose File Explorer refresh with standard sorting when the plugin gets disabled (if technically possible) Feb 29, 2024
SebastianMC added a commit that referenced this issue Jun 7, 2024
@SebastianMC
Copy link
Owner Author

Included in 2.1.10 release of the plugin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant