Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest update broke my UI #16

Closed
SleepyBlueCat opened this issue Aug 23, 2020 · 20 comments
Closed

Latest update broke my UI #16

SleepyBlueCat opened this issue Aug 23, 2020 · 20 comments

Comments

@SleepyBlueCat
Copy link

SleepyBlueCat commented Aug 23, 2020

Hey latest update broke my UI. Some buttons were suddenly missing, it showed the disconnect button but my printer wasn't connected. see picture

Restarting in safe mode and opening the octoprint log showed me that this plugin was the last one i've updated so i deleted the plugin and now everything is okay again.
see second image

I'd be happy to work on this if you want to test more.
Kind regards

@Sebclem
Copy link
Owner

Sebclem commented Aug 23, 2020

Can i have your chrome logs ? (F12)

@SleepyBlueCat
Copy link
Author

I don't think logging in my chrome is turned on? Where do i find it? I pressed F12 but I don't see any logging.
The same UI thing was on my phone and Firefox (pc) as well.

@Sebclem
Copy link
Owner

Sebclem commented Aug 23, 2020

Normaly, if you press F12, you have the DevTool that open. Just click on the console tab in DevTool window.
You will normaly have something like this:
image

@SleepyBlueCat
Copy link
Author

there you go. Note that I said that I did delete the plugin. Do you want me to install the latest version again?
image

@Sebclem
Copy link
Owner

Sebclem commented Aug 23, 2020

Yes please

@SleepyBlueCat
Copy link
Author

Hmmm i have another issue now... Do you think it would be related?
image

@SleepyBlueCat
Copy link
Author

i'm gonna restart my router

@Sebclem
Copy link
Owner

Sebclem commented Aug 23, 2020

Hum very strange, maybe try to reboot the octoprint.
I don't think this 2 bugs are related.

@SleepyBlueCat
Copy link
Author

I did, even rebooted the pi itself. Gotta figure this out and come back to you.

@SleepyBlueCat
Copy link
Author

okay, router reboot did it. Installed the plugin again but same thing. Here's the log
image

@SleepyBlueCat
Copy link
Author

i can also chat on discord and such if you'd like

@Sebclem
Copy link
Owner

Sebclem commented Aug 23, 2020

Can i have your octoprint version ?

@SleepyBlueCat
Copy link
Author

OctoPrint 1.3.12 running on OctoPi 0.17.0

@Sebclem
Copy link
Owner

Sebclem commented Aug 23, 2020

Ok i think i figured out.
I think something as ben change for user permission between Octoprint 1.3.12 and the last version.
@foosel can you confirm this ?

@heylael
Copy link

heylael commented Nov 9, 2020

I'm seeing this issue as well - same install from Octopi and then installed the plugin using a zip file. Installed Dashboard plugin, Display Layer Progress, and then Simple Emergency stop, and most of the navbar vanishes. All I have is the Admin menu.

@SleepyBlueCat
Copy link
Author

I have all the same plugins installed and more.

@foosel
Copy link

foosel commented Nov 9, 2020

I think something as ben change for user permission between Octoprint 1.3.12 and the last version.
@foosel can you confirm this ?

The permission system was literally rewritten in 1.4.0, see also the release notes ;) https://github.com/OctoPrint/OctoPrint/releases/tag/1.4.0

Your plugin as is seems to not be compatible to 1.3.x and needs at least 1.4.0.

@SleepyBlueCat
Copy link
Author

@Sebclem Is there a sollution?

@Sebclem
Copy link
Owner

Sebclem commented Nov 23, 2020

Easy and fast fix: Upgrade your octoprint to 1.4.0+

For older version, I will take a look.

@Sebclem
Copy link
Owner

Sebclem commented Nov 23, 2020

I have made a new release that will normally prevent this issue, please confirm me that, but like i say in the readme here:

Octoprint < 1.4.0:

If you are running Octoprint < 1.4.0, there is no permission check, every user can access to the emergency stop button (as soon as they are logged in).

This is why I highly recommend to upgrade your octoprint to > 1.4.0

@Sebclem Sebclem closed this as completed Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants