Refactored reminder service to job for JobScheduler #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 4, 2024 21:28
… the past. I suspect it was unintentional. At least the AutoStartReceiver gets not started without it. So I did add it again. README.md calls the permission RECEIVE_ON_BOOT_COMPLETE. But that seems to be wrong and got renamed to RECEIVE_BOOT_COMPLETED. Checking action string at AutoStartReceiver#onReceive() as suggested by android studio. Extended logging of ReminderService.
…PI level 26) the reminder service should be refactored. As preparation for that the alarm and notification handling was moved to AlarmMgr and NotificationMgr. An Alarm now does not start service directly but sends a broadcast that gets received by the new AlarmReceiver. AlarmReceiver and AutoStartReceiver start the ReminderService. MainActivity does not need to start the service anymore.
…This should fix #106. I'm not 100% sure about that because I could not reproduce these crashes. Set minSdkVersion from 19 to 21 to be able to use JobScheduler. Changed PreferenceMgr from class to object (singleton). The logic to determine if alarm should be set was moved from MainActivity#onTaskChange() to AlarmMgr#setAlarmForTask(). global_constants.xml: Fixed constant one_day. It was in milliseconds but seconds are required. Deleted array.xml files in some (but not all) language dependent folders. The content of array.xml needs no translation.
This was referenced Apr 12, 2024
Closed
Merged
This was referenced Dec 19, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Background Execution Limits that were introduced with Android 8.0 (API level 26) could be the cause for crashes of the app after system boot.
The solution seems to be to do the Background Work with a JobScheduler.
Due to this the reminder service was refactored to a job for the JobScheduler.
However, the crashes could not be reproduced so it is not sure that this change does fix issue #106.