Skip to content

Commit

Permalink
Simplify for Clarity and Correctness
Browse files Browse the repository at this point in the history
The state wasn't backwards, my understanding was. The button begins enabled and the table rows are visible, toggling it off removes the rows and shows only the packet data in order. NextTick isn't needed as the model is correct. I was wrong about the order of events with the last fix.
  • Loading branch information
coreyogburn committed Jan 13, 2025
1 parent 24a619c commit 299458a
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions html/js/routes/job.js
Original file line number Diff line number Diff line change
Expand Up @@ -149,13 +149,10 @@ routes.push({ path: '/job/:jobId', name: 'job', component: {
return this.packetOptions.indexOf(option) != -1;
},
captureLayoutAsStream() {
// wait for v-btn-toggle to update model
this.$nextTick(() => {
if (!this.isOptionEnabled('packets')) return;
if (this.isOptionEnabled('packets')) return;

this.expandPackets(true);
this.sortBy = [{ key: 'number', order: 'asc' }];
});
this.expandPackets(true);
this.sortBy = [{ key: 'number', order: 'asc' }];
},
packetsUpdated() {
if (this.expandAll) {
Expand Down

0 comments on commit 299458a

Please sign in to comment.