Replace Virtual Table #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v-data-table-virtual says on the tin that it "relies on all data being available locally but unlike the standard data-table it uses virtualization to only render a small portion of the rows." This makes it not a good fit for use showing alert detail rows in the ungrouped Alerts table. We're only rendering a small portion of rows (a little over half) upon expanding a row. The behavior appears glitchy rather than intended when you expand a second row and the first row fills out it's missing rows. Now the table is the non-virtual variant with items-per-page set to -1 so we see every row as expected.
jertel
approved these changes
Jan 13, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v-data-table-virtual says on the tin that it "relies on all data being available locally but unlike the standard data-table it uses virtualization to only render a small portion of the rows." This makes it not a good fit for use showing alert detail rows in the ungrouped Alerts table. We're only rendering a small portion of rows (a little over half) upon expanding a row. The behavior appears glitchy rather than intended when you expand a second row and the first row fills out it's missing rows.
Now the table is the non-virtual variant with items-per-page set to -1 so we see every row as expected.